<div dir="ltr">Hi all,<div><br></div><div>currently our GlanceImageService seems to support several ways of defining a reference to glance image:</div><div><br></div><div>1) simple image UUID [0]</div><div>2) image UUID prefixed with 'glance://' protocol [1] (well, actually anything starting with 'glance://' and ending with '/<uuid>')</div><div>3) full REST path to the image (as in http://<glance-api>/v2/images/<image-uuid>), also used to extract the glance API address [2]</div><div><br></div><div>Support for #3 must surely be removed, as we are moving to API endpoint discovery from keystone catalog.</div><div>Besides I am pretty sure this code path can not actually be reached currently, as the 'is_glance_image' will ignore such image refs and return False for those [3], and 'get_image_service' would also not return the GlanceImageService instance for such image refs [4].</div><div>Hence the question - if it is unusable anyway now, should we execute the standard deprecation process when removing support for it or just remove right away?</div><div><div><br></div><div>As for the #1 and #2 I do not see any big difference between those, and proposed deprecating and eventually removing support for #2 ('glance://' scheme) as part of [5]. Two people in review already raised a concern about removing such support.</div><div><br></div><div>Thus I'd like to ask a broader audience - do we need support for glance image references in 'glance://*<UUID>' form? Is it actually used somewhere? What are the benefits of having it besides simple UUID?</div><div><br></div><div>[0] <a href="http://git.openstack.org/cgit/openstack/ironic/tree/ironic/common/glance_service/service_utils.py#n149">http://git.openstack.org/cgit/openstack/ironic/tree/ironic/common/glance_service/service_utils.py#n149</a></div><div>[1] <a href="http://git.openstack.org/cgit/openstack/ironic/tree/ironic/common/glance_service/service_utils.py#n155">http://git.openstack.org/cgit/openstack/ironic/tree/ironic/common/glance_service/service_utils.py#n155</a></div><div>[2] <a href="http://git.openstack.org/cgit/openstack/ironic/tree/ironic/common/glance_service/service_utils.py#n160">http://git.openstack.org/cgit/openstack/ironic/tree/ironic/common/glance_service/service_utils.py#n160</a></div><div>[3] <a href="http://git.openstack.org/cgit/openstack/ironic/tree/ironic/common/glance_service/service_utils.py#n208">http://git.openstack.org/cgit/openstack/ironic/tree/ironic/common/glance_service/service_utils.py#n208</a></div><div>[4] <a href="http://git.openstack.org/cgit/openstack/ironic/tree/ironic/common/image_service.py#n267">http://git.openstack.org/cgit/openstack/ironic/tree/ironic/common/image_service.py#n267</a></div><div>[5] <a href="https://review.openstack.org/#/c/467728">https://review.openstack.org/#/c/467728</a></div><div><br></div><div>Cheers,</div><div><br></div>-- <br><div class="gmail_signature"><div dir="ltr"><div><div dir="ltr">Dr. Pavlo Shchelokovskyy<div>Senior Software Engineer</div><div>Mirantis Inc</div><div><a href="http://www.mirantis.com" target="_blank">www.mirantis.com</a></div></div></div></div></div>
</div></div>