<div dir="ltr"><div class="gmail_default" style="font-family:monospace,monospace;font-size:small">there are lots of non-plain variables in kolla, dict or list in Ansible. </div><div class="gmail_default" style="font-family:monospace,monospace;font-size:small"><br></div><div class="gmail_default" style="font-family:monospace,monospace;font-size:small">if you do not want to override the dict, you can add following into globals.yml file.</div><div class="gmail_default" style="font-family:monospace,monospace;font-size:small"><br></div><div class="gmail_default" style="font-family:monospace,monospace;font-size:small"><div class="gmail_default">docker_common_options:</div><div class="gmail_default">    auth_email: "{{ docker_registry_email }}"</div><div class="gmail_default">    auth_password: "{{ docker_registry_password }}"</div><div class="gmail_default">    auth_registry: "{{ docker_registry }}"</div><div class="gmail_default">    auth_username: "{{ docker_registry_username }}"</div><div class="gmail_default">    environment:</div><div class="gmail_default">      KOLLA_CONFIG_STRATEGY: "{{ config_strategy }}"</div><div class="gmail_default">      custom_key: custom value</div><div class="gmail_default">    restart_policy: "{{ docker_restart_policy }}"</div><div class="gmail_default">    restart_retries: "{{ docker_restart_policy_retry }}"</div><div><br></div></div></div><div class="gmail_extra"><br><div class="gmail_quote">On Tue, Jul 11, 2017 at 4:55 PM, Paul Bourke <span dir="ltr"><<a href="mailto:paul.bourke@oracle.com" target="_blank">paul.bourke@oracle.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">Because its a series of key value pairs: <a href="https://github.com/openstack/kolla-ansible/blob/master/ansible/group_vars/all.yml#L96-L105" rel="noreferrer" target="_blank">https://github.com/openstack/k<wbr>olla-ansible/blob/master/ansib<wbr>le/group_vars/all.yml#L96-L105</a><br>
<br>
Is there another type you feel would fit better?<div class="HOEnZb"><div class="h5"><br>
<br>
On 11/07/17 05:22, Margin Hu wrote:<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
Hi Guys:<br>
<br>
I want to set docker_common_options parameter but find its type is dictionary.  why?<br>
<br>
ansible/roles/zun/tasks/pull.y<wbr>ml:5:    common_options: "{{ docker_common_options }}"<br>
tests/test_kolla_docker.py:44: common_options=dict(required=F<wbr>alse, type='dict', default=dict()),<br>
<br>
<br>
<br>
<br>
______________________________<wbr>______________________________<wbr>______________<br>
OpenStack Development Mailing List (not for usage questions)<br>
Unsubscribe: <a href="http://OpenStack-dev-request@lists.openstack.org?subject:unsubscribe" rel="noreferrer" target="_blank">OpenStack-dev-request@lists.op<wbr>enstack.org?subject:unsubscrib<wbr>e</a><br>
<a href="http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev" rel="noreferrer" target="_blank">http://lists.openstack.org/cgi<wbr>-bin/mailman/listinfo/openstac<wbr>k-dev</a><br>
</blockquote>
<br>
______________________________<wbr>______________________________<wbr>______________<br>
OpenStack Development Mailing List (not for usage questions)<br>
Unsubscribe: <a href="http://OpenStack-dev-request@lists.openstack.org?subject:unsubscribe" rel="noreferrer" target="_blank">OpenStack-dev-request@lists.op<wbr>enstack.org?subject:unsubscrib<wbr>e</a><br>
<a href="http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev" rel="noreferrer" target="_blank">http://lists.openstack.org/cgi<wbr>-bin/mailman/listinfo/openstac<wbr>k-dev</a><br>
</div></div></blockquote></div><br><br clear="all"><div><br></div>-- <br><div class="gmail_signature" data-smartmail="gmail_signature"><div dir="ltr"><div><div dir="ltr"><div><div dir="ltr"><div dir="ltr"><div dir="ltr"><div><span style="font-size:13px;border-collapse:collapse"><font face="monospace, monospace">Regards,</font></span></div><div><span style="font-size:13px;border-collapse:collapse"><font face="monospace, monospace">Jeffrey Zhang</font></span></div><div><span style="font-family:monospace,monospace;font-size:12.8px">Blog: </span><a href="http://xcodest.me/" style="font-family:monospace,monospace;font-size:12.8px" target="_blank">http://xcodest.me</a><font face="monospace, monospace"><br></font></div></div></div></div></div></div></div></div></div>
</div>