<div dir="ltr"><br><div class="gmail_extra"><br><div class="gmail_quote">On Mon, May 29, 2017 at 4:08 AM, Matthieu Simonin <span dir="ltr"><<a href="mailto:matthieu.simonin@inria.fr" target="_blank">matthieu.simonin@inria.fr</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">Hello,<br>
<br>
I'd like to have more insight on OSProfiler support in paste-deploy files as it seems not similar across projects.<br>
As a result, the way you can enable it on Kolla side differs. Here are some examples:<br>
<br>
a) Nova paste.ini already contains OSProfiler middleware[1].<br>
<br>
b) Keystone paste.ini doesn't contain OSProfiler but the file is exposed in Kolla-ansible.<br>
Thus it can be overwritten[2] by providing an alternate paste file using a node_custom_config directory.<br></blockquote><div><br></div><div>I'm looking through keystone's sample paste file we keep in the project and we do have osprofiler in our v2 and v3 pipelines [0] [1]. It looks like it has been in keystone's sample paste file since Mitaka [2]</div><div><br></div><div><br></div><div>[0] <a href="https://github.com/openstack/keystone/blob/58d7eaca41f83a52e100cbae9afe7d3faf1b9693/etc/keystone-paste.ini#L43-L44">https://github.com/openstack/keystone/blob/58d7eaca41f83a52e100cbae9afe7d3faf1b9693/etc/keystone-paste.ini#L43-L44</a></div><div>[1] <a href="https://github.com/openstack/keystone/blob/58d7eaca41f83a52e100cbae9afe7d3faf1b9693/etc/keystone-paste.ini#L68">https://github.com/openstack/keystone/blob/58d7eaca41f83a52e100cbae9afe7d3faf1b9693/etc/keystone-paste.ini#L68</a></div><div>[2] <a href="https://github.com/openstack/keystone/commit/639e36adbfa0f58ce2c3f31856b4343e9197aa0e">https://github.com/openstack/keystone/commit/639e36adbfa0f58ce2c3f31856b4343e9197aa0e</a></div><div> </div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">
<br>
c) Neutron paste.ini doesn't contain OSProfiler middleware[3]. For devstack, a hook can reconfigure the file at deploy time[4].<br>
For Kolla, it seems that the only solution right now is to rebuild the whole docker image.<br>
<br>
As a user of Kolla and OSprofiler a) is the most convenient thing.<br>
<br>
Regarding b) and c), is it a deliberate choice to ship the paste deploy files without OSProfiler middleware?<br>
<br>
Do you think we could converge ? ideally having a) for every API services ?<br>
<br>
Best,<br>
<br>
Matt<br>
<br>
[1]: <a href="https://github.com/openstack/nova/blob/0d31fb303e07b7ed9f55b9c823b43e6db5153ee6/etc/nova/api-paste.ini#L29-L37" rel="noreferrer" target="_blank">https://github.com/openstack/<wbr>nova/blob/<wbr>0d31fb303e07b7ed9f55b9c823b43e<wbr>6db5153ee6/etc/nova/api-paste.<wbr>ini#L29-L37</a><br>
[2]: <a href="https://github.com/openstack/kolla-ansible/blob/fe61612ec6db469cccf2d2b4f0bd404ad4ced112/ansible/roles/keystone/tasks/config.yml#L119" rel="noreferrer" target="_blank">https://github.com/openstack/<wbr>kolla-ansible/blob/<wbr>fe61612ec6db469cccf2d2b4f0bd40<wbr>4ad4ced112/ansible/roles/<wbr>keystone/tasks/config.yml#L119</a><br>
[3]: <a href="https://github.com/openstack/neutron/blob/e4557a7793fbf3461bfae36ead41ee4d349920ab/neutron/tests/contrib/hooks/osprofiler" rel="noreferrer" target="_blank">https://github.com/openstack/<wbr>neutron/blob/<wbr>e4557a7793fbf3461bfae36ead41ee<wbr>4d349920ab/neutron/tests/<wbr>contrib/hooks/osprofiler</a><br>
[4]: <a href="https://github.com/openstack/neutron/blob/e4557a7793fbf3461bfae36ead41ee4d349920ab/etc/api-paste.ini#L6-L9" rel="noreferrer" target="_blank">https://github.com/openstack/<wbr>neutron/blob/<wbr>e4557a7793fbf3461bfae36ead41ee<wbr>4d349920ab/etc/api-paste.ini#<wbr>L6-L9</a><br>
<br>
______________________________<wbr>______________________________<wbr>______________<br>
OpenStack Development Mailing List (not for usage questions)<br>
Unsubscribe: <a href="http://OpenStack-dev-request@lists.openstack.org?subject:unsubscribe" rel="noreferrer" target="_blank">OpenStack-dev-request@lists.<wbr>openstack.org?subject:<wbr>unsubscribe</a><br>
<a href="http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev" rel="noreferrer" target="_blank">http://lists.openstack.org/<wbr>cgi-bin/mailman/listinfo/<wbr>openstack-dev</a><br>
</blockquote></div><br></div></div>