<div dir="ltr"><font style="font-family:Calibri,Arial,Helvetica,sans-serif,serif,EmojiFont" color="black" size="3"><span style="font-size:12pt" dir="ltr" id="gmail-divtagdefaultwrapper"><div style="margin-top:0px;margin-bottom:0px">Hi Doug and Renat,</div>
<div style="margin-top:0px;margin-bottom:0px"><br>
</div>
<div style="margin-top:0px;margin-bottom:0px">I totally agree with what
Doug mentioned in the previous mail. In fact, my patch is only the used
for the purpose of "implementing trust token", not for full refactoring
mistral context. Since i do not have my capacity
for contributing to Mistral, my commit now is for the need of Nokia in
using token when it is expired.<br>
<br>
>From very beginning, i would like to refactor mistral context to fully use oslo-context. But if i wanted to refactor the whole mistral context, i would
spend my whole capacity for upstream work which is not available for me.
By the way, thanks Doug to review it, i
know all the issues in your comments but as i said, it was hard for me
for upstream work. But i will re-arrange my schedule to finish as Doug
commented in the patch as well as switching to oslo-context<br>
<br>
@Renat: I will try to refactor the whole mistral context therefore there will not be any roadblocks.<br>
<br>
Br,</div>
<div style="margin-top:0px;margin-bottom:0px"><br>
</div>
<div style="margin-top:0px;margin-bottom:0px">Tuan</div></span></font></div><div class="gmail_extra"><br><div class="gmail_quote">On Sat, May 27, 2017 at 2:08 AM, Vitaliy Nogin <span dir="ltr"><<a href="mailto:vnogin@mirantis.com" target="_blank">vnogin@mirantis.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">Hi Doug,<br>
<br>
Anyway, thank for the notification. We are really appreciated.<br>
<br>
Regards,<br>
Vitaliy<br>
<br>
> 26 мая 2017 г., в 20:54, Doug Hellmann <<a href="mailto:doug@doughellmann.com">doug@doughellmann.com</a>> написал(а):<br>
<div class="HOEnZb"><div class="h5">><br>
> Excerpts from Saad Zaher's message of 2017-05-26 12:03:24 +0100:<br>
>> Hi Doug,<br>
>><br>
>> Thanks for your review. Actually freezer has a separate repo for the api,<br>
>> it can be found here [1]. Freezer is using oslo.context since newton. If<br>
>> you have the time you can take a look at it and let us know if you have any<br>
>> comments.<br>
><br>
> Ah, that explains why I couldn't find it in the freezer repo. :-)<br>
><br>
> Doug<br>
><br>
>><br>
>> Thanks for your help<br>
>><br>
>> [1] <a href="https://github.com/openstack/freezer-api" rel="noreferrer" target="_blank">https://github.com/openstack/<wbr>freezer-api</a><br>
>><br>
>> Best Regards,<br>
>> Saad!<br>
>><br>
>> On Fri, May 26, 2017 at 5:45 AM, Renat Akhmerov <<a href="mailto:renat.akhmerov@gmail.com">renat.akhmerov@gmail.com</a>><br>
>> wrote:<br>
>><br>
>>> Thanks Doug. We’ll look into this.<br>
>>><br>
>>> @Tuan, is there any roadblocks with the patch you’re working on? [1]<br>
>>><br>
>>> [1] <a href="https://review.openstack.org/#/c/455407/" rel="noreferrer" target="_blank">https://review.openstack.org/#<wbr>/c/455407/</a><br>
>>><br>
>>><br>
>>> Renat<br>
>>><br>
>>> On 26 May 2017, 01:54 +0700, Doug Hellmann <<a href="mailto:doug@doughellmann.com">doug@doughellmann.com</a>>, wrote:<br>
>>><br>
>>> The new work to add the exception information and request ID tracing<br>
>>> depends on using both oslo.context and oslo.log to have all of the<br>
>>> relevant pieces of information available as log messages are emitted.<br>
>>><br>
>>> In the course of reviewing the "done" status for those initiatives,<br>
>>> I noticed that although mistral and freezer are using oslo.log,<br>
>>> neither uses oslo.context. That means neither project will get the<br>
>>> extra debugging information, and neither project will see the global<br>
>>> request ID in logs.<br>
>>><br>
>>> I started looking at updating mistral's context to use oslo.context<br>
>>> as a base class, but ran into some issues because of some extensions<br>
>>> made to the existing class. I wasn't able to find where freezer is<br>
>>> doing anything at all with an API request context.<br>
>>><br>
>>> I'm available to help, if someone else wants to pick up the work.<br>
>>><br>
>>> Doug<br>
>>><br>
>>> ______________________________<wbr>______________________________<wbr>______________<br>
>>> OpenStack Development Mailing List (not for usage questions)<br>
>>> Unsubscribe: <a href="http://OpenStack-dev-request@lists.openstack.org?subject:unsubscribe" rel="noreferrer" target="_blank">OpenStack-dev-request@lists.<wbr>openstack.org?subject:<wbr>unsubscribe</a><br>
>>> <a href="http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev" rel="noreferrer" target="_blank">http://lists.openstack.org/<wbr>cgi-bin/mailman/listinfo/<wbr>openstack-dev</a><br>
>>><br>
>>><br>
>>> ______________________________<wbr>______________________________<wbr>______________<br>
>>> OpenStack Development Mailing List (not for usage questions)<br>
>>> Unsubscribe: <a href="http://OpenStack-dev-request@lists.openstack.org?subject:unsubscribe" rel="noreferrer" target="_blank">OpenStack-dev-request@lists.<wbr>openstack.org?subject:<wbr>unsubscribe</a><br>
>>> <a href="http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev" rel="noreferrer" target="_blank">http://lists.openstack.org/<wbr>cgi-bin/mailman/listinfo/<wbr>openstack-dev</a><br>
>>><br>
>>><br>
>><br>
><br>
> ______________________________<wbr>______________________________<wbr>______________<br>
> OpenStack Development Mailing List (not for usage questions)<br>
> Unsubscribe: <a href="http://OpenStack-dev-request@lists.openstack.org?subject:unsubscribe" rel="noreferrer" target="_blank">OpenStack-dev-request@lists.<wbr>openstack.org?subject:<wbr>unsubscribe</a><br>
> <a href="http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev" rel="noreferrer" target="_blank">http://lists.openstack.org/<wbr>cgi-bin/mailman/listinfo/<wbr>openstack-dev</a><br>
<br>
<br>
______________________________<wbr>______________________________<wbr>______________<br>
OpenStack Development Mailing List (not for usage questions)<br>
Unsubscribe: <a href="http://OpenStack-dev-request@lists.openstack.org?subject:unsubscribe" rel="noreferrer" target="_blank">OpenStack-dev-request@lists.<wbr>openstack.org?subject:<wbr>unsubscribe</a><br>
<a href="http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev" rel="noreferrer" target="_blank">http://lists.openstack.org/<wbr>cgi-bin/mailman/listinfo/<wbr>openstack-dev</a><br>
</div></div></blockquote></div><br></div>