<html xmlns:v="urn:schemas-microsoft-com:vml" xmlns:o="urn:schemas-microsoft-com:office:office" xmlns:w="urn:schemas-microsoft-com:office:word" xmlns:m="http://schemas.microsoft.com/office/2004/12/omml" xmlns="http://www.w3.org/TR/REC-html40"><head><meta http-equiv=Content-Type content="text/html; charset=utf-8"><meta name=Generator content="Microsoft Word 15 (filtered medium)"><style><!--
/* Font Definitions */
@font-face
{font-family:"Cambria Math";
panose-1:2 4 5 3 5 4 6 3 2 4;}
@font-face
{font-family:Calibri;
panose-1:2 15 5 2 2 2 4 3 2 4;}
/* Style Definitions */
p.MsoNormal, li.MsoNormal, div.MsoNormal
{margin:0in;
margin-bottom:.0001pt;
font-size:12.0pt;
font-family:"Times New Roman",serif;}
a:link, span.MsoHyperlink
{mso-style-priority:99;
color:blue;
text-decoration:underline;}
a:visited, span.MsoHyperlinkFollowed
{mso-style-priority:99;
color:purple;
text-decoration:underline;}
p.msonormal0, li.msonormal0, div.msonormal0
{mso-style-name:msonormal;
mso-margin-top-alt:auto;
margin-right:0in;
mso-margin-bottom-alt:auto;
margin-left:0in;
font-size:12.0pt;
font-family:"Times New Roman",serif;}
span.gmail-m-7637432970889093051gmail-il
{mso-style-name:gmail-m_-7637432970889093051gmail-il;}
span.gmail-hoenzb
{mso-style-name:gmail-hoenzb;}
span.EmailStyle20
{mso-style-type:personal-reply;
font-family:"Calibri",sans-serif;
color:windowtext;}
.MsoChpDefault
{mso-style-type:export-only;
font-family:"Calibri",sans-serif;}
@page WordSection1
{size:8.5in 11.0in;
margin:1.0in 1.0in 1.0in 1.0in;}
div.WordSection1
{page:WordSection1;}
--></style><!--[if gte mso 9]><xml>
<o:shapedefaults v:ext="edit" spidmax="1026" />
</xml><![endif]--><!--[if gte mso 9]><xml>
<o:shapelayout v:ext="edit">
<o:idmap v:ext="edit" data="1" />
</o:shapelayout></xml><![endif]--></head><body lang=EN-US link=blue vlink=purple><div class=WordSection1><p class=MsoNormal><span style='font-size:11.0pt;font-family:"Calibri",sans-serif'>Thank you ChangBo, I have resolved the issues in octavia in this patch: <a href="https://review.openstack.org/457356">https://review.openstack.org/457356</a> up for review.<o:p></o:p></span></p><p class=MsoNormal><span style='font-size:11.0pt;font-family:"Calibri",sans-serif'><o:p> </o:p></span></p><p class=MsoNormal><span style='font-size:11.0pt;font-family:"Calibri",sans-serif'>Michael<o:p></o:p></span></p><p class=MsoNormal><span style='font-size:11.0pt;font-family:"Calibri",sans-serif'><o:p> </o:p></span></p><p class=MsoNormal><b><span style='font-size:11.0pt;font-family:"Calibri",sans-serif'>From:</span></b><span style='font-size:11.0pt;font-family:"Calibri",sans-serif'> ChangBo Guo [mailto:glongwave@gmail.com] <br><b>Sent:</b> Sunday, April 16, 2017 12:32 AM<br><b>To:</b> OpenStack Development Mailing List (not for usage questions) <openstack-dev@lists.openstack.org><br><b>Subject:</b> Re: [openstack-dev] [glance][ironic][octavia] oslo.config 4.0 will break projects' unit test<o:p></o:p></span></p><p class=MsoNormal><o:p> </o:p></p><div><div><div><div><p class=MsoNormal>As I expect, there are some failures in periodic tasks recently [1] if we set enforce_type with True by default, we'd better fix them before we release oslo.config 4.0. Some guys had been working on this :<br>Nova: <a href="https://review.openstack.org/455534">https://review.openstack.org/455534</a> should fix failures<o:p></o:p></p></div><div><p class=MsoNormal>tempest: <a href="https://review.openstack.org/456445">https://review.openstack.org/456445</a> fixed<o:p></o:p></p></div><div><p class=MsoNormal>Keystone: <a href="https://review.openstack.org/455391">https://review.openstack.org/455391</a> wait for oslo.config 4.0<o:p></o:p></p></div><div><p class=MsoNormal><o:p> </o:p></p></div><div><p class=MsoNormal>We still need help from Glance/Ironic/Octavia<o:p></o:p></p></div><p class=MsoNormal>Glance: <a href="https://review.openstack.org/#/c/455522/">https://review.openstack.org/#/c/455522/</a> need review<o:p></o:p></p></div><p class=MsoNormal>Ironic: Need fix failure in <a href="http://logs.openstack.org/periodic/periodic-ironic-py27-with-oslo-master/680abfe/testr_results.html.gz">http://logs.openstack.org/periodic/periodic-ironic-py27-with-oslo-master/680abfe/testr_results.html.gz</a><br>Octavia: Need fix failure in <a href="http://logs.openstack.org/periodic/periodic-octavia-py35-with-oslo-master/80fee03/testr_results.html.gz">http://logs.openstack.org/periodic/periodic-octavia-py35-with-oslo-master/80fee03/testr_results.html.gz</a><o:p></o:p></p></div><div><div><div><div><p class=MsoNormal><br>[1] <a href="http://status.openstack.org/openstack-health/#/?groupKey=build_name&resolutionKey=hour&searchProject=-with-oslo">http://status.openstack.org/openstack-health/#/?groupKey=build_name&resolutionKey=hour&searchProject=-with-oslo</a><o:p></o:p></p><div><p class=MsoNormal><o:p> </o:p></p><div><p class=MsoNormal>2017-04-04 0:01 GMT+08:00 ChangBo Guo <<a href="mailto:glongwave@gmail.com" target="_blank">glongwave@gmail.com</a>>:<o:p></o:p></p><blockquote style='border:none;border-left:solid #CCCCCC 1.0pt;padding:0in 0in 0in 6.0pt;margin-left:4.8pt;margin-right:0in'><div><p class=MsoNormal>Hi ALL,<o:p></o:p></p><div><p class=MsoNormal><br>oslo_config provides method CONF.set_override[1] , developers usually use it to change <span class=gmail-m-7637432970889093051gmail-il>config</span> option's value in tests. That's convenient . By default parameter enforce_type=False, it doesn't check any type or value of override. If set enforce_type=True , will check parameter override's type and value. In production code(running time code), oslo_config always checks <span class=gmail-m-7637432970889093051gmail-il>config</span> option's value. In short, we test and run code in different ways. so there's gap: <span class=gmail-m-7637432970889093051gmail-il>config</span> option with wrong type or invalid value can pass tests when<o:p></o:p></p><div><div><div id="gmail-m_-7637432970889093051gmail-m_8148224464712465731magicdomid6"><p class=MsoNormal>parameter enforce_type = False in consuming projects. that means some invalid or wrong tests are in our code base. <br><br><br>We began to warn user about the change since Sep, 2016 in [2]. This change will notify consuming project to write correct test cases with config options. <o:p></o:p></p></div><div id="gmail-m_-7637432970889093051gmail-m_8148224464712465731magicdomid6"><p class=MsoNormal>We would make enforce_type = true by default in [3], that may break some projects' tests, that's also raise wrong unit tests. The failure is easy to fix, which<o:p></o:p></p></div><div id="gmail-m_-7637432970889093051gmail-m_8148224464712465731magicdomid6"><p class=MsoNormal>is recommended. <o:p></o:p></p></div></div></div><p class=MsoNormal><br><br>[1] <a href="https://github.com/openstack/oslo.config/blob/efb287a94645b15b634e8c344352696ff85c219f/oslo_config/cfg.py#L2613" target="_blank">https://github.com/openstack/oslo.config/blob/efb287a94645b15b634e8c344352696ff85c219f/oslo_config/cfg.py#L2613</a><br>[2] <a href="https://review.openstack.org/#/c/365476/" target="_blank">https://review.openstack.org/#/c/365476/</a><br>[3] <a href="https://review.openstack.org/328692" target="_blank">https://review.openstack.org/328692</a><span style='color:#888888'><br clear=all><span class=gmail-hoenzb><o:p></o:p></span></span></p><div><p class=MsoNormal><span style='color:#888888'><br>-- </span><o:p></o:p></p><div><div><div><p class=MsoNormal><span style='color:#888888'>ChangBo Guo(gcb)<o:p></o:p></span></p></div></div></div></div></div></div></blockquote></div><p class=MsoNormal><br><br clear=all><br>-- <o:p></o:p></p><div><div><div><p class=MsoNormal>ChangBo Guo(gcb)<o:p></o:p></p></div></div></div></div></div></div></div></div></div></div></body></html>