<html xmlns:v="urn:schemas-microsoft-com:vml" xmlns:o="urn:schemas-microsoft-com:office:office" xmlns:w="urn:schemas-microsoft-com:office:word" xmlns:m="http://schemas.microsoft.com/office/2004/12/omml" xmlns="http://www.w3.org/TR/REC-html40">
<head>
<meta http-equiv="Content-Type" content="text/html; charset=utf-8">
<meta name="Generator" content="Microsoft Word 15 (filtered medium)">
<style><!--
/* Font Definitions */
@font-face
{font-family:"Cambria Math";
panose-1:2 4 5 3 5 4 6 3 2 4;}
@font-face
{font-family:Calibri;
panose-1:2 15 5 2 2 2 4 3 2 4;}
/* Style Definitions */
p.MsoNormal, li.MsoNormal, div.MsoNormal
{margin:0in;
margin-bottom:.0001pt;
font-size:12.0pt;
font-family:"Times New Roman",serif;}
a:link, span.MsoHyperlink
{mso-style-priority:99;
color:blue;
text-decoration:underline;}
a:visited, span.MsoHyperlinkFollowed
{mso-style-priority:99;
color:purple;
text-decoration:underline;}
p.msonormal0, li.msonormal0, div.msonormal0
{mso-style-name:msonormal;
mso-margin-top-alt:auto;
margin-right:0in;
mso-margin-bottom-alt:auto;
margin-left:0in;
font-size:12.0pt;
font-family:"Times New Roman",serif;}
span.EmailStyle18
{mso-style-type:personal-reply;
font-family:"Calibri",sans-serif;
color:#1F497D;}
.MsoChpDefault
{mso-style-type:export-only;
font-family:"Calibri",sans-serif;}
@page WordSection1
{size:8.5in 11.0in;
margin:1.0in 1.0in 1.0in 1.0in;}
div.WordSection1
{page:WordSection1;}
--></style><!--[if gte mso 9]><xml>
<o:shapedefaults v:ext="edit" spidmax="1026" />
</xml><![endif]--><!--[if gte mso 9]><xml>
<o:shapelayout v:ext="edit">
<o:idmap v:ext="edit" data="1" />
</o:shapelayout></xml><![endif]-->
</head>
<body lang="EN-US" link="blue" vlink="purple">
<div class="WordSection1">
<p class="MsoNormal"><span style="font-size:11.0pt;font-family:"Calibri",sans-serif;color:#1F497D">The idea is great, no doubt here, meaning mentoring and everything, but it should not come with price of reducing quality control. 2 x +2 +w should still be required
from “regular” cores for PS to merge.<o:p></o:p></span></p>
<p class="MsoNormal"><span style="font-size:11.0pt;font-family:"Calibri",sans-serif;color:#1F497D"><o:p> </o:p></span></p>
<p class="MsoNormal"><span style="font-size:11.0pt;font-family:"Calibri",sans-serif;color:#1F497D">Serguei<o:p></o:p></span></p>
<p class="MsoNormal"><span style="font-size:11.0pt;font-family:"Calibri",sans-serif;color:#1F497D"><o:p> </o:p></span></p>
<p class="MsoNormal"><b><span style="font-size:11.0pt;font-family:"Calibri",sans-serif">From:</span></b><span style="font-size:11.0pt;font-family:"Calibri",sans-serif"> Richard Wellum [mailto:richwellum@gmail.com]
<br>
<b>Sent:</b> Thursday, April 13, 2017 7:02 AM<br>
<b>To:</b> OpenStack Development Mailing List (not for usage questions) <openstack-dev@lists.openstack.org><br>
<b>Subject:</b> Re: [openstack-dev] [kolla][nova] Starting a core reviewer mentorship program for Kolla deliverables<o:p></o:p></span></p>
<p class="MsoNormal"><o:p> </o:p></p>
<div>
<p class="MsoNormal">As a relatively new member of the openstack community I think the idea of a mentorship program is a good one; I'd like to throw my hat in the ring if the kolla community needs a guinea-pig to try this on. :)<o:p></o:p></p>
<div>
<p class="MsoNormal"><o:p> </o:p></p>
</div>
<div>
<p class="MsoNormal">Rich<o:p></o:p></p>
</div>
</div>
<p class="MsoNormal"><o:p> </o:p></p>
<div>
<div>
<p class="MsoNormal">On Wed, Apr 12, 2017 at 7:53 PM Matt Riedemann <<a href="mailto:mriedemos@gmail.com">mriedemos@gmail.com</a>> wrote:<o:p></o:p></p>
</div>
<blockquote style="border:none;border-left:solid #CCCCCC 1.0pt;padding:0in 0in 0in 6.0pt;margin-left:4.8pt;margin-right:0in">
<p class="MsoNormal">On 4/12/2017 3:40 PM, Steven Dake (stdake) wrote:<br>
> Matt,<br>
><br>
> Thanks for the response. It is helpful.<br>
><br>
> Regards<br>
> -steve<br>
><br>
> -----Original Message-----<br>
> From: Matt Riedemann <<a href="mailto:mriedemos@gmail.com" target="_blank">mriedemos@gmail.com</a>><br>
> Reply-To: "OpenStack Development Mailing List (not for usage questions)" <<a href="mailto:openstack-dev@lists.openstack.org" target="_blank">openstack-dev@lists.openstack.org</a>><br>
> Date: Wednesday, April 12, 2017 at 4:36 PM<br>
> To: "<a href="mailto:openstack-dev@lists.openstack.org" target="_blank">openstack-dev@lists.openstack.org</a>" <<a href="mailto:openstack-dev@lists.openstack.org" target="_blank">openstack-dev@lists.openstack.org</a>><br>
> Subject: Re: [openstack-dev] [kolla][nova] Starting a core reviewer mentorship program for Kolla deliverables<br>
><br>
> On 4/12/2017 11:59 AM, Steven Dake (stdake) wrote:<br>
> > Hey folks,<br>
> ><br>
> ><br>
> ><br>
> > In today’s Kolla team meeting, the idea was proposed of adopting nova’s<br>
> > “protocore” mentorship program for Kolla. We would like to know what<br>
> > nova has learned from this effort.<br>
> ><br>
> ><br>
> ><br>
> > In today’s Kolla meeting we had broad consensus on the following:<br>
> ><br>
> > 1) Kolla has participants that want to be core reviewers<br>
> ><br>
> > 2) These participants don’t know how to become core reviewers<br>
> ><br>
> > 3) The core reviewers in Kolla should mentor “protocore” reviewers<br>
> > on how to do good reviews<br>
> ><br>
> ><br>
> ><br>
> > From that, we concluded some form of mentorship program for potential<br>
> > core reviewers was in order. We got into some debate about _/how/_ the<br>
> > program should be rolled out. Let’s use this thread to discuss how it<br>
> > should be rolled out since that seems to be the sticking point of the<br>
> > discussion. I saw no dissent in the discussion that the basic concepts<br>
> > were a negative change.<br>
> ><br>
> ><br>
> ><br>
> > I am aware that nova uses a +1 review from a “protocore” and a +2/+w<br>
> > from a core reviewer prior to merge. Nova cores – would you mind<br>
> > defining your process (on the ml is fine) more thoroughly and your<br>
> > experiences so we can learn from you?<br>
> ><br>
> ><br>
> ><br>
> > All kolla contributors, feel free to debate the **how** such a<br>
> > mentorship program should be rolled out. I think we have a lot to learn<br>
> > from our peers in the OpenStack community and learning from their<br>
> > experiences may be helpful.<br>
> ><br>
> ><br>
> ><br>
> > Regards<br>
> ><br>
> > -steve<br>
> ><br>
> ><br>
> ><br>
> ><br>
> ><br>
> > __________________________________________________________________________<br>
> > OpenStack Development Mailing List (not for usage questions)<br>
> > Unsubscribe: <a href="http://OpenStack-dev-request@lists.openstack.org?subject:unsubscribe" target="_blank">
OpenStack-dev-request@lists.openstack.org?subject:unsubscribe</a><br>
> > <a href="http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev" target="_blank">
http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev</a><br>
> ><br>
><br>
> Nova has this thing? That's news to me. :)<br>
><br>
> I don't think Nova has a formal process for something like this. There<br>
> was talk at the BCN summit about giving some people +2 rights on parts<br>
> of the tree but not full core on everything. We never implemented that.<br>
><br>
> Maybe what you're referring to is how we consider a +1 from a domain<br>
> expert like a +2, or at least something that's good to have before cores<br>
> are looking into the change in more detail? For example, gibi is the<br>
> lead for the versioned notifications effort and we/I generally look for<br>
> his +1 on a change before digging into it, or approving it. We have<br>
> similar unofficial things like this in other parts of Nova, or subteams,<br>
> like Timofey and Pawel with the live migration subteam.<br>
><br>
> To be sure, someone that is leading a subteam effort and is looked to<br>
> for their opinion on a whole series of changes eventually gets into the<br>
> conversation when we're talking about potential core reviewers, in part<br>
> because, at least I personally, am looking for not only strong code<br>
> review skills but also leadership/ownership within the project, because<br>
> those are also the people that tend to stick around awhile so I'm more<br>
> comfortable investing my time into them (and building a trust<br>
> relationship with them).<br>
><br>
> So that's all unofficial non-formal stuff and basically grew up<br>
> organically around the subteam efforts that started several releases<br>
> ago. I don't know if this helps you or not.<br>
><br>
> --<br>
><br>
> Thanks,<br>
><br>
> Matt<br>
><br>
> __________________________________________________________________________<br>
> OpenStack Development Mailing List (not for usage questions)<br>
> Unsubscribe: <a href="http://OpenStack-dev-request@lists.openstack.org?subject:unsubscribe" target="_blank">
OpenStack-dev-request@lists.openstack.org?subject:unsubscribe</a><br>
> <a href="http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev" target="_blank">http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev</a><br>
><br>
><br>
> __________________________________________________________________________<br>
> OpenStack Development Mailing List (not for usage questions)<br>
> Unsubscribe: <a href="http://OpenStack-dev-request@lists.openstack.org?subject:unsubscribe" target="_blank">
OpenStack-dev-request@lists.openstack.org?subject:unsubscribe</a><br>
> <a href="http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev" target="_blank">
http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev</a><br>
><br>
<br>
By the way, I should add, while we look for a +1 from a subteam or<br>
domain expert, it does not equate to a +2 so that a core can come along<br>
and +2/+W. We still require 2 +2s.<br>
<br>
--<br>
<br>
Thanks,<br>
<br>
Matt<br>
<br>
__________________________________________________________________________<br>
OpenStack Development Mailing List (not for usage questions)<br>
Unsubscribe: <a href="http://OpenStack-dev-request@lists.openstack.org?subject:unsubscribe" target="_blank">
OpenStack-dev-request@lists.openstack.org?subject:unsubscribe</a><br>
<a href="http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev" target="_blank">http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev</a><o:p></o:p></p>
</blockquote>
</div>
</div>
</body>
</html>