<div dir="ltr"><br><div class="gmail_extra"><br><div class="gmail_quote">On Tue, Apr 11, 2017 at 1:21 PM, Matt Riedemann <span dir="ltr"><<a href="mailto:mriedemos@gmail.com" target="_blank">mriedemos@gmail.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"><span class="gmail-">On 4/11/2017 2:52 AM, Alex Xu wrote:<br>
<blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">
We talked about remove the quota-class API for multiple times<br>
(<a href="http://lists.openstack.org/pipermail/openstack-dev/2016-July/099218.html" rel="noreferrer" target="_blank">http://lists.openstack.org/pi<wbr>permail/openstack-dev/2016-Jul<wbr>y/099218.html</a>)<br>
<br>
I guess we can deprecate the entire quota-class API directly.<br>
<br>
</blockquote>
<br></span>
I had a spec proposed to deprecate the os-quota-class-sets API [1] but it was abandoned since we discussed it at the Pike PTG and decided we would just leave it alone until Nova was getting limits information from Keystone [2].<br></blockquote><div><br></div><div>FWIW - in addition to merging the conceptual document [0], Sean recently proposed the limits interface [1] for the keystone bits.</div><div><br></div><div>[0] <a href="http://specs.openstack.org/openstack/keystone-specs/specs/keystone/ongoing/unified-limits.htm">http://specs.openstack.org/openstack/keystone-specs/specs/keystone/ongoing/unified-limits.htm</a></div><div>[1] <a href="https://review.openstack.org/#/c/455709/">https://review.openstack.org/#/c/455709/</a></div><div> </div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">
<br>
I think the reason we probably missed this API was because of the really roundabout way that the information is provided in the response. It calls the quota engine driver [3] to get the class quotas. For the DB driver if nothing is overridden then nothing comes back here [4]. And the resources in the quota driver have a default property which is based on the config options [5]. So we'll return quotas on floating_ips and other proxy resources simply because of how abstract this all is.<br>
<br>
To fix it, the os-quota-class-sets API would have to maintain a blacklist of resources to exclude from the response, like what we do for limits [6].<br>
<br>
So yeah, I guess we'd need a new spec and microversion for this.<br>
<br>
[1] <a href="https://review.openstack.org/#/c/411035/" rel="noreferrer" target="_blank">https://review.openstack.org/#<wbr>/c/411035/</a><br>
[2] <a href="https://review.openstack.org/#/c/440815/" rel="noreferrer" target="_blank">https://review.openstack.org/#<wbr>/c/440815/</a><br>
[3] <a href="https://github.com/openstack/nova/blob/15.0.0/nova/api/openstack/compute/quota_classes.py#L67" rel="noreferrer" target="_blank">https://github.com/openstack/n<wbr>ova/blob/15.0.0/nova/api/opens<wbr>tack/compute/quota_classes.py#<wbr>L67</a><br>
[4] <a href="https://github.com/openstack/nova/blob/15.0.0/nova/quota.py#L92" rel="noreferrer" target="_blank">https://github.com/openstack/n<wbr>ova/blob/15.0.0/nova/quota.py#<wbr>L92</a><br>
[5] <a href="https://github.com/openstack/nova/blob/15.0.0/nova/quota.py#L1069" rel="noreferrer" target="_blank">https://github.com/openstack/n<wbr>ova/blob/15.0.0/nova/quota.py#<wbr>L1069</a><br>
[6] <a href="https://github.com/openstack/nova/blob/15.0.0/nova/api/openstack/compute/views/limits.py#L20" rel="noreferrer" target="_blank">https://github.com/openstack/n<wbr>ova/blob/15.0.0/nova/api/opens<wbr>tack/compute/views/limits.py#<wbr>L20</a><span class="gmail-HOEnZb"><font color="#888888"><br>
<br>
-- <br>
<br>
Thanks,<br>
<br>
Matt</font></span><div class="gmail-HOEnZb"><div class="gmail-h5"><br>
<br>
______________________________<wbr>______________________________<wbr>______________<br>
OpenStack Development Mailing List (not for usage questions)<br>
Unsubscribe: <a href="http://OpenStack-dev-request@lists.openstack.org?subject:unsubscribe" rel="noreferrer" target="_blank">OpenStack-dev-request@lists.op<wbr>enstack.org?subject:unsubscrib<wbr>e</a><br>
<a href="http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev" rel="noreferrer" target="_blank">http://lists.openstack.org/cgi<wbr>-bin/mailman/listinfo/openstac<wbr>k-dev</a><br>
</div></div></blockquote></div><br></div></div>