<html>
<head>
<meta http-equiv="Content-Type" content="text/html; charset=us-ascii">
</head>
<body style="word-wrap: break-word; -webkit-nbsp-mode: space; -webkit-line-break: after-white-space;" class="">
I voted to merge [1] and [2]:
<div class=""><br class="">
</div>
<div class="">
<div class="">[1] <a href="https://review.openstack.org/#/c/429753/" class="">https://review.openstack.org/#/c/429753/</a></div>
<div class="">[2] <a href="https://review.openstack.org/#/c/430941/" class="">https://review.openstack.org/#/c/430941/</a></div>
</div>
<div class=""><br class="">
</div>
<div class="">FFE approved for Magnum, provided this does not cause problems for other projects.</div>
<div class=""><br class="">
</div>
<div class="">Adrian</div>
<div class=""><br class="">
<div>
<blockquote type="cite" class="">
<div class="">On Feb 8, 2017, at 7:25 AM, Adrian Otto <<a href="mailto:adrian.otto@rackspace.com" class="">adrian.otto@rackspace.com</a>> wrote:</div>
<br class="Apple-interchange-newline">
<div class="">We are actively working to verify that magnum-ui works with the adjusted requirements.txt, and as soon as we have confirmed this change is non-disruptive, I will be ready to approve the FFE.<br class="">
<br class="">
Adrian<br class="">
<br class="">
<blockquote type="cite" class="">On Feb 7, 2017, at 4:54 PM, Richard Jones <<a href="mailto:r1chardj0n3s@gmail.com" class="">r1chardj0n3s@gmail.com</a>> wrote:<br class="">
<br class="">
It looks like Magnum-UI only has one xstatic package in their<br class="">
requirements that isn't already in Horizon's requirements (and<br class="">
therefore is superfluous), and that's xstatic-magic-search, which has<br class="">
been replaced in Horizon by pulling magic search into the Horizon tree<br class="">
(we forked because maintaining our own extensions against the package<br class="">
was getting out of hand - we'd basically rewritten a large proportion<br class="">
of the code).<br class="">
<br class="">
I would recommend that the Magnum-UI project remove all xstatic<br class="">
packages from requirements.txt<br class="">
<br class="">
<br class="">
Richard<br class="">
<br class="">
On 7 February 2017 at 14:17, Tony Breeds <<a href="mailto:tony@bakeyournoodle.com" class="">tony@bakeyournoodle.com</a>> wrote:<br class="">
<blockquote type="cite" class="">On Tue, Feb 07, 2017 at 10:39:41AM +1100, Richard Jones wrote:<br class="">
<blockquote type="cite" class="">Hi requirements team,<br class="">
<br class="">
We've had a downstream packager come to us with issues packaging the<br class="">
Horizon RC as described in this bug report:<br class="">
<br class="">
<a href="https://bugs.launchpad.net/horizon/+bug/1662180" class="">https://bugs.launchpad.net/horizon/+bug/1662180</a><br class="">
<br class="">
The issues stems from the requirements file having several xstatic<br class="">
package minimum versions specified that are no longer compatible with<br class="">
Horizon, and the RDO build system honors those minimum version<br class="">
specifications, and boom!<br class="">
</blockquote>
<br class="">
This is a specific case of OpenStack provides poor tools for testing/validating<br class="">
minimum requirements. This is a thing we started trying to fix in Ocata but<br class="">
the work is slow going :( I'm a little confused how this wasn't caught sooner<br class="">
by RDO (given they would appear to have been testing the minimums for xstatic-*)<br class="">
<br class="">
<blockquote type="cite" class="">Rob Cresswell has proposed a patch to bump those minimum versions up<br class="">
to the versions specified in upper-constraints.txt:<br class="">
<br class="">
<a href="https://review.openstack.org/#/c/429753" class="">https://review.openstack.org/#/c/429753</a><br class="">
</blockquote>
<br class="">
That review seems to adjust all Xstatic packages where the minimu != the<br class="">
constrained version which is probably more than is required but it doesn't<br class="">
actually increase the knock-on effects so it seems like a good idea to me :)<br class="">
<br class="">
Looking at the projects that are affected by Rob's review:<br class="">
<br class="">
Package : xstatic-angular [xstatic-angular>=1.3.7] (used by 3 projects)<br class="">
Package : xstatic-angular-bootstrap [xstatic-angular-bootstrap>=0.11.0.2] (used by 3 projects)<br class="">
Package : xstatic-angular-gettext [xstatic-angular-gettext>=2.1.0.2] (used by 3 projects)<br class="">
Package : xstatic-bootstrap-scss [xstatic-bootstrap-scss>=3.1.1.1] (used by 3 projects)<br class="">
Package : xstatic-d3 [xstatic-d3>=3.1.6.2] (used by 3 projects)<br class="">
Package : xstatic-font-awesome [xstatic-font-awesome>=4.3.0] (used by 3 projects)<br class="">
Package : xstatic-jasmine [xstatic-jasmine>=2.1.2.0] (used by 3 projects)<br class="">
Package : xstatic-jsencrypt [xstatic-jsencrypt>=2.0.0.2] (used by 3 projects)<br class="">
Package : xstatic-rickshaw [xstatic-rickshaw>=1.5.0] (used by 3 projects)<br class="">
Package : xstatic-smart-table [xstatic-smart-table!=1.4.13.0,>=1.4.5.3] (used by 3 projects)<br class="">
Package : xstatic-term-js [xstatic-term-js>=0.0.4.1] (used by 3 projects)<br class="">
openstack/horizon [tc:approved-release]<br class="">
openstack/karbor-dashboard []<br class="">
openstack/magnum-ui []<br class="">
<br class="">
<br class="">
Package : xstatic-bootswatch [xstatic-bootswatch>=3.3.5.3] (used by 1 projects)<br class="">
openstack/horizon [tc:approved-release]<br class="">
<br class="">
And obviously RDO<br class="">
<br class="">
This will mean that Horizon will need an RC2, and any packaging/distro testing<br class="">
for horizon (and plugins/dashboards) will need to be restarted (iff said<br class="">
testing was done with an xstatic package not listed in upper-constraaints.txt[1])<br class="">
<br class="">
I tried to determine the impact on magnum-ui and karbor-dashboard and AFAICT<br class="">
they're already using constraints. The next thing to look at is the release<br class="">
model which is:<br class="">
magnum-ui:<br class="">
type: horizon-plugin<br class="">
model: cycle-with-intermediary<br class="">
karbor-dashboard:<br class="">
type: unknown<br class="">
model: unknown<br class="">
<br class="">
I think this means it's safe grant this FFE as the affected plugins aren't<br class="">
necessarily in a stabilisation phase.<br class="">
<br class="">
So as far as I can see we have 2 options:<br class="">
1. Do nothing: there will be other cases that minimums are not functional.<br class="">
RDO have tools and data to fix this in there own repos so we're not<br class="">
actually blocking them<br class="">
2. Take the patch, and accept the knock on effects.<br class="">
<br class="">
I'm okay with taking this FFE if Karbor and Magnum PTLs sign off here (or on the review)<br class="">
<br class="">
<blockquote type="cite" class="">Additionally to the above I will be proposing a patch to Horizon's<br class="">
documented processes to ensure that when an xstatic upper-constraints<br class="">
version is bumped we also bump the minimum version in<br class="">
global-requirements to avoid this sort of thing in the future.<br class="">
</blockquote>
<br class="">
Cool. That'll help<br class="">
<br class="">
Yours Tony.<br class="">
<br class="">
[1] We've communicated that u-c should be the source here before<br class="">
<br class="">
__________________________________________________________________________<br class="">
OpenStack Development Mailing List (not for usage questions)<br class="">
Unsubscribe: <a href="mailto:OpenStack-dev-request@lists.openstack.org" class="">
OpenStack-dev-request@lists.openstack.org</a>?subject:unsubscribe<br class="">
<a href="http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev" class="">http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev</a><br class="">
<br class="">
</blockquote>
<br class="">
__________________________________________________________________________<br class="">
OpenStack Development Mailing List (not for usage questions)<br class="">
Unsubscribe: <a href="mailto:OpenStack-dev-request@lists.openstack.org" class="">
OpenStack-dev-request@lists.openstack.org</a>?subject:unsubscribe<br class="">
<a href="http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev" class="">http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev</a><br class="">
</blockquote>
<br class="">
<br class="">
__________________________________________________________________________<br class="">
OpenStack Development Mailing List (not for usage questions)<br class="">
Unsubscribe: <a href="mailto:OpenStack-dev-request@lists.openstack.org" class="">
OpenStack-dev-request@lists.openstack.org</a>?subject:unsubscribe<br class="">
<a href="http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev" class="">http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev</a><br class="">
</div>
</blockquote>
</div>
<br class="">
</div>
</body>
</html>