<html>
<head>
<meta content="text/html; charset=windows-1252"
http-equiv="Content-Type">
</head>
<body bgcolor="#FFFFFF" text="#000000">
Hi Mike,<br>
<br>
Comments below..<br>
<br>
Thanks,<br>
Octave<br>
<br>
<div class="moz-cite-prefix">On 2/3/2017 7:41 AM, Mike Bayer wrote:<br>
</div>
<blockquote
cite="mid:1ab43de3-b9f0-5baa-fc65-844491ca7d7c@redhat.com"
type="cite">
<br>
<br>
On 02/02/2017 05:28 PM, Octave J. Orgeron wrote:
<br>
<blockquote type="cite">That refers to the total length of the
row. InnoDB has a limit of 65k
<br>
and NDB is limited to 14k.
<br>
<br>
A simple example would be the volumes table in Cinder where the
row
<br>
length goes beyond 14k. So in the IF logic block, I change
columns types
<br>
that are vastly oversized such as status and attach_status,
which by
<br>
default are 255 chars.
<br>
</blockquote>
<br>
<br>
let me give you a tip on IF blocks, that they are a bit of an
anti-pattern. If you want a column type to do one thing in one
case, and another in another case, create an object that does the
thing you want:
<br>
<br>
<br>
some_table = Table(
<br>
'some_table', metadata,
<br>
Column('my_column', VARCHAR(255).with_variant(VARCHAR(50),
'ndb'))
<br>
)
<br>
<br>
<br>
I think we might want to look into creating a stub dialect called
'ndb' that subclasses mysql+pymysql. Treating ndb as a whole
different database means there's no longer the need for a flag in
oslo.db, the 'ndb' name would instead be interpreted as a new
backend - the main thing would be ensuring all the
mysql-appropriate hooks in oslo.db are also emitted for ndb, but
this also gives us a way to pick and choose which hooks apply.
It seems like there may be enough different about it to separate
it at this level.
<br>
<br>
Not sure if people on the list are seeing that we are
simultaneously talking about getting rid of Postgresql in the
efforts to support only "one database", while at the same time
adding one that is in many ways a new database.
<br>
<br>
<br>
</blockquote>
<br>
This is an interesting approach as it would significantly reduce the
amount of code in my patches today. Do you have any pointers on
where this should be implemented as a stub? Would we have to take
different approaches for SQL Alchemy vs. Alembic?<br>
<br>
<br>
<div class="moz-signature">-- <br>
<br>
<p>
<a href="http://www.oracle.com/" target="_blank"><img
src="cid:part1.08070503.04030000@oracle.com" alt="Oracle"
border="0" height="26" width="114"></a><br>
<font color="#666666" size="2" face="Verdana, Arial, Helvetica,
sans-serif">Octave J. Orgeron | Sr. Principal Architect and
Software Engineer<br>
<font color="#ff0000">Oracle</font> Linux OpenStack<br>
Mobile: <a href="tel:+17206161550">+1-720-616-1550</a><br>
500 Eldorado Blvd. | Broomfield, CO 80021<br>
<a
href="http://www.oracle.com/us/solutions/enterprise-architecture/index.html"><img
src="cid:part4.07040808.06060600@oracle.com"
alt="Certified Oracle Enterprise Architect: Systems
Infrastructure" border="0" height="42" width="182"></a><br>
<a href="http://www.oracle.com/commitment" target="_blank"><img
src="cid:part6.01000606.07010702@oracle.com" alt="Green
Oracle" align="absmiddle" border="0" height="28"
width="44"></a>
<font color="#4B7D42" size="1" face="Verdana, Arial,
Helvetica, sans-serif">Oracle is committed to developing
practices and products that help protect the environment</font>
</font></p>
<font color="#666666" size="2" face="Verdana, Arial, Helvetica,
sans-serif">
</font></div>
</body>
</html>