<div dir="ltr"><br><div class="gmail_extra"><br><div class="gmail_quote">2017-01-29 1:31 GMT+08:00 Matt Riedemann <span dir="ltr"><<a href="mailto:mriedemos@gmail.com" target="_blank">mriedemos@gmail.com</a>></span>:<br><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"><div class="gmail-HOEnZb"><div class="gmail-h5">On 1/27/2017 3:37 AM, Alex Xu wrote:<br>
</div></div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"><div><div class="gmail-h5">
The patches about validation the filters and sorts for servers API are<br>
merged [0]. But we still have something left [1].<br>
<br>
The left is about the proposal of introducing the new rule<br>
'os_compute_api:servers:all_te<wbr>nants_visible' which is soft enforcement.<br>
The new rule will instead of the old hard enforcement rule<br>
"os_compute_api:servers:index:<wbr>get_all_tenants".<br>
<br>
In the discussion of nova API meeting, Join pointed out that the change<br>
from hard enforcement to soft enforcement needs Microversion. The API<br>
used to return 403 when user didn't have permission of all_tenants<br>
parameter. But now the API returns 200 with the own instances when no<br>
permission of all_tenants parameter. So the proposal should be separated<br>
to two parts:<br>
<br>
i. rename the policy from "get_all_tenants" to the "all_tenants_visible"<br>
ii. change the enforcement from hard to soft by Microversion.<br>
<br>
In the old microversion, the rule keeps as hard enforcement.<br>
<br>
So in Ocata, "get_all_tenants" will be deprecated. If the deployer have<br>
overriden rule in the policy file, the old rule still will be enforced,<br>
and the warning message will be emit to notice that the user needs to<br>
move their custom rule to the new rule 'all_tenants_visiable'. And if<br>
the API user requests with new microversion, the rule will become soft<br>
enforcement.<br>
<br>
So if that sounds make sense, there also have another question about<br>
whether we have enough time to merge it. I think Matt will make a call<br>
on it.<br>
<br>
And due to holidays in China, both I and Kevin are in vacation.  And<br>
really really appreciate Ghanshyam take care on those patches! The<br>
spec[3] and the patch[1] already updated by him.<br>
<br>
Anyway....Happy Chinese New Year to everyone(yea, new year again \o/).<br>
<br>
Thanks<br>
Alex<br>
<br>
[0] <a href="https://review.openstack.org/408571" rel="noreferrer" target="_blank">https://review.openstack.org/4<wbr>08571</a><br>
<<a href="https://review.openstack.org/408571" rel="noreferrer" target="_blank">https://review.openstack.org/<wbr>408571</a>><br>
and <a href="https://review.openstack.org/415142" rel="noreferrer" target="_blank">https://review.openstack.org/4<wbr>15142</a><br>
<<a href="https://review.openstack.org/415142" rel="noreferrer" target="_blank">https://review.openstack.org/<wbr>415142</a>><br>
[1] <a href="https://review.openstack.org/#/q/status:open+project:openstack/nova+branch:master+topic:bp/add-whitelist-for-server-list-filter-sort-parameters" rel="noreferrer" target="_blank">https://review.openstack.org/#<wbr>/q/status:open+project:opensta<wbr>ck/nova+branch:master+topic:<wbr>bp/add-whitelist-for-server-<wbr>list-filter-sort-parameters</a><br>
<<a href="https://review.openstack.org/#/q/status:open+project:openstack/nova+branch:master+topic:bp/add-whitelist-for-server-list-filter-sort-parameters" rel="noreferrer" target="_blank">https://review.openstack.org/<wbr>#/q/status:open+project:openst<wbr>ack/nova+branch:master+topic:<wbr>bp/add-whitelist-for-server-<wbr>list-filter-sort-parameters</a>><br>
[3] <a href="https://review.openstack.org/425533" rel="noreferrer" target="_blank">https://review.openstack.org/4<wbr>25533</a><br></div></div>
<<a href="https://review.openstack.org/425533" rel="noreferrer" target="_blank">https://review.openstack.org/<wbr>425533</a>><br>
<br>
<br>
<br>
______________________________<wbr>______________________________<wbr>______________<br>
OpenStack Development Mailing List (not for usage questions)<br>
Unsubscribe: <a href="http://OpenStack-dev-request@lists.openstack.org?subject:unsubscribe" rel="noreferrer" target="_blank">OpenStack-dev-request@lists.op<wbr>enstack.org?subject:unsubscrib<wbr>e</a><br>
<a href="http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev" rel="noreferrer" target="_blank">http://lists.openstack.org/cgi<wbr>-bin/mailman/listinfo/openstac<wbr>k-dev</a><br>
<br>
</blockquote>
<br>
My immediate question is, does this need to happen in Ocata or can we defer the all_tenants_visible policy change to Pike? Is there anything we merged in Ocata that is now broken, or weird, or blocks us from doing something later, etc if we don't get this done now?<br></blockquote><div><br></div><div>I didn't see any broken or blocks without the all_tenants_visiable policy change. The policy change is just part of vision of how filters should be looks like between admin user and non-admin user.</div><div> </div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">
<br>
Honestly I never really understood why the all_tenants policy change was being lumped in with the server sort/filter whitelist blueprint, except maybe just because of convenience?<br></blockquote><div><br></div><div>Emm..I didn't remember any discussion about why we should put all of them into one spec or not.</div><div><br></div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">
<br>
Anyway, this seems like something we can defer to Pike unless I'm missing something.</blockquote><div><br></div><div>I'm ok with that, due to I didn't have any critical reason. The only thing is we need one more cycle to remove a old policy rule. But currently the new proposal without more discussion, and we only have 1 week left for spec change and patches. It isn't worth to take that risk I guess.</div><div><br></div><div>Anyway, Matt, thanks for your response.</div><div> </div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"><span class="gmail-HOEnZb"><font color="#888888"><br>
<br>
-- <br>
<br>
Thanks,<br>
<br>
Matt Riedemann<br>
<br>
______________________________<wbr>______________________________<wbr>______________<br>
OpenStack Development Mailing List (not for usage questions)<br>
Unsubscribe: <a href="http://OpenStack-dev-request@lists.openstack.org?subject:unsubscribe" rel="noreferrer" target="_blank">OpenStack-dev-request@lists.op<wbr>enstack.org?subject:unsubscrib<wbr>e</a><br>
<a href="http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev" rel="noreferrer" target="_blank">http://lists.openstack.org/cgi<wbr>-bin/mailman/listinfo/openstac<wbr>k-dev</a><br>
</font></span></blockquote></div><br></div></div>