<div dir="ltr">I pushed <a href="https://review.openstack.org/#/c/425023">https://review.openstack.org/#/c/425023</a> as one of approaches. </div><br><div class="gmail_quote"><div dir="ltr">On Wed, Jan 25, 2017 at 10:29 AM Anna Taraday <<a href="mailto:akamyshnikova@mirantis.com">akamyshnikova@mirantis.com</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div dir="ltr">Thanks for bringing this up! <br><br>I was assuming that from Ocata everyone should switch from usage <font color="#212121">'old' TunnelTypeDriver to updated one.</font><br><br><font color="#212121">Revering both back to session means reverting all refactor and this is not in line with enginefacade work and as I remember some of OVO patches we waiting for this refactor too.<br><br>I we can duplicate methods or we can check type of the argument if session or context and proceed differently. I will push patch for this ASAP. </font></div><br><div class="gmail_quote"><div dir="ltr">On Wed, Jan 25, 2017 at 2:15 AM Ihar Hrachyshka <<a href="mailto:ihrachys@redhat.com">ihrachys@redhat.com</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">Hi Anna,<br class="gmail_msg">
<br class="gmail_msg">
I see that as part of [1], we changed the argument type for the $subj<br class="gmail_msg">
function from session to context. Sadly, it turns out we still call it<br class="gmail_msg">
with a session from the 'old' TunnelTypeDriver. I suspect the same<br class="gmail_msg">
issue may affect allocate_fully_specified_segment.<br class="gmail_msg">
<br class="gmail_msg">
I assume that means all 'old' tunnel type drivers are broken. Should<br class="gmail_msg">
we fix it by duplicating those two functions for old and new cases<br class="gmail_msg">
too? Or should we revert both of them back to session? (I assume the<br class="gmail_msg">
former, since the latter is not in line with enginefacade work.)<br class="gmail_msg">
<br class="gmail_msg">
[1] <a href="https://review.openstack.org/#/c/398873/10/neutron/plugins/ml2/drivers/helpers.py" rel="noreferrer" class="gmail_msg" target="_blank">https://review.openstack.org/#/c/398873/10/neutron/plugins/ml2/drivers/helpers.py</a><br class="gmail_msg">
<br class="gmail_msg">
Thanks in advance,<br class="gmail_msg">
Ihar<br class="gmail_msg">
</blockquote></div><div dir="ltr">-- <br></div><div data-smartmail="gmail_signature"><div dir="ltr">Regards,<br>Ann Taraday</div></div></blockquote></div><div dir="ltr">-- <br></div><div data-smartmail="gmail_signature"><div dir="ltr">Regards,<br>Ann Taraday</div></div>