<html>
<head>
<meta http-equiv="Content-Type" content="text/html; charset=us-ascii">
</head>
<body>
Hi Steve,<br>
<br>
Thank you for the update. I have already submitted patches for python-novaclient and python-novaclient for reviews and ready with python-cinderclient and python-novaclient patches. I will submit them ASAP when requirements.txt is synced with updated version
of keystoneauth1.<br>
<br>
Thank you,<br>
<br>
Abhishek
<hr style="display:inline-block;width:98%" tabindex="-1">
<div id="divRplyFwdMsg" dir="ltr"><font face="Calibri, sans-serif" style="font-size:11pt" color="#000000"><b>From:</b> Steve Martinelli <s.martinelli@gmail.com><br>
<b>Sent:</b> Saturday, January 21, 2017 10:07:04 AM<br>
<b>To:</b> OpenStack Development Mailing List (not for usage questions)<br>
<b>Subject:</b> Re: [openstack-dev] [ python-novaclient][ python-glanceclient][ python-cinderclient][ python-neutronclient] Remove x-openstack-request-id logging code as it is logged twice</font>
<div> </div>
</div>
<div>
<div dir="ltr"><br>
<div class="gmail_extra"><br>
<div class="gmail_quote">On Fri, Jan 20, 2017 at 10:53 PM, Kekane, Abhishek <span dir="ltr">
<<a href="mailto:Abhishek.Kekane@nttdata.com" target="_blank">Abhishek.Kekane@nttdata.com</a>></span> wrote:<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
<div>
<div>Hi Dims,<br>
<br>
Thank you for reply. I will propose a patch soon. Just for curiosity, keystoneauth1 >= 2.17.0 will not install 2.18.0?<br>
</div>
</div>
</blockquote>
<div><br>
</div>
<div>It will, but if we make 2.18.0 the minimum then it will for sure install only that level.</div>
<div><br>
</div>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
<div>
<div>
<div class="h5"><font size="2"><span style="font-size:10pt">
<div class="m_-4130688048511328877PlainText">> In the latest keystoneauth1 version 2.18.0, x-openstack-request-id is logged<br>
> for every HTTP response. This keystoneauth1 version will be used for ocata.<br>
><br>
> The same request id is also logged in 'request' method of SessionClient<br>
> class for python-novaclient, python-glanceclient, python-cinderclient and<br>
> python-neutronclient. Once requirements.txt is synced with<br>
> global-requirements and it uses keystoneauth1 version 2.18.0 and above,<br>
> x-openstack-request-id will be logged twice for these clients.<br>
</div>
</span></font></div>
</div>
</div>
</blockquote>
<div><br>
</div>
<div>So I approved this change (sorry it took so long to review and merge), but I didn't realize it was going to impact python-{nova | glance | cinder | neutron}client. I think it's slightly unrealistic to ask four teams to remove the logging in the last week
we release clients (I'm assuming we want to remove the functionality and not log things twice).</div>
<div><br>
</div>
<div> - Would folks prefer I revert the keystoneauth change and re-release without it, and we can bring it back in Pike?</div>
<div>- Do teams have the bandwidth to remove the request id logging in the next few days?</div>
<div><br>
</div>
<div>Sorry for the confusion this caused.</div>
</div>
</div>
</div>
</div>
<br clear="both">
______________________________________________________________________<BR>
Disclaimer: This email and any attachments are sent in strictest confidence<BR>
for the sole use of the addressee and may contain legally privileged,<BR>
confidential, and proprietary data. If you are not the intended recipient,<BR>
please advise the sender by replying promptly to this email and then delete<BR>
and destroy this email and any attachments without any further use, copying<BR>
or forwarding.<BR>
</body>
</html>