<div dir="ltr">LGTM</div><br><div class="gmail_quote"><div dir="ltr">On Tue, Nov 29, 2016 at 6:38 PM Weyl, Alexey (Nokia - IL) <<a href="mailto:alexey.weyl@nokia.com">alexey.weyl@nokia.com</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">Sounds good to me :)<br class="gmail_msg">
<br class="gmail_msg">
From: Afek, Ifat (Nokia - IL) [mailto:<a href="mailto:ifat.afek@nokia.com" class="gmail_msg" target="_blank">ifat.afek@nokia.com</a>]<br class="gmail_msg">
Sent: Tuesday, November 29, 2016 11:23 AM<br class="gmail_msg">
To: OpenStack Development Mailing List (not for usage questions)<br class="gmail_msg">
Subject: Suspected SPAM - Re: [openstack-dev] Suspected SPAM - [vitrage] datasources terminology<br class="gmail_msg">
<br class="gmail_msg">
Hi,<br class="gmail_msg">
<br class="gmail_msg">
A new suggestion:<br class="gmail_msg">
<br class="gmail_msg">
• event_type: the type of event/notification that comes from the datasource. For example: ‘compute.instance.delete.end’,  ‘volume.detach.start’<br class="gmail_msg">
• graph_action: used to tell the evaluator what to do with the entity - create, update or delete it.<br class="gmail_msg">
• datasource_action: the type of action that was performed by the driver: init_snapshot, snapshot or update.<br class="gmail_msg">
<br class="gmail_msg">
What do you think?<br class="gmail_msg">
Ifat.<br class="gmail_msg">
<br class="gmail_msg">
<br class="gmail_msg">
From: "Afek, Ifat (Nokia - IL)"<br class="gmail_msg">
Reply-To: "OpenStack Development Mailing List (not for usage questions)"<br class="gmail_msg">
Date: Tuesday, 29 November 2016 at 09:26<br class="gmail_msg">
To: "OpenStack Development Mailing List (not for usage questions)"<br class="gmail_msg">
Subject: Suspected SPAM - [openstack-dev] [vitrage] datasources terminology<br class="gmail_msg">
<br class="gmail_msg">
Hi,<br class="gmail_msg">
<br class="gmail_msg">
I think we have a confusing terminology in Vitrage datasources. <br class="gmail_msg">
<br class="gmail_msg">
The following parameters are used in the drivers and transformers: <br class="gmail_msg">
• event_type: the type of event/notification that comes from the datasource. For example: ‘compute.instance.delete.end’,  ‘volume.detach.start’<br class="gmail_msg">
• event_action: used to tell the evaluator what to do with the entity - create, update or delete it.<br class="gmail_msg">
• action_type: the type of action that was performed by the driver: init_snapshot, snapshot or update.<br class="gmail_msg">
<br class="gmail_msg">
Personally I find these names very confusing. <br class="gmail_msg">
My suggestion is to rename action_type to datasource_mode, or something similar.<br class="gmail_msg">
<br class="gmail_msg">
Your thoughts?<br class="gmail_msg">
<br class="gmail_msg">
Thanks,<br class="gmail_msg">
Ifat.<br class="gmail_msg">
<br class="gmail_msg">
__________________________________________________________________________<br class="gmail_msg">
OpenStack Development Mailing List (not for usage questions)<br class="gmail_msg">
Unsubscribe: <a href="http://OpenStack-dev-request@lists.openstack.org?subject:unsubscribe" rel="noreferrer" class="gmail_msg" target="_blank">OpenStack-dev-request@lists.openstack.org?subject:unsubscribe</a><br class="gmail_msg">
<a href="http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev" rel="noreferrer" class="gmail_msg" target="_blank">http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev</a><br class="gmail_msg">
</blockquote></div>