<div dir="ltr"><div dir="ltr" class="gmail_msg">Agree.</div><div dir="ltr" class="gmail_msg"><br></div><div class="gmail_msg">It seems I missed the first clause in Alexeys 2nd proposal. `get_all` in constructor could be a good solution.</div><br class="gmail_msg"><div class="gmail_quote gmail_msg"><div dir="ltr" class="gmail_msg">On Mon, Nov 28, 2016 at 12:18 PM <<a href="mailto:dong.wenjuan@zte.com.cn" class="gmail_msg" target="_blank">dong.wenjuan@zte.com.cn</a>> wrote:<br class="gmail_msg"></div><blockquote class="gmail_quote gmail_msg" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
<br class="gmail_msg"><font size="2" face="sans-serif" class="gmail_msg"><br class="gmail_msg">
</font><font size="3" class="gmail_msg">Hi all,</font>
<br class="gmail_msg">
<br class="gmail_msg"><font size="3" class="gmail_msg">Maybe call the get_all method in the AodhDriver constructor
and cache all the alarms is a simple way.<br class="gmail_msg">
</font>
<br class="gmail_msg"><font size="3" class="gmail_msg">BR,</font>
<br class="gmail_msg"><font size="3" class="gmail_msg">dwj</font>
<br class="gmail_msg">
<br class="gmail_msg">
<br class="gmail_msg">
<br class="gmail_msg">
<p></p><table width="100%" class="gmail_msg">
<tbody><tr valign="top" class="gmail_msg">
<td width="36%" class="gmail_msg"><font size="1" face="sans-serif" class="gmail_msg"><b class="gmail_msg">Yujun Zhang <<a href="mailto:zhangyujun%2Bzte@gmail.com" class="gmail_msg" target="_blank">zhangyujun+zte@gmail.com</a>></b>
</font>
<p class="gmail_msg"><font size="1" face="sans-serif" class="gmail_msg">2016-11-28 11:23</font>
</p></td><td width="63%" class="gmail_msg">
<table width="100%" class="gmail_msg">
<tbody><tr valign="top" class="gmail_msg">
<td class="gmail_msg">
<div align="right" class="gmail_msg"><font size="1" face="sans-serif" class="gmail_msg">收件人</font></div>
</td><td class="gmail_msg"><font size="1" face="sans-serif" class="gmail_msg">"OpenStack Development Mailing
List (not for usage questions)" <<a href="mailto:openstack-dev@lists.openstack.org" class="gmail_msg" target="_blank">openstack-dev@lists.openstack.org</a>>,
"<a href="mailto:dong.wenjuan@zte.com.cn" class="gmail_msg" target="_blank">dong.wenjuan@zte.com.cn</a>" <<a href="mailto:dong.wenjuan@zte.com.cn" class="gmail_msg" target="_blank">dong.wenjuan@zte.com.cn</a>></font>
</td></tr><tr valign="top" class="gmail_msg">
<td class="gmail_msg">
<div align="right" class="gmail_msg"><font size="1" face="sans-serif" class="gmail_msg">抄送</font></div>
</td><td class="gmail_msg"><font size="1" face="sans-serif" class="gmail_msg">"Hefetz, Idan (Nokia - IL)"
<<a href="mailto:idan.hefetz@nokia.com" class="gmail_msg" target="_blank">idan.hefetz@nokia.com</a>>, "<a href="mailto:zhang.yujunz@zte.com.cn" class="gmail_msg" target="_blank">zhang.yujunz@zte.com.cn</a>" <<a href="mailto:zhang.yujunz@zte.com.cn" class="gmail_msg" target="_blank">zhang.yujunz@zte.com.cn</a>></font>
</td></tr><tr valign="top" class="gmail_msg">
<td class="gmail_msg">
<div align="right" class="gmail_msg"><font size="1" face="sans-serif" class="gmail_msg">主题</font></div>
</td><td class="gmail_msg"><font size="1" face="sans-serif" class="gmail_msg">Re: [openstack-dev] [vitrage] about
aodh alarm notification</font></td></tr></tbody></table>
<br class="gmail_msg">
<table class="gmail_msg">
<tbody><tr valign="top" class="gmail_msg">
<td class="gmail_msg">
</td><td class="gmail_msg"></td></tr></tbody></table>
<br class="gmail_msg"></td></tr></tbody></table>
<br class="gmail_msg">
<br class="gmail_msg">
<br class="gmail_msg"><font size="3" class="gmail_msg">Hi, Alexey</font>
<br class="gmail_msg">
<br class="gmail_msg"><font size="3" class="gmail_msg">My comments inline.<br class="gmail_msg">
</font>
<br class="gmail_msg"><font size="3" class="gmail_msg">On Mon, Nov 28, 2016 at 1:52 AM Weyl, Alexey (Nokia -
IL) <</font><a href="mailto:alexey.weyl@nokia.com" class="gmail_msg" target="_blank"><font size="3" color="blue" class="gmail_msg"><u class="gmail_msg">alexey.weyl@nokia.com</u></font></a><font size="3" class="gmail_msg">>
wrote:</font>
<br class="gmail_msg"><font size="2" color="#1f497d" face="Calibri" class="gmail_msg">Hi Dong,</font>
<p class="gmail_msg"><font size="2" color="#1f497d" face="Calibri" class="gmail_msg"> </font>
</p><p class="gmail_msg"><font size="2" color="#1f497d" face="Calibri" class="gmail_msg">I can think of 2 solutions
for this problem:</font>
</p><p class="gmail_msg"><font size="2" color="#1f497d" face="Calibri" class="gmail_msg">1.
We can talk with the AODH developers and check if they can add additional
data for the aodh notifications.</font>
</p><p class="gmail_msg"><font size="3" class="gmail_msg">I think it might not be easily accepted since sending only
the changes on update notification looks more reasonable to me. </font>
<br class="gmail_msg"><font size="2" color="#1f497d" face="Calibri" class="gmail_msg">2.
We can add a cache in the aodh driver, and call the get_all method in the
AodhDriver constructor or when the first notification happens and fill
the cache with the data. Then for each notification that arrives you
will update that cache in the aodh notification service, and send then
event with all the data you need.</font>
</p><p class="gmail_msg"><font size="3" class="gmail_msg">I doubt this will degrade the performance for the first
notification since there will be additional conversation to retrieve the
full data. </font>
<br class="gmail_msg">
<br class="gmail_msg"><font size="3" class="gmail_msg">My proposal is to share a cache between snapshot service
and listener service and I think it is a common requirements for all datasource
using PUSH method.</font>
<br class="gmail_msg">
</p><p></p><p></p><p></p><p></p></blockquote></div></div>