<div dir="ltr"><br><div class="gmail_extra"><br><div class="gmail_quote">On 24 November 2016 at 09:41, Kevin Benton <span dir="ltr"><<a href="mailto:kevin@benton.pub" target="_blank">kevin@benton.pub</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div dir="auto">Yeah, in this case I don't think it would have helped because it was removing several things from neutron simultaneously. The only thing that would have stopped that would have been jobs from all sub projects voting on each neutron change. </div></blockquote><div><br></div><div>Right, and that's never gonna happen otherwise we might as well put all the code back into one tree.</div><div> </div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div class="HOEnZb"><div class="h5"><div class="gmail_extra"><br><div class="gmail_quote">On Nov 24, 2016 10:02, "Armando M." <<a href="mailto:armamig@gmail.com" target="_blank">armamig@gmail.com</a>> wrote:<br type="attribution"><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div dir="ltr"><br><div class="gmail_extra"><br><div class="gmail_quote">On 24 November 2016 at 05:27, Neil Jerram <span dir="ltr"><<a href="mailto:neil@tigera.io" target="_blank">neil@tigera.io</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div dir="ltr">But I think a periodic check for a Neutron/neutron-lib-using project (such as networking-calico) would still be a decent way of catching such issues, wouldn't it?</div></blockquote><div><br></div><div>It depends, and it would. There are many factors at play, as Kevin pointed out.</div><div> </div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div dir="ltr"><div><div class="m_-5667082290560685121m_-7455954948602079198h5"><br><div><br><div class="gmail_quote"><div dir="ltr">On Thu, Nov 24, 2016 at 12:58 AM Kevin Benton <kevin@benton.pub> wrote:<br></div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div dir="ltr" class="m_-5667082290560685121m_-7455954948602079198m_-8602721088003730304gmail_msg">The issue we had is different than breaking changes in neutron-lib. The issue we are running into now is bumps in the road when we are removing deprecated things from Neutron that other projects are still using even though they should be using the neutron-lib version instead.</div><div class="gmail_extra m_-5667082290560685121m_-7455954948602079198m_-8602721088003730304gmail_msg"><br class="m_-5667082290560685121m_-7455954948602079198m_-8602721088003730304gmail_msg"><div class="gmail_quote m_-5667082290560685121m_-7455954948602079198m_-8602721088003730304gmail_msg">On Wed, Nov 23, 2016 at 5:42 PM, Joshua Harlow <span dir="ltr" class="m_-5667082290560685121m_-7455954948602079198m_-8602721088003730304gmail_msg"><<a href="mailto:harlowja@fastmail.com" class="m_-5667082290560685121m_-7455954948602079198m_-8602721088003730304gmail_msg" target="_blank">harlowja@fastmail.com</a>></span> wrote:<br class="m_-5667082290560685121m_-7455954948602079198m_-8602721088003730304gmail_msg"><blockquote class="gmail_quote m_-5667082290560685121m_-7455954948602079198m_-8602721088003730304gmail_msg" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">A suggestion would also to setup something like the following:<br class="m_-5667082290560685121m_-7455954948602079198m_-8602721088003730304gmail_msg">
<br class="m_-5667082290560685121m_-7455954948602079198m_-8602721088003730304gmail_msg">
<a href="https://wiki.openstack.org/wiki/Oslo#Periodic" rel="noreferrer" class="m_-5667082290560685121m_-7455954948602079198m_-8602721088003730304gmail_msg" target="_blank">https://wiki.openstack.org/wik<wbr>i/Oslo#Periodic</a><br class="m_-5667082290560685121m_-7455954948602079198m_-8602721088003730304gmail_msg">
<br class="m_-5667082290560685121m_-7455954948602079198m_-8602721088003730304gmail_msg">
Get the users of neutron lib being tested against the latest neutron lib (at least nightly) and seeing if they will be borked by a new neutron lib merge...<br class="m_-5667082290560685121m_-7455954948602079198m_-8602721088003730304gmail_msg">
<br class="m_-5667082290560685121m_-7455954948602079198m_-8602721088003730304gmail_msg">
<a href="http://status.openstack.org/openstack-health/#/?groupKey=build_name&resolutionKey=hour&searchProject=-with-oslo" rel="noreferrer" class="m_-5667082290560685121m_-7455954948602079198m_-8602721088003730304gmail_msg" target="_blank">http://status.openstack.org/op<wbr>enstack-health/#/?groupKey=bui<wbr>ld_name&resolutionKey=hour&sea<wbr>rchProject=-with-oslo</a><br class="m_-5667082290560685121m_-7455954948602079198m_-8602721088003730304gmail_msg">
<br class="m_-5667082290560685121m_-7455954948602079198m_-8602721088003730304gmail_msg">
Overall be careful with the APIs u expose and plan out how u will shift users from the old API to the new API (without destroying the world during that transition).<br class="m_-5667082290560685121m_-7455954948602079198m_-8602721088003730304gmail_msg">
<br class="m_-5667082290560685121m_-7455954948602079198m_-8602721088003730304gmail_msg">
My 3 cents :-P<br class="m_-5667082290560685121m_-7455954948602079198m_-8602721088003730304gmail_msg">
<br class="m_-5667082290560685121m_-7455954948602079198m_-8602721088003730304gmail_msg">
-Josh<div class="m_-5667082290560685121m_-7455954948602079198m_-8602721088003730304m_-3190279742156752157HOEnZb m_-5667082290560685121m_-7455954948602079198m_-8602721088003730304gmail_msg"><div class="m_-5667082290560685121m_-7455954948602079198m_-8602721088003730304m_-3190279742156752157h5 m_-5667082290560685121m_-7455954948602079198m_-8602721088003730304gmail_msg"><br class="m_-5667082290560685121m_-7455954948602079198m_-8602721088003730304gmail_msg">
<br class="m_-5667082290560685121m_-7455954948602079198m_-8602721088003730304gmail_msg">
Boden Russell wrote:<br class="m_-5667082290560685121m_-7455954948602079198m_-8602721088003730304gmail_msg">
<blockquote class="gmail_quote m_-5667082290560685121m_-7455954948602079198m_-8602721088003730304gmail_msg" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
I would encourage anyone working on neutron-lib related changes to have<br class="m_-5667082290560685121m_-7455954948602079198m_-8602721088003730304gmail_msg">
a peek at the recently renovated contributing doc [1] if you haven't<br class="m_-5667082290560685121m_-7455954948602079198m_-8602721088003730304gmail_msg">
already.<br class="m_-5667082290560685121m_-7455954948602079198m_-8602721088003730304gmail_msg">
<br class="m_-5667082290560685121m_-7455954948602079198m_-8602721088003730304gmail_msg">
In particular the 'Phase 4: Consume' section [2] provides some tips on<br class="m_-5667082290560685121m_-7455954948602079198m_-8602721088003730304gmail_msg">
how we see this workflow playing out.<br class="m_-5667082290560685121m_-7455954948602079198m_-8602721088003730304gmail_msg">
<br class="m_-5667082290560685121m_-7455954948602079198m_-8602721088003730304gmail_msg">
Thanks<br class="m_-5667082290560685121m_-7455954948602079198m_-8602721088003730304gmail_msg">
<br class="m_-5667082290560685121m_-7455954948602079198m_-8602721088003730304gmail_msg">
[1]<br class="m_-5667082290560685121m_-7455954948602079198m_-8602721088003730304gmail_msg">
<a href="https://github.com/openstack/neutron-lib/blob/master/doc/source/contributing.rst" rel="noreferrer" class="m_-5667082290560685121m_-7455954948602079198m_-8602721088003730304gmail_msg" target="_blank">https://github.com/openstack/n<wbr>eutron-lib/blob/master/doc/sou<wbr>rce/contributing.rst</a><br class="m_-5667082290560685121m_-7455954948602079198m_-8602721088003730304gmail_msg">
[2]<br class="m_-5667082290560685121m_-7455954948602079198m_-8602721088003730304gmail_msg">
<a href="https://github.com/openstack/neutron-lib/blob/master/doc/source/contributing.rst#phase-4-consume" rel="noreferrer" class="m_-5667082290560685121m_-7455954948602079198m_-8602721088003730304gmail_msg" target="_blank">https://github.com/openstack/n<wbr>eutron-lib/blob/master/doc/sou<wbr>rce/contributing.rst#phase-4-c<wbr>onsume</a><br class="m_-5667082290560685121m_-7455954948602079198m_-8602721088003730304gmail_msg">
<br class="m_-5667082290560685121m_-7455954948602079198m_-8602721088003730304gmail_msg">
<br class="m_-5667082290560685121m_-7455954948602079198m_-8602721088003730304gmail_msg">
On 11/23/16 12:39 PM, Armando M. wrote:<br class="m_-5667082290560685121m_-7455954948602079198m_-8602721088003730304gmail_msg">
<blockquote class="gmail_quote m_-5667082290560685121m_-7455954948602079198m_-8602721088003730304gmail_msg" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
Hi neutrinos,<br class="m_-5667082290560685121m_-7455954948602079198m_-8602721088003730304gmail_msg">
<br class="m_-5667082290560685121m_-7455954948602079198m_-8602721088003730304gmail_msg">
In the last few hours a couple of changes landed [1,2] that caused a bit<br class="m_-5667082290560685121m_-7455954948602079198m_-8602721088003730304gmail_msg">
of a jam in the neutron subproject gates, as they overlapped with<br class="m_-5667082290560685121m_-7455954948602079198m_-8602721088003730304gmail_msg">
another change [3] having impact on the subprojects.<br class="m_-5667082290560685121m_-7455954948602079198m_-8602721088003730304gmail_msg">
<br class="m_-5667082290560685121m_-7455954948602079198m_-8602721088003730304gmail_msg">
This is why it is important to communicate during team meetings and/or<br class="m_-5667082290560685121m_-7455954948602079198m_-8602721088003730304gmail_msg">
ML that patches with potential impact are in flight in our review<br class="m_-5667082290560685121m_-7455954948602079198m_-8602721088003730304gmail_msg">
pipeline, so that we do our best to coordinate the merge process without<br class="m_-5667082290560685121m_-7455954948602079198m_-8602721088003730304gmail_msg">
shooting ourselves in the foot.<br class="m_-5667082290560685121m_-7455954948602079198m_-8602721088003730304gmail_msg">
<br class="m_-5667082290560685121m_-7455954948602079198m_-8602721088003730304gmail_msg">
To bring this back to sanity, I issued a temporary revert [4], so that<br class="m_-5667082290560685121m_-7455954948602079198m_-8602721088003730304gmail_msg">
[5] can land undisturbed. After that, a double revert will be applied,<br class="m_-5667082290560685121m_-7455954948602079198m_-8602721088003730304gmail_msg">
once subprojects have had the opportunity to deal with the aftermath of<br class="m_-5667082290560685121m_-7455954948602079198m_-8602721088003730304gmail_msg">
the other breaking change [1,2] (e.g. [6,7]).<br class="m_-5667082290560685121m_-7455954948602079198m_-8602721088003730304gmail_msg">
<br class="m_-5667082290560685121m_-7455954948602079198m_-8602721088003730304gmail_msg">
 From now on, I'd strongly encourage people proposing/reviewing patches<br class="m_-5667082290560685121m_-7455954948602079198m_-8602721088003730304gmail_msg">
with potential impact (any impact) to err on the side of caution, and<br class="m_-5667082290560685121m_-7455954948602079198m_-8602721088003730304gmail_msg">
take the advised steps to ensure such situations don't happen in the future.<br class="m_-5667082290560685121m_-7455954948602079198m_-8602721088003730304gmail_msg">
<br class="m_-5667082290560685121m_-7455954948602079198m_-8602721088003730304gmail_msg">
Thanks,<br class="m_-5667082290560685121m_-7455954948602079198m_-8602721088003730304gmail_msg">
Armando<br class="m_-5667082290560685121m_-7455954948602079198m_-8602721088003730304gmail_msg">
<br class="m_-5667082290560685121m_-7455954948602079198m_-8602721088003730304gmail_msg">
[1] <a href="https://review.openstack.org/#/c/397704/" rel="noreferrer" class="m_-5667082290560685121m_-7455954948602079198m_-8602721088003730304gmail_msg" target="_blank">https://review.openstack.org/#<wbr>/c/397704/</a><br class="m_-5667082290560685121m_-7455954948602079198m_-8602721088003730304gmail_msg">
[2] <a href="https://review.openstack.org/#/c/397037/" rel="noreferrer" class="m_-5667082290560685121m_-7455954948602079198m_-8602721088003730304gmail_msg" target="_blank">https://review.openstack.org/#<wbr>/c/397037/</a><br class="m_-5667082290560685121m_-7455954948602079198m_-8602721088003730304gmail_msg">
[3] <a href="https://review.openstack.org/#/c/386845/" rel="noreferrer" class="m_-5667082290560685121m_-7455954948602079198m_-8602721088003730304gmail_msg" target="_blank">https://review.openstack.org/#<wbr>/c/386845/</a><br class="m_-5667082290560685121m_-7455954948602079198m_-8602721088003730304gmail_msg">
[4] <a href="https://review.openstack.org/#/c/401377/" rel="noreferrer" class="m_-5667082290560685121m_-7455954948602079198m_-8602721088003730304gmail_msg" target="_blank">https://review.openstack.org/#<wbr>/c/401377/</a><br class="m_-5667082290560685121m_-7455954948602079198m_-8602721088003730304gmail_msg">
[5] <a href="https://review.openstack.org/#/q/topic:plugin-directory+status:open" rel="noreferrer" class="m_-5667082290560685121m_-7455954948602079198m_-8602721088003730304gmail_msg" target="_blank">https://review.openstack.org/#<wbr>/q/topic:plugin-directory+stat<wbr>us:open</a><br class="m_-5667082290560685121m_-7455954948602079198m_-8602721088003730304gmail_msg">
[6] <a href="https://review.openstack.org/#/c/401263/" rel="noreferrer" class="m_-5667082290560685121m_-7455954948602079198m_-8602721088003730304gmail_msg" target="_blank">https://review.openstack.org/#<wbr>/c/401263/</a><br class="m_-5667082290560685121m_-7455954948602079198m_-8602721088003730304gmail_msg">
[7] <a href="https://review.openstack.org/#/c/401355/" rel="noreferrer" class="m_-5667082290560685121m_-7455954948602079198m_-8602721088003730304gmail_msg" target="_blank">https://review.openstack.org/#<wbr>/c/401355/</a><br class="m_-5667082290560685121m_-7455954948602079198m_-8602721088003730304gmail_msg">
<br class="m_-5667082290560685121m_-7455954948602079198m_-8602721088003730304gmail_msg">
<br class="m_-5667082290560685121m_-7455954948602079198m_-8602721088003730304gmail_msg">
______________________________<wbr>______________________________<wbr>______________<br class="m_-5667082290560685121m_-7455954948602079198m_-8602721088003730304gmail_msg">
OpenStack Development Mailing List (not for usage questions)<br class="m_-5667082290560685121m_-7455954948602079198m_-8602721088003730304gmail_msg">
Unsubscribe: <a href="http://OpenStack-dev-request@lists.openstack.org?subject:unsubscribe" rel="noreferrer" class="m_-5667082290560685121m_-7455954948602079198m_-8602721088003730304gmail_msg" target="_blank">OpenStack-dev-request@lists.op<wbr>enstack.org?subject:unsubscrib<wbr>e</a><br class="m_-5667082290560685121m_-7455954948602079198m_-8602721088003730304gmail_msg">
<a href="http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev" rel="noreferrer" class="m_-5667082290560685121m_-7455954948602079198m_-8602721088003730304gmail_msg" target="_blank">http://lists.openstack.org/cgi<wbr>-bin/mailman/listinfo/openstac<wbr>k-dev</a><br class="m_-5667082290560685121m_-7455954948602079198m_-8602721088003730304gmail_msg">
<br class="m_-5667082290560685121m_-7455954948602079198m_-8602721088003730304gmail_msg">
</blockquote>
<br class="m_-5667082290560685121m_-7455954948602079198m_-8602721088003730304gmail_msg">
______________________________<wbr>______________________________<wbr>______________<br class="m_-5667082290560685121m_-7455954948602079198m_-8602721088003730304gmail_msg">
OpenStack Development Mailing List (not for usage questions)<br class="m_-5667082290560685121m_-7455954948602079198m_-8602721088003730304gmail_msg">
Unsubscribe: <a href="http://OpenStack-dev-request@lists.openstack.org?subject:unsubscribe" rel="noreferrer" class="m_-5667082290560685121m_-7455954948602079198m_-8602721088003730304gmail_msg" target="_blank">OpenStack-dev-request@lists.op<wbr>enstack.org?subject:unsubscrib<wbr>e</a><br class="m_-5667082290560685121m_-7455954948602079198m_-8602721088003730304gmail_msg">
<a href="http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev" rel="noreferrer" class="m_-5667082290560685121m_-7455954948602079198m_-8602721088003730304gmail_msg" target="_blank">http://lists.openstack.org/cgi<wbr>-bin/mailman/listinfo/openstac<wbr>k-dev</a><br class="m_-5667082290560685121m_-7455954948602079198m_-8602721088003730304gmail_msg">
</blockquote>
<br class="m_-5667082290560685121m_-7455954948602079198m_-8602721088003730304gmail_msg">
______________________________<wbr>______________________________<wbr>______________<br class="m_-5667082290560685121m_-7455954948602079198m_-8602721088003730304gmail_msg">
OpenStack Development Mailing List (not for usage questions)<br class="m_-5667082290560685121m_-7455954948602079198m_-8602721088003730304gmail_msg">
Unsubscribe: <a href="http://OpenStack-dev-request@lists.openstack.org?subject:unsubscribe" rel="noreferrer" class="m_-5667082290560685121m_-7455954948602079198m_-8602721088003730304gmail_msg" target="_blank">OpenStack-dev-request@lists.op<wbr>enstack.org?subject:unsubscrib<wbr>e</a><br class="m_-5667082290560685121m_-7455954948602079198m_-8602721088003730304gmail_msg">
<a href="http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev" rel="noreferrer" class="m_-5667082290560685121m_-7455954948602079198m_-8602721088003730304gmail_msg" target="_blank">http://lists.openstack.org/cgi<wbr>-bin/mailman/listinfo/openstac<wbr>k-dev</a><br class="m_-5667082290560685121m_-7455954948602079198m_-8602721088003730304gmail_msg">
</div></div></blockquote></div><br class="m_-5667082290560685121m_-7455954948602079198m_-8602721088003730304gmail_msg"></div>
______________________________<wbr>______________________________<wbr>______________<br class="m_-5667082290560685121m_-7455954948602079198m_-8602721088003730304gmail_msg">
OpenStack Development Mailing List (not for usage questions)<br class="m_-5667082290560685121m_-7455954948602079198m_-8602721088003730304gmail_msg">
Unsubscribe: <a href="http://OpenStack-dev-request@lists.openstack.org?subject:unsubscribe" rel="noreferrer" class="m_-5667082290560685121m_-7455954948602079198m_-8602721088003730304gmail_msg" target="_blank">OpenStack-dev-request@lists.op<wbr>enstack.org?subject:unsubscrib<wbr>e</a><br class="m_-5667082290560685121m_-7455954948602079198m_-8602721088003730304gmail_msg">
<a href="http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev" rel="noreferrer" class="m_-5667082290560685121m_-7455954948602079198m_-8602721088003730304gmail_msg" target="_blank">http://lists.openstack.org/cgi<wbr>-bin/mailman/listinfo/openstac<wbr>k-dev</a><br class="m_-5667082290560685121m_-7455954948602079198m_-8602721088003730304gmail_msg">
</blockquote></div></div></div></div></div>
<br>______________________________<wbr>______________________________<wbr>______________<br>
OpenStack Development Mailing List (not for usage questions)<br>
Unsubscribe: <a href="http://OpenStack-dev-request@lists.openstack.org?subject:unsubscribe" rel="noreferrer" target="_blank">OpenStack-dev-request@lists.op<wbr>enstack.org?subject:unsubscrib<wbr>e</a><br>
<a href="http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev" rel="noreferrer" target="_blank">http://lists.openstack.org/cgi<wbr>-bin/mailman/listinfo/openstac<wbr>k-dev</a><br>
<br></blockquote></div><br></div></div>
<br>______________________________<wbr>______________________________<wbr>______________<br>
OpenStack Development Mailing List (not for usage questions)<br>
Unsubscribe: <a href="http://OpenStack-dev-request@lists.openstack.org?subject:unsubscribe" rel="noreferrer" target="_blank">OpenStack-dev-request@lists.op<wbr>enstack.org?subject:unsubscrib<wbr>e</a><br>
<a href="http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev" rel="noreferrer" target="_blank">http://lists.openstack.org/cgi<wbr>-bin/mailman/listinfo/openstac<wbr>k-dev</a><br>
<br></blockquote></div></div>
</div></div><br>______________________________<wbr>______________________________<wbr>______________<br>
OpenStack Development Mailing List (not for usage questions)<br>
Unsubscribe: <a href="http://OpenStack-dev-request@lists.openstack.org?subject:unsubscribe" rel="noreferrer" target="_blank">OpenStack-dev-request@lists.<wbr>openstack.org?subject:<wbr>unsubscribe</a><br>
<a href="http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev" rel="noreferrer" target="_blank">http://lists.openstack.org/<wbr>cgi-bin/mailman/listinfo/<wbr>openstack-dev</a><br>
<br></blockquote></div><br></div></div>