<div dir="ltr"><div><br></div>+1<br><br></div><div class="gmail_extra"><br><div class="gmail_quote">2016-11-04 13:32 GMT+00:00 Jeffrey Zhang <span dir="ltr"><<a href="mailto:zhang.lei.fly@gmail.com" target="_blank">zhang.lei.fly@gmail.com</a>></span>:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div dir="ltr"><div class="gmail_default" style="font-family:monospace,monospace;font-size:small">+1</div></div><div class="gmail_extra"><div><div class="h5"><br><div class="gmail_quote">On Fri, Nov 4, 2016 at 8:51 PM, Ryan Hallisey <span dir="ltr"><<a href="mailto:rhallise@redhat.com" target="_blank">rhallise@redhat.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">+1<br>
<span class="m_7220038011567078366HOEnZb"><font color="#888888"><br>
-Ryan<br>
</font></span><div class="m_7220038011567078366HOEnZb"><div class="m_7220038011567078366h5"><br>
----- Original Message -----<br>
From: "Swapnil Kulkarni" <<a href="mailto:coolsvap@gmail.com" target="_blank">coolsvap@gmail.com</a>><br>
To: "OpenStack Development Mailing List (not for usage questions)" <<a href="mailto:openstack-dev@lists.openstack.org" target="_blank">openstack-dev@lists.openstack<wbr>.org</a>><br>
Sent: Friday, November 4, 2016 8:48:49 AM<br>
Subject: Re: [openstack-dev] [kolla] Propose removal of TrivialFix      requirement<br>
<br>
On Thu, Nov 3, 2016 at 6:51 PM, Paul Bourke <<a href="mailto:paul.bourke@oracle.com" target="_blank">paul.bourke@oracle.com</a>> wrote:<br>
> Kolleagues,<br>
><br>
> How do people feel above removing the requirement of having TrivialFix in<br>
> commit messages where a bug/bp is not required?<br>
><br>
> I'm seeing a lot of valid and important commits being held up because of<br>
> this, in my opinion, unnecessary requirement. It also causes friction for<br>
> new contributers to the project.<br>
><br>
> Are there any major benefits we're getting from the use of this tag that I'm<br>
> missing?<br>
><br>
> Cheers,<br>
> -Paul<br>
><br>
> ______________________________<wbr>______________________________<wbr>______________<br>
> OpenStack Development Mailing List (not for usage questions)<br>
> Unsubscribe: <a href="http://OpenStack-dev-request@lists.openstack.org?subject:unsubscribe" rel="noreferrer" target="_blank">OpenStack-dev-request@lists.op<wbr>enstack.org?subject:unsubscrib<wbr>e</a><br>
> <a href="http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev" rel="noreferrer" target="_blank">http://lists.openstack.org/cgi<wbr>-bin/mailman/listinfo/openstac<wbr>k-dev</a><br>
<br>
I feel TrivialFix is consistently used by people just to avoid going<br>
to lanuchpad and filing a bug. It should only be used only if the "Fix<br>
is Trivial"<br>
This has been well documented in the contributing doc [1] and this<br>
should be referred to people when they do not have the bug/bp in the<br>
commit message.<br>
<br>
If the commits are important then there is no harm in creating a<br>
tracking bug for it.<br>
It would take 1/30(I am just making highest time for a build/deploy<br>
gate) amount of time you need to verify the (important)fix on gate.<br>
<br>
[1] <a href="http://docs.openstack.org/developer/kolla/CONTRIBUTING.html" rel="noreferrer" target="_blank">docs.openstack.org/developer/k<wbr>olla/CONTRIBUTING.html</a><br>
<br>
______________________________<wbr>______________________________<wbr>______________<br>
OpenStack Development Mailing List (not for usage questions)<br>
Unsubscribe: <a href="http://OpenStack-dev-request@lists.openstack.org?subject:unsubscribe" rel="noreferrer" target="_blank">OpenStack-dev-request@lists.op<wbr>enstack.org?subject:unsubscrib<wbr>e</a><br>
<a href="http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev" rel="noreferrer" target="_blank">http://lists.openstack.org/cgi<wbr>-bin/mailman/listinfo/openstac<wbr>k-dev</a><br>
<br>
______________________________<wbr>______________________________<wbr>______________<br>
OpenStack Development Mailing List (not for usage questions)<br>
Unsubscribe: <a href="http://OpenStack-dev-request@lists.openstack.org?subject:unsubscribe" rel="noreferrer" target="_blank">OpenStack-dev-request@lists.op<wbr>enstack.org?subject:unsubscrib<wbr>e</a><br>
<a href="http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev" rel="noreferrer" target="_blank">http://lists.openstack.org/cgi<wbr>-bin/mailman/listinfo/openstac<wbr>k-dev</a><br>
</div></div></blockquote></div><br><br clear="all"><div><br></div></div></div><span class="HOEnZb"><font color="#888888">-- <br><div class="m_7220038011567078366gmail_signature" data-smartmail="gmail_signature"><div dir="ltr"><div><div dir="ltr"><div><div dir="ltr"><div dir="ltr"><div dir="ltr"><div><span style="font-size:13px;border-collapse:collapse"><font face="monospace, monospace">Regards,</font></span></div><div><span style="font-size:13px;border-collapse:collapse"><font face="monospace, monospace">Jeffrey Zhang</font></span></div><div><span style="font-family:monospace,monospace;font-size:12.8px">Blog: </span><a href="http://xcodest.me/" style="font-family:monospace,monospace;font-size:12.8px" target="_blank">http://xcodest.me</a><font face="monospace, monospace"><br></font></div></div></div></div></div></div></div></div></div>
</font></span></div>
<br>______________________________<wbr>______________________________<wbr>______________<br>
OpenStack Development Mailing List (not for usage questions)<br>
Unsubscribe: <a href="http://OpenStack-dev-request@lists.openstack.org?subject:unsubscribe" rel="noreferrer" target="_blank">OpenStack-dev-request@lists.<wbr>openstack.org?subject:<wbr>unsubscribe</a><br>
<a href="http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev" rel="noreferrer" target="_blank">http://lists.openstack.org/<wbr>cgi-bin/mailman/listinfo/<wbr>openstack-dev</a><br>
<br></blockquote></div><br></div>