<html>
<head>
<meta http-equiv="Content-Type" content="text/html; charset=us-ascii">
</head>
<body style="word-wrap: break-word; -webkit-nbsp-mode: space; -webkit-line-break: after-white-space;" class="">
Not much to add here - I commented in <a href="http://review.openstack.org/378063" class="">
review.openstack.org/378063</a><br class="">
that they could set the default value of the flag to revert behaviour.
<div class="">- Matt<br class="">
<br class="">
<div>
<blockquote type="cite" class="">
<div class="">On Oct 11, 2016, at 10:21 PM, Armando M. <<a href="mailto:armamig@gmail.com" class="">armamig@gmail.com</a>> wrote:</div>
<br class="Apple-interchange-newline">
<div class="">
<div dir="ltr" class=""><br class="">
<div class="gmail_extra"><br class="">
<div class="gmail_quote">On 11 October 2016 at 18:20, Sean M. Collins <span dir="ltr" class="">
<<a href="mailto:sean@coreitpro.com" target="_blank" class="">sean@coreitpro.com</a>></span> wrote:<br class="">
<blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">
<span class="m_6194907186085188377gmail-">Armando M. wrote:<br class="">
> At this point I feel that changing the pool range is even less justified.<br class="">
> If I had seen bug [4], I would have been against its fix, because you're<br class="">
> absolutely right as the change being not backward compatible.<br class="">
<br class="">
</span><a href="https://review.openstack.org/#/c/356026" rel="noreferrer" target="_blank" class="">https://review.openstack.org/#<wbr class="">/c/356026</a> was written by someone on the Trove team to<br class="">
help them with their CI jobs IIRC.<br class="">
<br class="">
CC'ing Matthew since he has more context. I went into the Trove channel<br class="">
and asked them about reverting 356026. It doesn't seem like an option at<br class="">
this point.<br class="">
<br class="">
<a href="http://eavesdrop.openstack.org/irclogs/%23openstack-trove/%23openstack-trove.2016-09-30.log.html#t2016-09-30T17:53:08" rel="noreferrer" target="_blank" class="">http://eavesdrop.openstack.org<wbr class="">/irclogs/%23openstack-trove/%<wbr class="">23openstack-trove.2016-09-30.<wbr class="">log.html#t2016-09-30T17:53:08</a></blockquote>
<div class=""><br class="">
</div>
<div class="">A revert with no follow up is clearly not a viable option most of the times, and we clearly dug ourselves too deep now with [1]. Rather than making the use of subnet pools conditional as done in [1], IMO we should have made [2] conditional to
preserve the existing provisioning behavior and let Trove override.</div>
<div class=""><br class="">
</div>
[1] Ic89ceca76afda67da5545111972c3<wbr class="">348011f294f</div>
<div class="gmail_quote">[2] <a href="https://review.openstack.org/#/c/356026/" target="_blank" class="">https://review.openstack.<wbr class="">org/#/c/356026/</a></div>
<div class="gmail_quote"><br class="">
<blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">
<br class="">
<span class="m_6194907186085188377gmail-HOEnZb"><font color="#888888" class=""><br class="">
<br class="">
--<br class="">
Sean M. Collins<br class="">
</font></span>
<div class="m_6194907186085188377gmail-HOEnZb">
<div class="m_6194907186085188377gmail-h5"><br class="">
______________________________<wbr class="">______________________________<wbr class="">______________<br class="">
OpenStack Development Mailing List (not for usage questions)<br class="">
Unsubscribe: <a href="http://OpenStack-dev-request@lists.openstack.org/?subject:unsubscribe" rel="noreferrer" target="_blank" class="">
OpenStack-dev-request@lists.op<wbr class="">enstack.org?subject:unsubscrib<wbr class="">e</a><br class="">
<a href="http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev" rel="noreferrer" target="_blank" class="">http://lists.openstack.org/cgi<wbr class="">-bin/mailman/listinfo/openstac<wbr class="">k-dev</a><br class="">
</div>
</div>
</blockquote>
</div>
<br class="">
</div>
</div>
</div>
</blockquote>
</div>
<br class="">
</div>
</body>
</html>