<html xmlns:v="urn:schemas-microsoft-com:vml" xmlns:o="urn:schemas-microsoft-com:office:office" xmlns:w="urn:schemas-microsoft-com:office:word" xmlns:m="http://schemas.microsoft.com/office/2004/12/omml" xmlns="http://www.w3.org/TR/REC-html40">
<head>
<meta http-equiv="Content-Type" content="text/html; charset=us-ascii">
<meta name="Generator" content="Microsoft Word 15 (filtered medium)">
<style><!--
/* Font Definitions */
@font-face
{font-family:Wingdings;
panose-1:5 0 0 0 0 0 0 0 0 0;}
@font-face
{font-family:"Cambria Math";
panose-1:2 4 5 3 5 4 6 3 2 4;}
@font-face
{font-family:Calibri;
panose-1:2 15 5 2 2 2 4 3 2 4;}
@font-face
{font-family:Consolas;
panose-1:2 11 6 9 2 2 4 3 2 4;}
/* Style Definitions */
p.MsoNormal, li.MsoNormal, div.MsoNormal
{margin:0in;
margin-bottom:.0001pt;
font-size:11.0pt;
font-family:"Calibri",sans-serif;}
a:link, span.MsoHyperlink
{mso-style-priority:99;
color:#0563C1;
text-decoration:underline;}
a:visited, span.MsoHyperlinkFollowed
{mso-style-priority:99;
color:#954F72;
text-decoration:underline;}
p.MsoPlainText, li.MsoPlainText, div.MsoPlainText
{mso-style-priority:99;
mso-style-link:"Plain Text Char";
margin:0in;
margin-bottom:.0001pt;
font-size:11.0pt;
font-family:Consolas;}
span.PlainTextChar
{mso-style-name:"Plain Text Char";
mso-style-priority:99;
mso-style-link:"Plain Text";
font-family:Consolas;}
.MsoChpDefault
{mso-style-type:export-only;
font-family:"Calibri",sans-serif;}
@page WordSection1
{size:8.5in 11.0in;
margin:1.0in 1.0in 1.0in 1.0in;}
div.WordSection1
{page:WordSection1;}
/* List Definitions */
@list l0
{mso-list-id:1016926128;
mso-list-type:hybrid;
mso-list-template-ids:-1247880212 -65105594 67698691 67698693 67698689 67698691 67698693 67698689 67698691 67698693;}
@list l0:level1
{mso-level-number-format:bullet;
mso-level-text:-;
mso-level-tab-stop:none;
mso-level-number-position:left;
text-indent:-.25in;
font-family:Consolas;
mso-fareast-font-family:Calibri;}
@list l0:level2
{mso-level-number-format:bullet;
mso-level-text:o;
mso-level-tab-stop:none;
mso-level-number-position:left;
text-indent:-.25in;
font-family:"Courier New";}
@list l0:level3
{mso-level-number-format:bullet;
mso-level-text:\F0A7;
mso-level-tab-stop:none;
mso-level-number-position:left;
text-indent:-.25in;
font-family:Wingdings;}
@list l0:level4
{mso-level-number-format:bullet;
mso-level-text:\F0B7;
mso-level-tab-stop:none;
mso-level-number-position:left;
text-indent:-.25in;
font-family:Symbol;}
@list l0:level5
{mso-level-number-format:bullet;
mso-level-text:o;
mso-level-tab-stop:none;
mso-level-number-position:left;
text-indent:-.25in;
font-family:"Courier New";}
@list l0:level6
{mso-level-number-format:bullet;
mso-level-text:\F0A7;
mso-level-tab-stop:none;
mso-level-number-position:left;
text-indent:-.25in;
font-family:Wingdings;}
@list l0:level7
{mso-level-number-format:bullet;
mso-level-text:\F0B7;
mso-level-tab-stop:none;
mso-level-number-position:left;
text-indent:-.25in;
font-family:Symbol;}
@list l0:level8
{mso-level-number-format:bullet;
mso-level-text:o;
mso-level-tab-stop:none;
mso-level-number-position:left;
text-indent:-.25in;
font-family:"Courier New";}
@list l0:level9
{mso-level-number-format:bullet;
mso-level-text:\F0A7;
mso-level-tab-stop:none;
mso-level-number-position:left;
text-indent:-.25in;
font-family:Wingdings;}
@list l1
{mso-list-id:1413089439;
mso-list-type:hybrid;
mso-list-template-ids:-1230213128 67698689 67698691 67698693 67698689 67698691 67698693 67698689 67698691 67698693;}
@list l1:level1
{mso-level-number-format:bullet;
mso-level-text:\F0B7;
mso-level-tab-stop:none;
mso-level-number-position:left;
text-indent:-.25in;
font-family:Symbol;}
@list l1:level2
{mso-level-number-format:bullet;
mso-level-text:o;
mso-level-tab-stop:none;
mso-level-number-position:left;
text-indent:-.25in;
font-family:"Courier New";}
@list l1:level3
{mso-level-number-format:bullet;
mso-level-text:\F0A7;
mso-level-tab-stop:none;
mso-level-number-position:left;
text-indent:-.25in;
font-family:Wingdings;}
@list l1:level4
{mso-level-number-format:bullet;
mso-level-text:\F0B7;
mso-level-tab-stop:none;
mso-level-number-position:left;
text-indent:-.25in;
font-family:Symbol;}
@list l1:level5
{mso-level-number-format:bullet;
mso-level-text:o;
mso-level-tab-stop:none;
mso-level-number-position:left;
text-indent:-.25in;
font-family:"Courier New";}
@list l1:level6
{mso-level-number-format:bullet;
mso-level-text:\F0A7;
mso-level-tab-stop:none;
mso-level-number-position:left;
text-indent:-.25in;
font-family:Wingdings;}
@list l1:level7
{mso-level-number-format:bullet;
mso-level-text:\F0B7;
mso-level-tab-stop:none;
mso-level-number-position:left;
text-indent:-.25in;
font-family:Symbol;}
@list l1:level8
{mso-level-number-format:bullet;
mso-level-text:o;
mso-level-tab-stop:none;
mso-level-number-position:left;
text-indent:-.25in;
font-family:"Courier New";}
@list l1:level9
{mso-level-number-format:bullet;
mso-level-text:\F0A7;
mso-level-tab-stop:none;
mso-level-number-position:left;
text-indent:-.25in;
font-family:Wingdings;}
ol
{margin-bottom:0in;}
ul
{margin-bottom:0in;}
--></style><!--[if gte mso 9]><xml>
<o:shapedefaults v:ext="edit" spidmax="1026" />
</xml><![endif]--><!--[if gte mso 9]><xml>
<o:shapelayout v:ext="edit">
<o:idmap v:ext="edit" data="1" />
</o:shapelayout></xml><![endif]-->
</head>
<body lang="EN-US" link="#0563C1" vlink="#954F72">
<div class="WordSection1">
<p class="MsoPlainText"><font size="2" face="Consolas"><span style="font-size:11.0pt">Of late I've been seeing a lot of rather questionable changes that appear to be getting blasted out across multiple projects; changes that cause considerable code churn, and
don't (IMHO) materially improve the quality of OpenStack.<o:p></o:p></span></font></p>
<p class="MsoPlainText"><font size="2" face="Consolas"><span style="font-size:11.0pt">I’d love to provide a list of the changes that triggered this email but I know that this will result in a rat hole where we end up discussing the merits of the individual
items on the list and lose sight of the bigger picture. That won’t help address the question I have below in any way, so I’m at a disadvantage of having to describe my issue in abstract terms.<o:p></o:p></span></font></p>
<p class="MsoPlainText"><font size="2" face="Consolas"><o:p> </o:p></font></p>
<p class="MsoPlainText"><font size="2" face="Consolas"><span style="font-size:11.0pt">Here’s how I characterize these changes (changes that meet one or more of these criteria):<o:p></o:p></span></font></p>
<p class="MsoPlainText"><font size="2" face="Consolas"><o:p> </o:p></font></p>
<p class="MsoPlainText" style="margin-left:.5in;text-indent:-.25in;mso-list:l0 level1 lfo2">
<![if !supportLists]><font size="2" face="Consolas"><span style="font-size:11.0pt"><span style="mso-list:Ignore">-<font size="1" face="Times New Roman"><span style="font:7.0pt "Times New Roman"">
</span></font></span></span></font><![endif]>Contains little of no information in the commit message (often just a single line)<o:p></o:p></p>
<p class="MsoPlainText" style="margin-left:.5in;text-indent:-.25in;mso-list:l0 level1 lfo2">
<![if !supportLists]><font size="2" face="Consolas"><span style="font-size:11.0pt"><span style="mso-list:Ignore">-<font size="1" face="Times New Roman"><span style="font:7.0pt "Times New Roman"">
</span></font></span></span></font><![endif]>Makes some generic statement like “Do X not Y”, “Don’t use Z”, “Make ABC better” with no further supporting information<o:p></o:p></p>
<p class="MsoPlainText" style="margin-left:.5in;text-indent:-.25in;mso-list:l0 level1 lfo2">
<![if !supportLists]><font size="2" face="Consolas"><span style="font-size:11.0pt"><span style="mso-list:Ignore">-<font size="1" face="Times New Roman"><span style="font:7.0pt "Times New Roman"">
</span></font></span></span></font><![endif]>Fail (literally) every single CI job, clearly never tested by the developer<o:p></o:p></p>
<p class="MsoPlainText" style="margin-left:.5in;text-indent:-.25in;mso-list:l0 level1 lfo2">
<![if !supportLists]><font size="2" face="Consolas"><span style="font-size:11.0pt"><span style="mso-list:Ignore">-<font size="1" face="Times New Roman"><span style="font:7.0pt "Times New Roman"">
</span></font></span></span></font><![endif]>Gets blasted across many projects, literally tens with often the same kind of questionable (often wrong) change<o:p></o:p></p>
<p class="MsoPlainText" style="margin-left:.5in;text-indent:-.25in;mso-list:l0 level1 lfo2">
<![if !supportLists]><font size="2" face="Consolas"><span style="font-size:11.0pt"><span style="mso-list:Ignore">-<font size="1" face="Times New Roman"><span style="font:7.0pt "Times New Roman"">
</span></font></span></span></font><![endif]>Makes a stylistic python improvement that is not enforced by any check (causes a cottage industry of changes making the same correction every couple of months)<o:p></o:p></p>
<p class="MsoPlainText" style="margin-left:.5in;text-indent:-.25in;mso-list:l0 level1 lfo2">
<![if !supportLists]><font size="2" face="Consolas"><span style="font-size:11.0pt"><span style="mso-list:Ignore">-<font size="1" face="Times New Roman"><span style="font:7.0pt "Times New Roman"">
</span></font></span></span></font><![endif]>Reverses some previous python stylistic improvement with no clear reason (another cottage industry)<o:p></o:p></p>
<p class="MsoPlainText"><font size="2" face="Consolas"><o:p> </o:p></font></p>
<p class="MsoPlainText"><font size="2" face="Consolas"><span style="font-size:11.0pt">I’ve tried to explain it to myself as enthusiasm, and a desire to contribute aggressively; I’ve lapsed into cynicism at times and tried to explain it as gaming the numbers
system, but all that is merely rationalization and doesn’t help.<o:p></o:p></span></font></p>
<p class="MsoPlainText"><font size="2" face="Consolas"><o:p> </o:p></font></p>
<p class="MsoPlainText"><font size="2" face="Consolas"><span style="font-size:11.0pt">Over time, the result generally is that these developers’ changes get ignored. And that’s not a good thing for the community as a whole. We want to be a welcoming community
and one which values all contributions so I’m looking for some suggestions and guidance on how one can work with contributors to try and improve the quality of these changes, and help the contributor feel that their changes are valued by the project? Other
more experienced PTL’s, ex-PTL’s, long time open-source-community folks, I’m seriously looking for suggestions and ideas.<o:p></o:p></span></font></p>
<p class="MsoPlainText"><font size="2" face="Consolas"><o:p> </o:p></font></p>
<p class="MsoPlainText"><font size="2" face="Consolas"><span style="font-size:11.0pt">Any and all input is welcome, do other projects see this, how do you handle it, is this normal, …<o:p></o:p></span></font></p>
<p class="MsoPlainText"><font size="2" face="Consolas"><o:p> </o:p></font></p>
<p class="MsoPlainText"><font size="2" face="Consolas"><span style="font-size:11.0pt">Thanks!<o:p></o:p></span></font></p>
<p class="MsoPlainText"><font size="2" face="Consolas"><o:p> </o:p></font></p>
<p class="MsoPlainText"><font size="2" face="Consolas"><span style="font-size:11.0pt">-amrith<o:p></o:p></span></font></p>
<p class="MsoPlainText"><font size="2" face="Consolas"><o:p> </o:p></font></p>
<p class="MsoPlainText"><font size="2" face="Consolas"><o:p> </o:p></font></p>
<p class="MsoPlainText"><font size="2" face="Consolas"><o:p> </o:p></font></p>
<p class="MsoPlainText"><font size="2" face="Consolas"><o:p> </o:p></font></p>
</div>
</body>
</html>