<div dir="ltr">Thanks everyone for the quick and positive responses.<div><br></div><div>I'm on PTO this week with limited internet access, so my replies may have some delays. Next week it will go back to normal. :-)</div><div><br></div><div>Cheers,</div><div>Gorka.</div></div><div class="gmail_extra"><br><div class="gmail_quote">On Mon, Sep 12, 2016 at 3:04 PM, Sean McGinnis <span dir="ltr"><<a href="mailto:sean.mcginnis@gmx.com" target="_blank">sean.mcginnis@gmx.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div class="HOEnZb"><div class="h5">On Mon, Sep 12, 2016 at 10:24:23AM +0200, Michał Dulko wrote:<br>
> +1, thanks for taking care of that!<br>
><br>
> On 09/12/2016 03:35 AM, Huang Zhiteng wrote:<br>
> > +1 for this long-waited feature to land in Newton.<br>
> ><br>
> > On Sun, Sep 11, 2016 at 1:09 AM, Jay S. Bryant<br>
> > <<a href="mailto:jsbryant@electronicjungle.net">jsbryant@electronicjungle.net</a> <mailto:<a href="mailto:jsbryant@electronicjungle.net">jsbryant@<wbr>electronicjungle.net</a>>><br>
> > wrote:<br>
> ><br>
> > +1 from me. It is making good progress and is low risk.<br>
> ><br>
> > -Jay<br>
> ><br>
> ><br>
> ><br>
> > On 09/09/2016 02:32 PM, Gorka Eguileor wrote:<br>
> ><br>
> > Hi,<br>
> ><br>
> > As some of you may know, Jon Bernard (jbernard on IRC) has<br>
> > been working<br>
> > on the RBD v2.1 replication implementation [1] for a while,<br>
> > and we would<br>
> > like to request a Feature Freeze Exception for that work, as<br>
> > we believe<br>
> > it is a good candidate being a low risk change for the<br>
> > integrity of<br>
> > the existing functionality in the driver:<br>
> ><br>
> > - It's non intrusive if it's not enabled (enabled using<br>
> > replication_device configuration option).<br>
> > - It doesn't affect existing deployments (disabled by default).<br>
> > - Changes are localized to the driver itself (rbd.py) and the<br>
> > driver<br>
> > unit tests file (test_rbd.py).<br>
<br>
</div></div>This looks fine to me. My only concern is the risk accepting it would<br>
introduce, but as you point out that risk is low and should be well<br>
contained. I think it should be fine to still get this in.<br>
<div class="HOEnZb"><div class="h5"><br>
<br>
> ><br>
> > Jon would have liked to make this request himself, but due to the<br>
> > untimely arrival of his newborn baby this is not possible.<br>
> ><br>
> > For obvious reasons Jon will not be available for a little<br>
> > while, but<br>
> > this will not be a problem, as I am well acquainted with the<br>
> > code -and<br>
> > I'll be able to reach Jon if necessary- and will be taking<br>
> > care of the<br>
> > final steps of the review process of his patch: replying to<br>
> > comments in<br>
> > a timely fashion, making changes to the code as required, and<br>
> > answering<br>
> > pings on IRC regarding the patch.<br>
> ><br>
> > Since some people may be interested in testing this<br>
> > functionality during<br>
> > the reviewing process -or just for fun- I'll be publishing a<br>
> > post with<br>
> > detailed explanation on how to deploy and test this feature as<br>
> > well as<br>
> > an automated way to deploy 2 Ceph clusters -linked to be<br>
> > mirroring one<br>
> > another-, and one devstack node with everything ready to test the<br>
> > functionality (configuration and keys for the Ceph clusters,<br>
> > cinder<br>
> > configuration, the latest upstream patch, and a volume type<br>
> > with the<br>
> > right configuration).<br>
> ><br>
> > Please, do not hesitate to ask if there are any questions to<br>
> > or concerns<br>
> > related to this request.<br>
> ><br>
> > Thank you for taking the time to evaluate this request.<br>
> ><br>
> > Cheers,<br>
> > Gorka.<br>
> ><br>
> > [1]: <a href="https://review.openstack.org/333565" rel="noreferrer" target="_blank">https://review.openstack.org/<wbr>333565</a><br>
> > <<a href="https://review.openstack.org/333565" rel="noreferrer" target="_blank">https://review.openstack.org/<wbr>333565</a>><br>
> ><br>
> > ______________________________<wbr>______________________________<wbr>______________<br>
> > OpenStack Development Mailing List (not for usage questions)<br>
> > Unsubscribe:<br>
> > <a href="http://OpenStack-dev-request@lists.openstack.org?subject:unsubscribe" rel="noreferrer" target="_blank">OpenStack-dev-request@lists.<wbr>openstack.org?subject:<wbr>unsubscribe</a><br>
> > <<a href="http://OpenStack-dev-request@lists.openstack.org?subject:unsubscribe" rel="noreferrer" target="_blank">http://OpenStack-dev-request@<wbr>lists.openstack.org?subject:<wbr>unsubscribe</a>><br>
> > <a href="http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev" rel="noreferrer" target="_blank">http://lists.openstack.org/<wbr>cgi-bin/mailman/listinfo/<wbr>openstack-dev</a><br>
> > <<a href="http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev" rel="noreferrer" target="_blank">http://lists.openstack.org/<wbr>cgi-bin/mailman/listinfo/<wbr>openstack-dev</a>><br>
> ><br>
> ><br>
> ><br>
> > ______________________________<wbr>______________________________<wbr>______________<br>
> > OpenStack Development Mailing List (not for usage questions)<br>
> > Unsubscribe:<br>
> > <a href="http://OpenStack-dev-request@lists.openstack.org?subject:unsubscribe" rel="noreferrer" target="_blank">OpenStack-dev-request@lists.<wbr>openstack.org?subject:<wbr>unsubscribe</a><br>
> > <<a href="http://OpenStack-dev-request@lists.openstack.org?subject:unsubscribe" rel="noreferrer" target="_blank">http://OpenStack-dev-request@<wbr>lists.openstack.org?subject:<wbr>unsubscribe</a>><br>
> > <a href="http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev" rel="noreferrer" target="_blank">http://lists.openstack.org/<wbr>cgi-bin/mailman/listinfo/<wbr>openstack-dev</a><br>
> > <<a href="http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev" rel="noreferrer" target="_blank">http://lists.openstack.org/<wbr>cgi-bin/mailman/listinfo/<wbr>openstack-dev</a>><br>
> ><br>
> ><br>
> ><br>
> ><br>
> > --<br>
> > Regards<br>
> > Huang Zhiteng<br>
> ><br>
> ><br>
> > ______________________________<wbr>______________________________<wbr>______________<br>
> > OpenStack Development Mailing List (not for usage questions)<br>
> > Unsubscribe: <a href="http://OpenStack-dev-request@lists.openstack.org?subject:unsubscribe" rel="noreferrer" target="_blank">OpenStack-dev-request@lists.<wbr>openstack.org?subject:<wbr>unsubscribe</a><br>
> > <a href="http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev" rel="noreferrer" target="_blank">http://lists.openstack.org/<wbr>cgi-bin/mailman/listinfo/<wbr>openstack-dev</a><br>
><br>
><br>
> ______________________________<wbr>______________________________<wbr>______________<br>
> OpenStack Development Mailing List (not for usage questions)<br>
> Unsubscribe: <a href="http://OpenStack-dev-request@lists.openstack.org?subject:unsubscribe" rel="noreferrer" target="_blank">OpenStack-dev-request@lists.<wbr>openstack.org?subject:<wbr>unsubscribe</a><br>
> <a href="http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev" rel="noreferrer" target="_blank">http://lists.openstack.org/<wbr>cgi-bin/mailman/listinfo/<wbr>openstack-dev</a><br>
<br>
______________________________<wbr>______________________________<wbr>______________<br>
OpenStack Development Mailing List (not for usage questions)<br>
Unsubscribe: <a href="http://OpenStack-dev-request@lists.openstack.org?subject:unsubscribe" rel="noreferrer" target="_blank">OpenStack-dev-request@lists.<wbr>openstack.org?subject:<wbr>unsubscribe</a><br>
<a href="http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev" rel="noreferrer" target="_blank">http://lists.openstack.org/<wbr>cgi-bin/mailman/listinfo/<wbr>openstack-dev</a><br>
</div></div></blockquote></div><br></div>