<div dir="ltr">I agree with Jeffrey.<br><div class="gmail_extra"><br><div class="gmail_quote">2016-09-02 11:52 GMT-03:00 Michał Jastrzębski <span dir="ltr"><<a href="mailto:inc007@gmail.com" target="_blank">inc007@gmail.com</a>></span>:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">+1 to Jeffrey's points. We should deprecate old footer mechanism and<br>
remove it alltogether in Ocata timeframe.<br>
<div class="HOEnZb"><div class="h5"><br>
On 1 September 2016 at 23:51, Jeffrey Zhang <<a href="mailto:zhang.lei.fly@gmail.com">zhang.lei.fly@gmail.com</a>> wrote:<br>
> 1. so i think we need add the deprecated status to the include_footer option<br>
> and print a warn.<br>
> 2. when the use specifies both two footers,  they should both work rather<br>
> than ignore one. it print warn already.<br>
><br>
> On Fri, Sep 2, 2016 at 11:42 AM, Swapnil Kulkarni <<a href="mailto:coolsvap@gmail.com">coolsvap@gmail.com</a>><br>
> wrote:<br>
>><br>
>> On Fri, Sep 2, 2016 at 8:32 AM, Jeffrey Zhang <<a href="mailto:zhang.lei.fly@gmail.com">zhang.lei.fly@gmail.com</a>><br>
>> wrote:<br>
>> > We introduced customization solution.<br>
>> ><br>
>> > Now, we support two format of footer.<br>
>> ><br>
>> > 1. the legacy way: {{ include_footer }}<br>
>> > 2. the new way: {% block footer %}{% endblock %}<br>
>> ><br>
>> > there two conflict about this now[0][1].<br>
>> ><br>
>> > I think the option 2 is better. We can get more consistent solution.<br>
>> ><br>
>> > [0] <a href="https://review.openstack.org/#/c/357746" rel="noreferrer" target="_blank">https://review.openstack.org/#<wbr>/c/357746</a><br>
>> > [1] <a href="https://review.openstack.org/#/c/361253" rel="noreferrer" target="_blank">https://review.openstack.org/#<wbr>/c/361253</a><br>
>> ><br>
>> > --<br>
>> > Regards,<br>
>> > Jeffrey Zhang<br>
>> > Blog: <a href="http://xcodest.me" rel="noreferrer" target="_blank">http://xcodest.me</a><br>
>> ><br>
>> ><br>
>> > ______________________________<wbr>______________________________<wbr>______________<br>
>> > OpenStack Development Mailing List (not for usage questions)<br>
>> > Unsubscribe:<br>
>> > <a href="http://OpenStack-dev-request@lists.openstack.org?subject:unsubscribe" rel="noreferrer" target="_blank">OpenStack-dev-request@lists.<wbr>openstack.org?subject:<wbr>unsubscribe</a><br>
>> > <a href="http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev" rel="noreferrer" target="_blank">http://lists.openstack.org/<wbr>cgi-bin/mailman/listinfo/<wbr>openstack-dev</a><br>
>> ><br>
>><br>
>><br>
>> I tend towards #2, patchset [0] is corresponding to a discussion on<br>
>> #openstack-kolla and if we keep #2, we need to keep #1 in all<br>
>> dockerfiles with a deprecation warning for next cycle.<br>
>><br>
>> Also what if user specifies both the footer blocks? We need to confirm<br>
>> we ignore  #1 if #2 is chosen.<br>
>><br>
>> ______________________________<wbr>______________________________<wbr>______________<br>
>> OpenStack Development Mailing List (not for usage questions)<br>
>> Unsubscribe: <a href="http://OpenStack-dev-request@lists.openstack.org?subject:unsubscribe" rel="noreferrer" target="_blank">OpenStack-dev-request@lists.<wbr>openstack.org?subject:<wbr>unsubscribe</a><br>
>> <a href="http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev" rel="noreferrer" target="_blank">http://lists.openstack.org/<wbr>cgi-bin/mailman/listinfo/<wbr>openstack-dev</a><br>
><br>
><br>
><br>
><br>
> --<br>
> Regards,<br>
> Jeffrey Zhang<br>
> Blog: <a href="http://xcodest.me" rel="noreferrer" target="_blank">http://xcodest.me</a><br>
><br>
> ______________________________<wbr>______________________________<wbr>______________<br>
> OpenStack Development Mailing List (not for usage questions)<br>
> Unsubscribe: <a href="http://OpenStack-dev-request@lists.openstack.org?subject:unsubscribe" rel="noreferrer" target="_blank">OpenStack-dev-request@lists.<wbr>openstack.org?subject:<wbr>unsubscribe</a><br>
> <a href="http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev" rel="noreferrer" target="_blank">http://lists.openstack.org/<wbr>cgi-bin/mailman/listinfo/<wbr>openstack-dev</a><br>
><br>
<br>
______________________________<wbr>______________________________<wbr>______________<br>
OpenStack Development Mailing List (not for usage questions)<br>
Unsubscribe: <a href="http://OpenStack-dev-request@lists.openstack.org?subject:unsubscribe" rel="noreferrer" target="_blank">OpenStack-dev-request@lists.<wbr>openstack.org?subject:<wbr>unsubscribe</a><br>
<a href="http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev" rel="noreferrer" target="_blank">http://lists.openstack.org/<wbr>cgi-bin/mailman/listinfo/<wbr>openstack-dev</a><br>
</div></div></blockquote></div><br></div></div>