<div dir="ltr"><div class="gmail_default" style="font-family:monospace,monospace;font-size:small">1. so i think we need add the deprecated status to the include_footer option and print a warn.</div><div class="gmail_default" style="font-family:monospace,monospace;font-size:small">2. when the use specifies both two footers,  they should both work rather than ignore one. it print warn already.</div></div><div class="gmail_extra"><br><div class="gmail_quote">On Fri, Sep 2, 2016 at 11:42 AM, Swapnil Kulkarni <span dir="ltr"><<a href="mailto:coolsvap@gmail.com" target="_blank">coolsvap@gmail.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div class="HOEnZb"><div class="h5">On Fri, Sep 2, 2016 at 8:32 AM, Jeffrey Zhang <<a href="mailto:zhang.lei.fly@gmail.com">zhang.lei.fly@gmail.com</a>> wrote:<br>
> We introduced customization solution.<br>
><br>
> Now, we support two format of footer.<br>
><br>
> 1. the legacy way: {{ include_footer }}<br>
> 2. the new way: {% block footer %}{% endblock %}<br>
><br>
> there two conflict about this now[0][1].<br>
><br>
> I think the option 2 is better. We can get more consistent solution.<br>
><br>
> [0] <a href="https://review.openstack.org/#/c/357746" rel="noreferrer" target="_blank">https://review.openstack.org/#<wbr>/c/357746</a><br>
> [1] <a href="https://review.openstack.org/#/c/361253" rel="noreferrer" target="_blank">https://review.openstack.org/#<wbr>/c/361253</a><br>
><br>
> --<br>
> Regards,<br>
> Jeffrey Zhang<br>
> Blog: <a href="http://xcodest.me" rel="noreferrer" target="_blank">http://xcodest.me</a><br>
><br>
</div></div>> ______________________________<wbr>______________________________<wbr>______________<br>
> OpenStack Development Mailing List (not for usage questions)<br>
> Unsubscribe: <a href="http://OpenStack-dev-request@lists.openstack.org?subject:unsubscribe" rel="noreferrer" target="_blank">OpenStack-dev-request@lists.<wbr>openstack.org?subject:<wbr>unsubscribe</a><br>
> <a href="http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev" rel="noreferrer" target="_blank">http://lists.openstack.org/<wbr>cgi-bin/mailman/listinfo/<wbr>openstack-dev</a><br>
><br>
<br>
<br>
I tend towards #2, patchset [0] is corresponding to a discussion on<br>
#openstack-kolla and if we keep #2, we need to keep #1 in all<br>
dockerfiles with a deprecation warning for next cycle.<br>
<br>
Also what if user specifies both the footer blocks? We need to confirm<br>
we ignore  #1 if #2 is chosen.<br>
<br>
______________________________<wbr>______________________________<wbr>______________<br>
OpenStack Development Mailing List (not for usage questions)<br>
Unsubscribe: <a href="http://OpenStack-dev-request@lists.openstack.org?subject:unsubscribe" rel="noreferrer" target="_blank">OpenStack-dev-request@lists.<wbr>openstack.org?subject:<wbr>unsubscribe</a><br>
<a href="http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev" rel="noreferrer" target="_blank">http://lists.openstack.org/<wbr>cgi-bin/mailman/listinfo/<wbr>openstack-dev</a><br>
</blockquote></div><br><br clear="all"><div><br></div>-- <br><div class="gmail_signature" data-smartmail="gmail_signature"><div dir="ltr"><div><div dir="ltr"><div><div dir="ltr"><div dir="ltr"><div dir="ltr"><div><span style="font-size:13px;border-collapse:collapse"><font face="monospace, monospace">Regards,</font></span></div><div><span style="font-size:13px;border-collapse:collapse"><font face="monospace, monospace">Jeffrey Zhang</font></span></div><div><span style="font-family:monospace,monospace;font-size:12.8px">Blog: </span><a href="http://xcodest.me/" style="font-family:monospace,monospace;font-size:12.8px" target="_blank">http://xcodest.me</a><font face="monospace, monospace"><br></font></div></div></div></div></div></div></div></div></div>
</div>