<div dir="ltr"><div>+1 </div><div>I think we have enough checks in Nova.</div></div><div class="gmail_extra"><br><div class="gmail_quote">2016-08-09 12:46 GMT+03:00 Moshe Levi <span dir="ltr"><<a href="mailto:moshele@mellanox.com" target="_blank">moshele@mellanox.com</a>></span>:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">This is the deprecation patch [2]<br>
<br>
[2] - <a href="https://review.openstack.org/#/c/352812/" rel="noreferrer" target="_blank">https://review.openstack.org/#<wbr>/c/352812/</a><br>
<span class="im HOEnZb"><br>
-----Original Message-----<br>
From: Moshe Levi [mailto:<a href="mailto:moshele@mellanox.com">moshele@mellanox.com</a>]<br>
</span><span class="im HOEnZb">Sent: Monday, August 08, 2016 3:43 PM<br>
To: OpenStack Development Mailing List (not for usage questions) (<a href="mailto:openstack-dev@lists.openstack.org">openstack-dev@lists.<wbr>openstack.org</a>) <<a href="mailto:openstack-dev@lists.openstack.org">openstack-dev@lists.<wbr>openstack.org</a>><br>
Subject: [openstack-dev] [neutron][nova][SR-IOV] deprecation of supported_pci_vendor_devs<br>
<br>
</span><div class="HOEnZb"><div class="h5">Hi all,<br>
<br>
To reduce complexity in configuring SR-IOV I want to deprecate the supported_pci_vendor_devs option [1] in the neutron-server ml2 config.<br>
This option is doing extra validation that pci vendor id and product id provided by nova in the neutron port binding profile is matching to the vendor id and product id  in supported_pci_vendor_devs.<br>
<br>
In my opinion this is redundant, nova-scheduler is the point to do validation and select a suitable hypervisor.<br>
The compute node is already validating this through the pci_passthrough_whitelist option in nova.conf [2].<br>
<br>
I don't see a reason why the neutron-server should validate the pci vendor_id and product_id again from the neutron port binding profile.<br>
<br>
If there is good reason to keep it please let me know, otherwise I will deprecate it.<br>
<br>
[1] - supported_pci_vendor_devs = ['15b3:1004', '8086:10ca'] [2] - pci_passthrough_whitelist = {"address":"*:06:00.*","<wbr>physical_network":"physnet1"}<br>
<br>
<br>
Thanks,<br>
Moshe<br>
<br>
______________________________<wbr>______________________________<wbr>______________<br>
OpenStack Development Mailing List (not for usage questions)<br>
Unsubscribe: <a href="http://OpenStack-dev-request@lists.openstack.org?subject:unsubscribe" rel="noreferrer" target="_blank">OpenStack-dev-request@lists.<wbr>openstack.org?subject:<wbr>unsubscribe</a><br>
<a href="http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev" rel="noreferrer" target="_blank">http://lists.openstack.org/<wbr>cgi-bin/mailman/listinfo/<wbr>openstack-dev</a><br>
<br>
______________________________<wbr>______________________________<wbr>______________<br>
OpenStack Development Mailing List (not for usage questions)<br>
Unsubscribe: <a href="http://OpenStack-dev-request@lists.openstack.org?subject:unsubscribe" rel="noreferrer" target="_blank">OpenStack-dev-request@lists.<wbr>openstack.org?subject:<wbr>unsubscribe</a><br>
<a href="http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev" rel="noreferrer" target="_blank">http://lists.openstack.org/<wbr>cgi-bin/mailman/listinfo/<wbr>openstack-dev</a><br>
</div></div></blockquote></div><br></div>