<p dir="ltr">Yep. Some tests are making sure there are no packets lost. Some are making sure that stuff starts working eventually. </p>
<div class="gmail_extra"><br><div class="gmail_quote">On Aug 4, 2016 12:28, "Brian Haley" <<a href="mailto:brian.haley@hpe.com">brian.haley@hpe.com</a>> wrote:<br type="attribution"><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">On 08/04/2016 03:16 PM, Rick Jones wrote:<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
On 08/04/2016 12:04 PM, Kevin Benton wrote:<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
Yeah, I wasn't thinking when I +2'ed that. There are two use cases for<br>
the pinger, one for ensuring continuous connectivity and one for<br>
eventual connectivity.<br>
<br>
I think the revert is okay for a quick fix, but we really need a new<br>
argument to the pinger for strictness to decide which behavior the test<br>
is looking for.<br>
</blockquote>
<br>
What situation requires continuous connectivity?<br>
</blockquote>
<br>
Maybe the test names can answer that:<br>
<br>
test_assert_pings_during_br_in<wbr>t_setup_not_lost()<br>
_test_assert_pings_during_br_p<wbr>hys_setup_not_lost()<br>
<br>
In other cases we want the previous behavior - is that IP alive?  It's probably just best to put the old code back and make a new assert_async_ping() based on this code.<br>
<br>
-Brian<br>
<br>
______________________________<wbr>______________________________<wbr>______________<br>
OpenStack Development Mailing List (not for usage questions)<br>
Unsubscribe: <a href="http://OpenStack-dev-request@lists.openstack.org?subject:unsubscribe" rel="noreferrer" target="_blank">OpenStack-dev-request@lists.op<wbr>enstack.org?subject:unsubscrib<wbr>e</a><br>
<a href="http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev" rel="noreferrer" target="_blank">http://lists.openstack.org/cgi<wbr>-bin/mailman/listinfo/openstac<wbr>k-dev</a><br>
</blockquote></div></div>