<html><head><meta http-equiv="Content-Type" content="text/html charset=us-ascii"></head><body style="word-wrap: break-word; -webkit-nbsp-mode: space; -webkit-line-break: after-white-space;" class="">Ok, based on what has been said here I suggest we keep this code for now. The changes were really minimal. If it creates some problems for us we can always easily revert.<div class=""><br class=""><div class="">
<div style="color: rgb(0, 0, 0); letter-spacing: normal; orphans: auto; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; widows: auto; word-spacing: 0px; -webkit-text-stroke-width: 0px; word-wrap: break-word; -webkit-nbsp-mode: space; -webkit-line-break: after-white-space;" class=""><div class="">Renat Akhmerov</div><div class="">@Nokia</div></div>
</div>
<br class=""><div><blockquote type="cite" class=""><div class="">On 01 Jul 2016, at 04:57, Steve Martinelli <<a href="mailto:s.martinelli@gmail.com" class="">s.martinelli@gmail.com</a>> wrote:</div><br class="Apple-interchange-newline"><div class=""><div dir="ltr" class="">The crux of this, as Dean stated, is if the library wants OSC to always be pulled in (along with its many dependencies). We've seen folks include it in requirements, test-requirements, or even not at all (just document that OSC needs to be installed). <div class=""><br class=""></div><div class="">I tossed up the idea with the ironic team of leveraging "extras" field to list OSC as optional, the change would look like:</div><div class=""><br class=""></div><div class=""><div class="">--- a/setup.cfg</div><div class="">+++ b/setup.cfg</div><div class="">@@ -22,6 +22,10 @@ classifier =</div><div class=""> <br class=""></div><div class="">+[extras]</div><div class="">+cli =</div><div class="">+ python-openstackclient>=3.0.0 # Apache-2.0</div><div class="">+</div></div><div class=""><br class=""></div><div class="">So, if a user wanted to install just the python binding of ironicclient or mistralclient, they would do $ pip install python-ironicclient; if a user wanted the CLI as well.. $ pip install python-ironicclient[cli] <br class=""></div><div class=""><br class=""></div><div class="">Just an idea, it may be overkill and completely horrible.</div></div><div class="gmail_extra"><br class=""><div class="gmail_quote">On Thu, Jun 30, 2016 at 5:29 PM, Dean Troyer <span dir="ltr" class=""><<a href="mailto:dtroyer@gmail.com" target="_blank" class="">dtroyer@gmail.com</a>></span> wrote:<br class=""><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div dir="ltr" class=""><div class="gmail_extra"><div class="gmail_quote"><span class="">On Thu, Jun 30, 2016 at 8:38 AM, Hardik <span dir="ltr" class=""><<a href="mailto:hardik.parekh@nectechnologies.in" target="_blank" class="">hardik.parekh@nectechnologies.in</a>></span> wrote:<br class=""><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
<div bgcolor="#FFFFFF" text="#000000" class="">Regarding osc-lib we have mainly two changes.<br class="">
<br class="">
1) Used "utils" which is moved from openstackclient.common.utils to
osc_lib.utils<br class="">
2) We used "command" which wrapped in osc_lib from cliff.<br class="">
<br class="">
So I think there is no harm in keeping osc_lib.<br class=""></div></blockquote><div class=""><br class=""></div></span><div class="">Admittedly the change to include osc-lib is a little early, I would have preferred until the other parts of it were a bit more stable.</div><span class=""><div class=""> </div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div bgcolor="#FFFFFF" text="#000000" class="">
Also, I guess we do not need openstackclient to be installed with
mistralclient as if mistral is used in standalone mode<br class="">
there is no need of openstackclient.<br class=""></div></blockquote><div class=""><br class=""></div></span><div class="">The choice to include OSC as a dependency of a plugin/library rests entirely on the plugin team, and that will usually be determined by the answer to the question "Do you want all users of your library to have OSc installed even if they do not use it?" or alternatively "Do you want to make your users remember to install OSC after installing the plugin?"<br class=""></div><div class=""><br class=""></div><div class="">Note that we do intend to have the capability on osc-lib to build an OSC-like stand-alone binary for plugins that would theoretically make installing OSC optional for stand-alone client users. This is not complete yet, and as I said above, one reason I wish osc-lib had not been merged into plugin requirements yet. That said, as long as you don't use those bits yet you will be fine, the utils, command, etc bits are stable, it is the clientmanager and shell parts that are still being developed.</div><span class="HOEnZb"><font color="#888888" class=""><div class=""><br class=""></div><div class="">dt</div></font></span></div><span class="HOEnZb"><font color="#888888" class=""><div class=""><br class=""></div>-- <br class=""><div data-smartmail="gmail_signature" class=""><br class="">Dean Troyer<br class=""><a href="mailto:dtroyer@gmail.com" target="_blank" class="">dtroyer@gmail.com</a><br class=""></div>
</font></span></div></div>
<br class="">__________________________________________________________________________<br class="">
OpenStack Development Mailing List (not for usage questions)<br class="">
Unsubscribe: <a href="http://OpenStack-dev-request@lists.openstack.org/?subject:unsubscribe" rel="noreferrer" target="_blank" class="">OpenStack-dev-request@lists.openstack.org?subject:unsubscribe</a><br class="">
<a href="http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev" rel="noreferrer" target="_blank" class="">http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev</a><br class="">
<br class=""></blockquote></div><br class=""></div>
__________________________________________________________________________<br class="">OpenStack Development Mailing List (not for usage questions)<br class="">Unsubscribe: <a href="mailto:OpenStack-dev-request@lists.openstack.org" class="">OpenStack-dev-request@lists.openstack.org</a>?subject:unsubscribe<br class=""><a href="http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev" class="">http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev</a><br class=""></div></blockquote></div><br class=""></div></body></html>