<div dir="ltr">I did have a question about the current implementation as described by 292499, 324379, and 292500.<div><br></div><div>Looking at the code, when a NUMAPagesTopology object is create, a new parameter is passed for the "reserved" pages. This reservation comes from a dictionary, which is populated at LIbvirtDriver init time, via grabbing the multi-string configuration settings from nova.conf. Because the object's API is changed, a version change is required.</div><div><br></div><div>Is it possible to, instead of adding a new argument to reduce the "total" argument (Ian Wells suggested this to me on a patch I had), by the number of reserved pages from the config file? This would prevent the need to alter the object's API.  So, instead of:</div><div><br></div><div><table class="inbox-inbox-highlight inbox-inbox-tab-size inbox-inbox-js-file-line-container" style="border-collapse:collapse;color:rgb(51,51,51);font-family:helvetica,arial,nimbussansl,liberationsans,freesans,clean,sans-serif,"apple color emoji","segoe ui emoji","segoe ui symbol";line-height:18.2px"><tbody style="box-sizing: border-box;"><tr style="box-sizing: border-box;"><td id="inbox-inbox-LC5078" class="inbox-inbox-blob-code inbox-inbox-blob-code-inner inbox-inbox-js-file-line" style="padding:0px 10px;vertical-align:top;overflow:visible;font-family:consolas,"liberation mono",menlo,courier,monospace;font-size:12px;word-wrap:normal;white-space:pre"><pre style="color:rgb(0,0,0);line-height:normal;word-wrap:break-word;white-space:pre-wrap">                mempages = [
                    objects.NUMAPagesTopology(
                        size_kb=pages.size,
                        total=pages.total,
                        used=0,
                        reserved=_get_reserved_memory_for_cell(
                            self, <a href="http://cell.id">cell.id</a>, pages.size))
                    for pages in cell.mempages]
</pre><br class="inbox-inbox-Apple-interchange-newline"></td></tr></tbody></table></div><div>Do something like this...</div><div><pre style="line-height:normal;word-wrap:break-word;white-space:pre-wrap"> <span style="font-size:12px">                mempages = [</span></pre><span style="font-family:monospace;font-size:12px;line-height:normal;white-space:pre-wrap">                    objects.NUMAPagesTopology(
                        size_kb=pages.size,
                        used=0,
                        total=pages.total - _get_reserved_memory_for_cell(
                            self, <a href="http://cell.id">cell.id</a>, pages.size))
                    for pages in cell.mempages]
</span><br class="inbox-inbox-Apple-interchange-newline"></div><div>If we do this, would it avoid issues with back porting the change?</div><div><br></div><div>Thanks!</div><div><br></div><div>PCM</div><div><br></div></div><br><div class="gmail_quote"><div dir="ltr">On Wed, Jun 15, 2016 at 5:52 PM Matt Riedemann <<a href="mailto:mriedem@linux.vnet.ibm.com">mriedem@linux.vnet.ibm.com</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">On 6/15/2016 3:10 PM, Paul Michali wrote:<br>
> Is the plan to back port that change to Mitaka?<br>
><br>
> Thanks,<br>
><br>
> PCM<br>
><br>
><br>
> On Wed, Jun 15, 2016 at 1:31 PM Matt Riedemann<br>
> <<a href="mailto:mriedem@linux.vnet.ibm.com" target="_blank">mriedem@linux.vnet.ibm.com</a> <mailto:<a href="mailto:mriedem@linux.vnet.ibm.com" target="_blank">mriedem@linux.vnet.ibm.com</a>>> wrote:<br>
><br>
>     On 6/14/2016 3:09 PM, Jay Pipes wrote:<br>
>     ><br>
>     > Yes. Code merged recently from Sahid does this:<br>
>     ><br>
>     > <a href="https://review.openstack.org/#/c/277422/" rel="noreferrer" target="_blank">https://review.openstack.org/#/c/277422/</a><br>
>     ><br>
>     > Best,<br>
>     > -jay<br>
>     ><br>
><br>
>     That was actually reverted out of mitaka:<br>
><br>
>     <a href="https://review.openstack.org/#/c/292290/" rel="noreferrer" target="_blank">https://review.openstack.org/#/c/292290/</a><br>
><br>
>     The feature change that got into newton was this:<br>
><br>
>     <a href="https://review.openstack.org/#/c/292499/" rel="noreferrer" target="_blank">https://review.openstack.org/#/c/292499/</a><br>
><br>
>     Which was busted, and required:<br>
><br>
>     <a href="https://review.openstack.org/#/c/324379/" rel="noreferrer" target="_blank">https://review.openstack.org/#/c/324379/</a><br>
><br>
>     Well, required as long as you want your compute service to start. :)<br>
><br>
>     And no, we aren't backporting these, especially to liberty which is<br>
>     security / critical fix mode only now.<br>
><br>
>     --<br>
><br>
>     Thanks,<br>
><br>
>     Matt Riedemann<br>
><br>
><br>
>     __________________________________________________________________________<br>
>     OpenStack Development Mailing List (not for usage questions)<br>
>     Unsubscribe:<br>
>     <a href="http://OpenStack-dev-request@lists.openstack.org?subject:unsubscribe" rel="noreferrer" target="_blank">OpenStack-dev-request@lists.openstack.org?subject:unsubscribe</a><br>
>     <<a href="http://OpenStack-dev-request@lists.openstack.org?subject:unsubscribe" rel="noreferrer" target="_blank">http://OpenStack-dev-request@lists.openstack.org?subject:unsubscribe</a>><br>
>     <a href="http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev" rel="noreferrer" target="_blank">http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev</a><br>
><br>
><br>
><br>
> __________________________________________________________________________<br>
> OpenStack Development Mailing List (not for usage questions)<br>
> Unsubscribe: <a href="http://OpenStack-dev-request@lists.openstack.org?subject:unsubscribe" rel="noreferrer" target="_blank">OpenStack-dev-request@lists.openstack.org?subject:unsubscribe</a><br>
> <a href="http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev" rel="noreferrer" target="_blank">http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev</a><br>
><br>
<br>
No, it's really a feature.<br>
<br>
--<br>
<br>
Thanks,<br>
<br>
Matt Riedemann<br>
<br>
<br>
__________________________________________________________________________<br>
OpenStack Development Mailing List (not for usage questions)<br>
Unsubscribe: <a href="http://OpenStack-dev-request@lists.openstack.org?subject:unsubscribe" rel="noreferrer" target="_blank">OpenStack-dev-request@lists.openstack.org?subject:unsubscribe</a><br>
<a href="http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev" rel="noreferrer" target="_blank">http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev</a><br>
</blockquote></div>