<html>
<head>
<meta http-equiv="Content-Type" content="text/html; charset=utf-8">
</head>
<body style="word-wrap: break-word; -webkit-nbsp-mode: space; -webkit-line-break: after-white-space;" class="">
Here is a bug for that - <a href="https://bugs.launchpad.net/octavia/+bug/1585804" class="">https://bugs.launchpad.net/octavia/+bug/1585804</a>
<div class="">You’re more than welcome to fix this issue.</div>
<div class=""><br class="">
</div>
<div class="">
<div class="">
<div class="">
<div class="">Lubosz Kosnik</div>
<div class="">Cloud Software Engineer OSIC</div>
<div class=""><a href="mailto:lubosz.kosnik@intel.com" class="">lubosz.kosnik@intel.com</a></div>
</div>
</div>
<br class="">
<div>
<blockquote type="cite" class="">
<div class="">On Jun 17, 2016, at 6:37 PM, Jiahao Liang <<a href="mailto:jiahao.liang@oneconvergence.com" class="">jiahao.liang@oneconvergence.com</a>> wrote:</div>
<br class="Apple-interchange-newline">
<div class="">
<div dir="ltr" class="">
<div class=""><font color="#500050" class=""><span style="font-size:12.8px" class="">Added more related topics to the original email.</span></font></div>
<span style="color:rgb(80,0,80);font-size:12.8px" class="">
<div class=""><span style="color:rgb(80,0,80);font-size:12.8px" class=""><br class="">
</span></div>
---------- Forwarded message ----------</span><br style="color:rgb(80,0,80);font-size:12.8px" class="">
<span style="color:rgb(80,0,80);font-size:12.8px" class="">From: </span><b class="gmail_sendername" style="color:rgb(80,0,80);font-size:12.8px">Jiahao Liang (Frankie)</b><span style="color:rgb(80,0,80);font-size:12.8px" class=""> </span><span dir="ltr" style="color:rgb(80,0,80);font-size:12.8px" class=""><<a href="mailto:gzliangjiahao@gmail.com" target="_blank" class="">gzliangjiahao@gmail.com</a>></span><br style="color:rgb(80,0,80);font-size:12.8px" class="">
<span style="color:rgb(80,0,80);font-size:12.8px" class="">Date: Fri, Jun 17, 2016 at 4:30 PM</span><br style="color:rgb(80,0,80);font-size:12.8px" class="">
<span style="color:rgb(80,0,80);font-size:12.8px" class="">Subject: [openstack-dev][Octavia]In amphora plugin_vip(), why cidr and gateway are required but not used?</span><br style="color:rgb(80,0,80);font-size:12.8px" class="">
<span style="color:rgb(80,0,80);font-size:12.8px" class="">To: </span><a href="mailto:openstack-dev@lists.openstack.org" target="_blank" style="font-size:12.8px" class="">openstack-dev@lists.openstack.org</a><br style="color:rgb(80,0,80);font-size:12.8px" class="">
<br style="color:rgb(80,0,80);font-size:12.8px" class="">
<br style="color:rgb(80,0,80);font-size:12.8px" class="">
<div dir="ltr" style="color:rgb(80,0,80);font-size:12.8px" class="">Hi community,
<div class=""><br class="">
</div>
<div class="">I am going over the Octavia amphora backend code. There is one thing really confused me. In <a href="https://github.com/openstack/octavia/blob/stable/mitaka/octavia/amphorae/backends/agent/api_server/plug.py#L45" target="_blank" class="">https://github.com/openstack/octavia/blob/stable/mitaka/octavia/amphorae/backends/agent/api_server/plug.py#L45</a>,
plug_vip() method doesn't use the cidr and gateway from the REST request. But in the haproxy amphora api, those two fields are required values (an <a href="https://github.com/openstack/octavia/blob/stable/mitaka/octavia/amphorae/backends/agent/api_server/server.py#L117" target="_blank" class="">assert</a> will
perform on the server). </div>
<div class=""><br class="">
</div>
<div class="">What is the design considerations for this api? Could we safely remove these two values to avoid ambiguity?</div>
<div class=""><br class="">
</div>
<div class="">Thank you,<font color="#888888" class=""><br clear="all" class="">
<div class="">Jiahao Liang</div>
<div data-smartmail="gmail_signature" class="">
<div dir="ltr" class="">
<div dir="ltr" class=""></div>
</div>
</div>
</font></div>
</div>
</div>
__________________________________________________________________________<br class="">
OpenStack Development Mailing List (not for usage questions)<br class="">
Unsubscribe: <a href="mailto:OpenStack-dev-request@lists.openstack.org" class="">
OpenStack-dev-request@lists.openstack.org</a>?subject:unsubscribe<br class="">
<a href="http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev" class="">http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev</a><br class="">
</div>
</blockquote>
</div>
<br class="">
</div>
</body>
</html>