<font size=2 face="sans-serif">Yes, right, the "composite_rule"
should be None in def </font><font size=1 color=#6260a1 face="Consolas">test_alarm_from_args</font><font size=3>
</font><font size=2 face="sans-serif"> :-)</font>
<br>
<br><font size=2 face="sans-serif">In addition, read the unit tests in
"test_alarm_cli.py", there is no composite test,</font>
<br><font size=2 face="sans-serif">(like "def </font><font size=1 color=#6260a1 face="Consolas">test_validate_args_composite",
similar with "test_validate_args_threshold, test_validate_args_gnocchi_resources_threshold</font><font size=3>
</font><font size=1 color=#6260a1 face="Consolas">" ), </font>
<br><font size=1 color=#6260a1 face="Consolas">which is corresponding to
composite alarm.</font>
<br>
<br><font size=1 color=#6260a1 face="Consolas">So, I think the "def
test_validate_args_composite" may be needed, </font><tt><font size=2>What
do you think?<br>
</font></tt>
<br><font size=1 color=#6260a1 face="Consolas">thank you</font>
<br>
<br><font size=1 color=#6260a1 face="Consolas">best regards</font>
<br>
<br><font size=1 color=#6260a1 face="Consolas">Rajen</font>
<br>
<br><font size=2 face="sans-serif">> </font>
<br><font size=2 face="sans-serif">> Hi,</font>
<br><font size=2 face="sans-serif">> </font>
<br><font size=2 face="sans-serif">> </font>
<br><font size=2 face="sans-serif">> The test case you pointed is for
threshold alarm, so it is OK and expected that "composite_rule"
is None.</font>
<br><font size=2 face="sans-serif">> </font>
<br><font size=2 face="sans-serif">> Checking test codes is good idea.
You can add new tests when you found something missing by posting new patch.</font>
<br><font size=2 face="sans-serif">> </font>
<br><font size=2 face="sans-serif">> </font>
<br><font size=2 face="sans-serif">> BR,</font>
<br><font size=2 face="sans-serif">> Ryota</font>
<br><font size=2 face="sans-serif">> </font>
<br><font size=2 face="sans-serif">> > -----Original Message-----</font>
<br><font size=2 face="sans-serif">> > From: li.yuanzhen@zte.com.cn
[</font><a href=mailto:li.yuanzhen@zte.com.cn><font size=2 face="sans-serif">mailto:li.yuanzhen@zte.com.cn</font></a><font size=2 face="sans-serif">]</font>
<br><font size=2 face="sans-serif">> > Sent: Thursday, May 19, 2016
12:27 PM</font>
<br><font size=2 face="sans-serif">> > To: openstack-dev@lists.openstack.org</font>
<br><font size=2 face="sans-serif">> > Cc: aji.zqfan@gmail.com; ildiko.vancsa@ericsson.com;
lianhao.lu@intel.com; liusheng2048@gmail.com; Mibu Ryota(ÈÉÉú ÁÁ</font>
<br><font size=2 face="sans-serif">> > Ì«); Julien Danjou</font>
<br><font size=2 face="sans-serif">> > Subject: [Openstack] [AodhClient]
"composite alarm" unit test missing in aodhclient ?</font>
<br><font size=2 face="sans-serif">> > </font>
<br><font size=2 face="sans-serif">> > HI All,</font>
<br><font size=2 face="sans-serif">> >
in aodhclient/tests/unit/test_alarm_cli.py[1]</font>
<br><font size=2 face="sans-serif">> > <</font><a href=https://review.openstack.org/#/c/284022/7/aodhclient/tests/unit/test_alarm_cli.py><font size=2 face="sans-serif">https://review.openstack.org/#/c/284022/7/aodhclient/tests/unit/test_alarm_cli.py</font></a><font size=2 face="sans-serif">>
, the "composite_rule" is None.</font>
<br><font size=2 face="sans-serif">> >
is the composite_rule test missing? and should we add it ?</font>
<br><font size=2 face="sans-serif">> > </font>
<br><font size=2 face="sans-serif">> > [1] </font><a href="https://github.com/openstack/python-aodhclient/blob/master/aodhclient/tests/unit/test_alarm_cli.py"><font size=2 face="sans-serif">https://github.com/openstack/python-aodhclient/blob/master/aodhclient/tests/unit/test_alarm_cli.py</font></a>
<br><font size=2 face="sans-serif">> > <</font><a href="https://github.com/openstack/python-aodhclient/blob/master/aodhclient/tests/unit/test_alarm_cli.py"><font size=2 face="sans-serif">https://github.com/openstack/python-aodhclient/blob/master/aodhclient/tests/unit/test_alarm_cli.py</font></a><font size=2 face="sans-serif">></font>
<br><font size=2 face="sans-serif">> > </font>
<br><font size=2 face="sans-serif">> > Rajen(liyuanzhen)</font>
<br><font size=2 face="sans-serif">> > </font>
<br><font size=2 face="sans-serif">> > </font>
<br><font size=2 face="sans-serif">> > --------------------------------------------------------</font>
<br><font size=2 face="sans-serif">> > ZTE Information Security Notice:
The information contained in this mail (and any attachment transmitted
herewith) is</font>
<br><font size=2 face="sans-serif">> > privileged and confidential
and is intended for the exclusive use of the addressee(s). If you
are not an intended recipient,</font>
<br><font size=2 face="sans-serif">> > any disclosure, reproduction,
distribution or other dissemination or use of the information contained
is strictly prohibited.</font>
<br><font size=2 face="sans-serif">> > If you have received this
mail in error, please delete it and notify us immediately.</font>
<br><font size=2 face="sans-serif">> > </font>
<br><font size=2 face="sans-serif">> > </font>
<br><font size=2 face="sans-serif">> </font>
<br><font size=2 face="sans-serif">> </font>
<br><font size=2 face="sans-serif">> </font>
<br><pre><font color="blue">
--------------------------------------------------------
ZTE Information Security Notice: The information contained in this mail (and any attachment transmitted herewith) is privileged and confidential and is intended for the exclusive use of the addressee(s). If you are not an intended recipient, any disclosure, reproduction, distribution or other dissemination or use of the information contained is strictly prohibited. If you have received this mail in error, please delete it and notify us immediately.
</font></pre><br>