<div dir="ltr">I agree with your approach Jeffrey, although this is not ideal, this is an approach already used in kolla.<br></div><div class="gmail_extra"><br><div class="gmail_quote">2016-05-04 12:01 GMT-03:00 Jeffrey Zhang <span dir="ltr"><<a href="mailto:zhang.lei.fly@gmail.com" target="_blank">zhang.lei.fly@gmail.com</a>></span>:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div dir="ltr"><div class="gmail_default" style="font-family:monospace,monospace;font-size:small">Recently, Jack Ning pushed a PS[0], which export the `WEBROOT` to the globals.yml file.</div><div class="gmail_default" style="font-family:monospace,monospace;font-size:small">Because there is no chance to change the horizon/apache configure file now.</div><div class="gmail_default" style="font-family:monospace,monospace;font-size:small"><br></div><div class="gmail_default" style="font-family:monospace,monospace;font-size:small">The root cause is that: Kolla do not support non-ini format configure file. for the</div><div class="gmail_default" style="font-family:monospace,monospace;font-size:small">ini-format file, we use a merge_config module[1] to merge all the found file. But it</div><div class="gmail_default" style="font-family:monospace,monospace;font-size:small">will be not work for configure file for apache, rabbitmq and so on.</div><div class="gmail_default" style="font-family:monospace,monospace;font-size:small"><br></div><div class="gmail_default" style="font-family:monospace,monospace;font-size:small">I would like to the current merge_config implementation. It is directly and easy to use.</div><div class="gmail_default" style="font-family:monospace,monospace;font-size:small">Not like the puppet, we have to remember the variable name defined in the module. we have</div><div class="gmail_default" style="font-family:monospace,monospace;font-size:small">no chance to add some user-defined variable.</div><div class="gmail_default" style="font-family:monospace,monospace;font-size:small"><br></div><div class="gmail_default" style="font-family:monospace,monospace;font-size:small">Export the variable to global is very bad and ugly. It will became a disaster when more</div><div class="gmail_default" style="font-family:monospace,monospace;font-size:small">and more variables is exported. </div><div class="gmail_default" style="font-family:monospace,monospace;font-size:small"><br></div><div class="gmail_default" style="font-family:monospace,monospace;font-size:small">So we should catch up a better solution to handle the configure file.</div><div class="gmail_default" style="font-family:monospace,monospace;font-size:small"><br></div><div class="gmail_default" style="font-family:monospace,monospace;font-size:small">One solution I have is use overwrite mechanism. for example when there is a file in</div><div class="gmail_default" style="font-family:monospace,monospace;font-size:small">/etc/kolla/config/apache.conf, it will overwrite the templates in the roles. But this</div><div class="gmail_default" style="font-family:monospace,monospace;font-size:small">is still not ideal. </div><div class="gmail_default" style="font-family:monospace,monospace;font-size:small"><br></div><div class="gmail_default" style="font-family:monospace,monospace;font-size:small">Any body has better solution?</div><div class="gmail_default" style="font-family:monospace,monospace;font-size:small"><br></div><div class="gmail_default" style="font-family:monospace,monospace;font-size:small">[0] <a href="https://review.openstack.org/306928" target="_blank">https://review.openstack.org/306928</a></div><div class="gmail_default" style="font-family:monospace,monospace;font-size:small">[1] <a href="http://git.openstack.org/cgit/openstack/kolla/tree/ansible/action_plugins/merge_configs.py" target="_blank">http://git.openstack.org/cgit/openstack/kolla/tree/ansible/action_plugins/merge_configs.py</a></div><span class="HOEnZb"><font color="#888888"><div><br></div>-- <br><div><div dir="ltr"><div><div dir="ltr"><div><div dir="ltr"><div dir="ltr"><div dir="ltr"><div><span style="font-size:13px;border-collapse:collapse"><font face="monospace, monospace">Regards,</font></span></div><div><span style="font-size:13px;border-collapse:collapse"><font face="monospace, monospace">Jeffrey Zhang</font></span></div><div><span style="font-family:monospace,monospace;font-size:12.8px">Blog: </span><a href="http://xcodest.me/" style="font-family:monospace,monospace;font-size:12.8px" target="_blank">http://xcodest.me</a><font face="monospace, monospace"><br></font></div></div></div></div></div></div></div></div></div>
</font></span></div>
<br>__________________________________________________________________________<br>
OpenStack Development Mailing List (not for usage questions)<br>
Unsubscribe: <a href="http://OpenStack-dev-request@lists.openstack.org?subject:unsubscribe" rel="noreferrer" target="_blank">OpenStack-dev-request@lists.openstack.org?subject:unsubscribe</a><br>
<a href="http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev" rel="noreferrer" target="_blank">http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev</a><br>
<br></blockquote></div><br></div>