<div dir="ltr">Thanks Amrith, this looks great!<div><br></div><div>Just added the new dashboard to my Gerrit dashboard.</div><div><br></div><div>Cannot think on anything else we could need.</div></div><div class="gmail_extra"><br><div class="gmail_quote">2016-04-16 10:45 GMT-03:00 Amrith Kumar <span dir="ltr"><<a href="mailto:amrith@tesora.com" target="_blank">amrith@tesora.com</a>></span>:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">At the Trove meeting last week, I agreed to send out a simple way in<br>
which we can all view the patches that are in need of review.<br>
<br>
In the past, as we got closer to release milestones, we have used the<br>
starredby:<name> method. I first remember using this when Nikhil<br>
proposed it in the Juno/Liberty timeframe, and it worked out well for us<br>
towards the end of the Mitaka cycle as well. I'd earlier asked on the ML<br>
for simple ways to tag and prioritize reviews [1] the sense that I have<br>
is that while there may be better tools in the future, our best bet for<br>
now is to use the same method we've been using so far.<br>
<br>
Also, thanks to Flavio who brought my attention to<br>
gerrit-dash-creator[2] and the Trove dashboard registered there, I have<br>
built and been using a dashboard for some time and I have found that it<br>
reflects some of the reviewing challenges that we've been facing as a<br>
project.<br>
<br>
To that end, I have proposed [3], a change that updates the existing<br>
Trove dashboard and provides a mechanism for all members actively<br>
working on Trove to prioritize reviews. The rationale for the change(s)<br>
and my motivations are part of the commit message in [3].<br>
<br>
To get the benefit of this dashboard, you will have to do the following.<br>
<br>
1. login to <a href="http://review.openstack.org" rel="noreferrer" target="_blank">review.openstack.org</a><br>
2. on the right-hand top corner, click on your name and then click on<br>
the "settings" link.<br>
3. on the left-hand pane, click on Preferences<br>
4. on the right-hand pane you should now see a section entitled "My<br>
Menu" and a box that says "Name" and one next to it that says "URL".<br>
5. in the name, enter Trove-Dashboard and in the URL, you will have to<br>
enter the URL for the dashboard. Since this is a very long (about 2000<br>
characters long) I've posted the text in a gist[4]. the URL will start<br>
with ... "#/dashboard/?foreach=" and end with "%3D%2D2+NOT+is%<br>
3Amergeable"<br>
6. Once you enter the name and the URL, press the "+" to the left of the<br>
name.<br>
<br>
You will now notice that your top menu in <a href="http://review.openstack.org" rel="noreferrer" target="_blank">review.openstack.org</a> will have<br>
at the very right hand end, a link called "Trove-Dashboard". If you<br>
click on it, you will see the dashboard I've created.<br>
<br>
Changes in this dashboard are shown in the following sections:<br>
<br>
My Patches Requiring Attention<br>
<br>
These are patches that you submitted, and that either have been<br>
given negative reviews, have failed check or gate, or are<br>
currently not in a state where they can merge<br>
<br>
Patches waiting longer than 14 days<br>
<br>
These are patches that have been waiting over 14 days for a<br>
review<br>
<br>
Patches waiting longer than 7 days<br>
<br>
These are patches that have been waiting over 7 days for a<br>
review<br>
<br>
Specs requiring review<br>
<br>
These are specs that are in need of review, and that have passed<br>
check, and have not been blocked (-2'ed)<br>
<br>
Trove: Priority code reviews<br>
<br>
These are changes in trove or trove-integration in need of<br>
review, and that have passed check, are mergeable, and have not<br>
been blocked (-2'ed), and have been starred by me<br>
<br>
Trove Client and Dashboard: Priority code reviews<br>
<br>
These are changes in python-troveclient or trove-dashboard in<br>
need of review, and that have passed check, are mergeable, and<br>
have not been blocked (-2'ed), , and have been starred by me<br>
<br>
Changes needing Final Approval<br>
<br>
These are changes that have one +2, that have passed check, are<br>
mergeable and need an approval<br>
<br>
Changes on branches other than master<br>
<br>
These are changes on branches other than master that are<br>
currently open<br>
<br>
Needing attention<br>
<br>
These are patches that are in need of attention; either check or<br>
gate failures, and that are not currently mergeable. This<br>
however does not show patches that are marked as WF-1 or have<br>
been blocked (-2'ed).<br>
<br>
Please post comments and feedback on this dashboard at [3]. If you wish<br>
to change the dashboard or make your own, you can do that very easily.<br>
<br>
$ git clone <a href="http://git.openstack.org/openstack/gerrit-dash-creator" rel="noreferrer" target="_blank">http://git.openstack.org/openstack/gerrit-dash-creator</a><br>
[...]<br>
$ cd gerrit-dash-creator/<br>
<br>
[If you want to change my proposed dashboard, get it ...]<br>
$ git review -d 306716<br>
Creating a git remote called "gerrit" that maps to:<br>
<br>
ssh://<a href="http://amrith@review.openstack.org:29418/openstack/gerrit-dash-creator.git" rel="noreferrer" target="_blank">amrith@review.openstack.org:29418/openstack/gerrit-dash-creator.git</a><br>
Downloading refs/changes/16/306716/1 from gerrit<br>
Switched to branch "review/amrith/trove-dashboard"<br>
<br>
$ emacs dashboards/trove.dash<br>
<br>
$ ./gerrit-dash-creator dashboards/trove.dash<br>
<a href="https://review.openstack.org/#/dashboard/?foreach=status%3Aopen++%" rel="noreferrer" target="_blank">https://review.openstack.org/#/dashboard/?foreach=status%3Aopen++%</a><br>
[... long URL deleted...]<br>
<br>
You can either navigate directly to that URL, or you can take the<br>
portion after the '#' and put it into your own menu.<br>
<br>
If you have suggestions on how to improve the dashboard I've proposed,<br>
please feel free to suggest those changes.<br>
<br>
Thanks,<br>
<br>
-amrith<br>
<br>
<br>
[1] <a href="http://openstack.markmail.org/thread/s2uc4ezrkwb7spzr" rel="noreferrer" target="_blank">http://openstack.markmail.org/thread/s2uc4ezrkwb7spzr</a><br>
[2] <a href="https://review.openstack.org/#/c/292451/" rel="noreferrer" target="_blank">https://review.openstack.org/#/c/292451/</a><br>
[3] <a href="https://review.openstack.org/#/c/306716/" rel="noreferrer" target="_blank">https://review.openstack.org/#/c/306716/</a><br>
[4] <a href="https://gist.github.com/amrith/cd96e16ce5f8108799ee801ee2cbef08" rel="noreferrer" target="_blank">https://gist.github.com/amrith/cd96e16ce5f8108799ee801ee2cbef08</a><br>
<br>
<br>__________________________________________________________________________<br>
OpenStack Development Mailing List (not for usage questions)<br>
Unsubscribe: <a href="http://OpenStack-dev-request@lists.openstack.org?subject:unsubscribe" rel="noreferrer" target="_blank">OpenStack-dev-request@lists.openstack.org?subject:unsubscribe</a><br>
<a href="http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev" rel="noreferrer" target="_blank">http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev</a><br>
<br></blockquote></div><br></div>