<div dir="ltr"><div class="gmail_default" style="font-family:arial,helvetica,sans-serif"><br></div><div class="gmail_extra"><br><div class="gmail_quote">On Mon, Apr 11, 2016 at 6:48 AM, Ihar Hrachyshka <span dir="ltr"><<a href="mailto:ihrachys@redhat.com" target="_blank">ihrachys@redhat.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left-width:1px;border-left-color:rgb(204,204,204);border-left-style:solid;padding-left:1ex"><div class=""><div class="h5">Clint Byrum <<a href="mailto:clint@fewbar.com" target="_blank">clint@fewbar.com</a>> wrote:<br>
<br>
<blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left-width:1px;border-left-color:rgb(204,204,204);border-left-style:solid;padding-left:1ex">
Excerpts from Morgan Fainberg's message of 2016-04-10 16:47:28 -0700:<br>
<blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left-width:1px;border-left-color:rgb(204,204,204);border-left-style:solid;padding-left:1ex">
On Sun, Apr 10, 2016 at 4:37 PM, Clint Byrum <<a href="mailto:clint@fewbar.com" target="_blank">clint@fewbar.com</a>> wrote:<br>
<br>
<blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left-width:1px;border-left-color:rgb(204,204,204);border-left-style:solid;padding-left:1ex">
Excerpts from Matt Riedemann's message of 2016-04-09 06:42:54 -0700:<br>
<blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left-width:1px;border-left-color:rgb(204,204,204);border-left-style:solid;padding-left:1ex">
There is also disincentive in +1ing a change that you don't understand<br>
and is wrong and then a core comes along and -1s it (you get dinged for<br>
the disagreement). And there is disincentive in -1ing a change for the<br>
wrong reasons (silly nits or asking questions for understanding). I ask<br>
a lot of questions in a lot of changes and I don't vote on those because<br>
it would be inappropriate.<br>
</blockquote>
<br>
Why is disagreement a negative thing? IMO, reviewers who agree too much<br>
are just part of the echo chamber.<br>
</blockquote>
There is no problem with disagreement IMHO. However, we track it as a stat,<br>
and people don't want to feel as though they are in disagreement with the<br>
cores. I think this is just some level of psychology.<br>
<br>
I very, very rarely look at disagreement stat for anything (now or when I<br>
was PTL).<br>
</blockquote>
<br>
Agreed, as a number, it can be highly misleading and is especially hard<br>
to compare to any of the other numbers.<br>
<br>
However, in meta-reviews, I found actual occurrences very useful to<br>
analyze how a reviewer handles confronting the other cores and how<br>
confident they are in their understanding of the code base. So it worries<br>
me that new people might be somehow discouraged from disagreement.<br>
<br>
So let me just say it here, disagreeing with the core reviewers when<br>
there is a valid reason _is what somebody who wants to be a core reviewer<br>
should be doing_.<br>
</blockquote>
<br></div></div>
Amen to that! I find that people who have higher disagreement stats are actually the people that add value to review process, since they obviously look at patches from perspectives that are different from existing core members.<br>
<br>
Now, I agree that if the disagreements are solely for nits in commit messages or random misunderstandings, then it’s not of value. But if those are legit concerns, that’s usually a good sign, not a bad one.<span class=""><font color="#888888"><br></font></span></blockquote></div><div><br></div><div><div class="gmail_default" style="font-family:arial,helvetica,sans-serif">Note that the original definition of "disagreement" from reviewstats [1][2] paid particular attention to ordering. A disagreement is only when a -core team member votes against you, not the other way around. It was kind of an experimental thing to see if it could help expose overly eager +1 reviewers (lots of reviews for stats, missing lots of errors). Maybe it hasn't proved to be that valuable.</div><br></div><div><div class="gmail_default" style="font-family:arial,helvetica,sans-serif">I haven't looked at how stackalytics implements it, though.</div></div><div><br></div><div><div class="gmail_default" style="font-family:arial,helvetica,sans-serif">[1] <a href="http://git.openstack.org/cgit/openstack-infra/reviewstats">http://git.openstack.org/cgit/openstack-infra/reviewstats</a></div><div class="gmail_default" style="font-family:arial,helvetica,sans-serif">[2] <a href="http://www.russellbryant.net/openstack-stats/">http://www.russellbryant.net/openstack-stats/</a></div></div><div><br></div>-- <br><div class="gmail_signature"><div dir="ltr"><div><font face="arial black, sans-serif">Russell Bryant</font></div></div></div>
</div></div>