<div dir="ltr"><div class="gmail_extra"><br><div class="gmail_quote">On Thu, Apr 7, 2016 at 7:41 AM, Aleksandr Didenko <span dir="ltr"><<a href="mailto:adidenko@mirantis.com" target="_blank">adidenko@mirantis.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div dir="ltr"><div><div><div>Hi,<br><br></div>thanks to Dima, we now have ROLE annotations in noop tests [0]. I've updated all the noop rspec tests that we currently have and added appropriate role annotation [1]. So after this patch is merged, we no longer need to put any new fixtures into dozens of rspec files in order to enable it.<br>Please make sure to update ROLE annotations if you introduce new roles (deployment groups) or change task-to-roles assignments in *tasks.yaml files. Core reviewers, please don't forget to check this as well ;)<br><br></div></div></div></blockquote><div><br></div><div>Is there a reason we can't leverage the existing definitions in the tasks.yaml files for this? It seems like requiring people to provide this information might lead to cases where it's gets out of sync. Shouldn't we use the task files as the source of truth for the roles?</div><div><br></div><div>-Alex</div><div> </div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div dir="ltr"><div><div></div>Regards,<br></div>Alex<br><br>[0] <a href="https://review.openstack.org/300649" target="_blank">https://review.openstack.org/300649</a><br>[1] <a href="https://review.openstack.org/302313" target="_blank">https://review.openstack.org/302313</a><br></div><div class="HOEnZb"><div class="h5"><div class="gmail_extra"><br><div class="gmail_quote">On Tue, Apr 5, 2016 at 12:11 PM, Aleksandr Didenko <span dir="ltr"><<a href="mailto:adidenko@mirantis.com" target="_blank">adidenko@mirantis.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div dir="ltr"><div><div><div>Hi folks,<br><br></div>we've merged all the changes related to fixtures update [0] and bugfix to unblock noop tests [1]. So if you see -1 from fuel_noop_tests [2] in tests not related to your patch, then please rebase.<br><br></div>Regards,<br></div>Alex<br><br>[0] <a href="https://review.openstack.org/#/q/topic:update-fixtures-to-9.0" target="_blank">https://review.openstack.org/#/q/topic:update-fixtures-to-9.0</a><br>[1] <a href="https://review.openstack.org/301107" target="_blank">https://review.openstack.org/301107</a><br>[2] <a href="https://ci.fuel-infra.org/job/fuellib_noop_tests/" target="_blank">https://ci.fuel-infra.org/job/fuellib_noop_tests/</a><br></div><div><div><div class="gmail_extra"><br><div class="gmail_quote">On Fri, Apr 1, 2016 at 7:16 PM, Vladimir Kuklin <span dir="ltr"><<a href="mailto:vkuklin@mirantis.com" target="_blank">vkuklin@mirantis.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div dir="ltr">Hi Alex<div><br></div><div>+1 to your proposal - this is long-awaited change.</div></div><div class="gmail_extra"><br><div class="gmail_quote"><div><div>On Fri, Apr 1, 2016 at 6:01 PM, Aleksandr Didenko <span dir="ltr"><<a href="mailto:adidenko@mirantis.com" target="_blank">adidenko@mirantis.com</a>></span> wrote:<br></div></div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div><div><div dir="ltr">One more thing about spec to fixture mapping [0]. What if instead of:<br><pre># RUN: (hiera1) (facts1)</pre>we'll use<br><div><pre># RUN: (roles_array1) (facts1)</pre>?<br></div><div><br>We don't need to duplicate complicated task graph calculations to understand which task to execute, because we don't care about tasks ordering and dependencies in noop tests. All we need is to map rspec task tests to astute.yaml fixtures. And it could be done via roles.<br></div><div><br>Regards,<br>Alex<br><br>[0] <a href="https://github.com/openstack/fuel-noop-fixtures/blob/master/doc/usage.rst#spec-file-annotations" target="_blank">https://github.com/openstack/fuel-noop-fixtures/blob/master/doc/usage.rst#spec-file-annotations</a><br><br></div></div><div><div><div class="gmail_extra"><br><div class="gmail_quote">On Fri, Apr 1, 2016 at 4:05 PM, Aleksandr Didenko <span dir="ltr"><<a href="mailto:adidenko@mirantis.com" target="_blank">adidenko@mirantis.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div dir="ltr"><div><div>Hi.<br><br></div> As you may know, we're still using some very old astute.yaml fixtures (v6.1) in our 'master' (v9.0) noop rspec tests [0]. Besides that, we have problems with fixture-to-rspec mapping [1]. So we've started to work on those problems [2].<br><br> So please be aware of upcoming changes in noop rspec fixtures and tests. If you see, that some important fixtures are missing (thus not covered by tests) please let me know in this email thread or via IRC/email/slack.<br></div><br> Also, we should stop updating astute.yaml fixtures manually and start using some kind of automation approach instead [3][4]. I propose to use [5] script until we find a better solution. So if you want to add some new astute.yaml fixture for noop tests, please propose a patch to this script instead of uploading yaml file.<br><div><br></div><div>Currently the following is missing in the new set of fixtures for fuel-9.0:<br></div><div>- generate_vms ('vms_conf' array in astute.yaml - I'm not sure how to properly enable it via nailgun, any help is much appreciated)<br></div><div>- selective ssl fixtures - since configuration data is not serialized from nailgun, I think that we should move this into 'hiera/override' along with implementation of new hiera overrides tests workflow [6]<br></div><div>- vmware related fixtures<br><br></div><div>Please feel free to share your ideas/comments on this topic.<br></div><div><br></div><div>Thanks,<br></div><div>Alex<br></div><div><br>[0] <a href="https://bugs.launchpad.net/fuel/+bug/1535339" target="_blank">https://bugs.launchpad.net/fuel/+bug/1535339</a><br>[1] <a href="https://github.com/openstack/fuel-noop-fixtures/blob/master/doc/usage.rst#spec-file-annotations" target="_blank">https://github.com/openstack/fuel-noop-fixtures/blob/master/doc/usage.rst#spec-file-annotations</a><br>[2] <a href="https://review.openstack.org/#/q/topic:update-fixtures-to-9.0" target="_blank">https://review.openstack.org/#/q/topic:update-fixtures-to-9.0</a><br>[3] <a href="https://github.com/openstack/fuel-noop-fixtures/blob/master/doc/fixtures.rst" target="_blank">https://github.com/openstack/fuel-noop-fixtures/blob/master/doc/fixtures.rst</a><br>[4] <a href="https://blueprints.launchpad.net/fuel/+spec/deployment-dryrun-fixtures-generator" target="_blank">https://blueprints.launchpad.net/fuel/+spec/deployment-dryrun-fixtures-generator</a><br>[5] <a href="https://github.com/openstack/fuel-noop-fixtures/blob/master/utils/generate_yamls.sh" target="_blank">https://github.com/openstack/fuel-noop-fixtures/blob/master/utils/generate_yamls.sh</a><br>[6] <a href="https://bugs.launchpad.net/fuel/+bug/1564919" target="_blank">https://bugs.launchpad.net/fuel/+bug/1564919</a><br></div></div>
</blockquote></div><br></div>
</div></div><br></div></div>__________________________________________________________________________<br>
OpenStack Development Mailing List (not for usage questions)<br>
Unsubscribe: <a href="http://OpenStack-dev-request@lists.openstack.org?subject:unsubscribe" rel="noreferrer" target="_blank">OpenStack-dev-request@lists.openstack.org?subject:unsubscribe</a><br>
<a href="http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev" rel="noreferrer" target="_blank">http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev</a><br>
<br></blockquote></div><br><br clear="all"><div><br></div>-- <br><div><div dir="ltr"><div><div dir="ltr">Yours Faithfully,<br>Vladimir Kuklin,<br>Fuel Library Tech Lead,<br>Mirantis, Inc.<br><a href="tel:%2B7%20%28495%29%20640-49-04" value="+74956404904" target="_blank">+7 (495) 640-49-04</a><br><a href="tel:%2B7%20%28926%29%20702-39-68" value="+79267023968" target="_blank">+7 (926) 702-39-68</a><br>Skype kuklinvv<br>35bk3, Vorontsovskaya Str.<br>Moscow, Russia,<br><a href="http://www.mirantis.ru/" target="_blank">www.mirantis.com</a><br><a href="http://www.mirantis.ru/" target="_blank">www.mirantis.ru</a><br><a href="mailto:vkuklin@mirantis.com" target="_blank">vkuklin@mirantis.com</a></div></div></div></div>
</div>
<br>__________________________________________________________________________<br>
OpenStack Development Mailing List (not for usage questions)<br>
Unsubscribe: <a href="http://OpenStack-dev-request@lists.openstack.org?subject:unsubscribe" rel="noreferrer" target="_blank">OpenStack-dev-request@lists.openstack.org?subject:unsubscribe</a><br>
<a href="http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev" rel="noreferrer" target="_blank">http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev</a><br>
<br></blockquote></div><br></div>
</div></div></blockquote></div><br></div>
</div></div><br>__________________________________________________________________________<br>
OpenStack Development Mailing List (not for usage questions)<br>
Unsubscribe: <a href="http://OpenStack-dev-request@lists.openstack.org?subject:unsubscribe" rel="noreferrer" target="_blank">OpenStack-dev-request@lists.openstack.org?subject:unsubscribe</a><br>
<a href="http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev" rel="noreferrer" target="_blank">http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev</a><br>
<br></blockquote></div><br></div></div>