<div dir="ltr">Sean,<div><br></div><div>I cannot speak to historically why there were not there, but I am working through the app-agnostic-logging-parameters blueprint [1] right now and it's very related to this. As part of this work I would be reviewing attributes that are more commonly used in subclassed context objects for inclusion into the base oslo.context class, a step before a more kwargs init() approach that many subclassed context object utilize now.</div><div><br></div><div>I am also proposing the standardization of context arguments [2] (specifically ids), and names are not mentioned but I would like to follow the proposed convention.<br></div><div><br></div><div>However, as you point out in the middleware [3], if the information is already available I see no reason not to facilite the base oslo.context class to consume this for subsequent use by logging. FYI the get_logging_values() work in [4] is specially to add logging only values and this can be the first use case.</div><div><br></div><div>While devstack uses these logging format string options, the defaults (which I presume are operator centric do not). One of my goals of the Austin Ops summit it to get to talk with actual operators and find out what is really in use. Regardless, the capacity to choose should be available when possible if the information is already identified without subsequent lookup.</div><div><br></div><div><br></div><div>Ronald </div><div><br></div><div><br></div><div>[1] <a href="https://blueprints.launchpad.net/oslo.log/+spec/app-agnostic-logging-parameters">https://blueprints.launchpad.net/oslo.log/+spec/app-agnostic-logging-parameters</a></div><div>[2] <a href="https://review.openstack.org/#/c/290907/">https://review.openstack.org/#/c/290907/</a></div><div>[3] <a href="http://docs.openstack.org/developer/keystonemiddleware/api/keystonemiddleware.auth_token.html#what-auth-token-adds-to-the-request-for-use-by-the-openstack-service">http://docs.openstack.org/developer/keystonemiddleware/api/keystonemiddleware.auth_token.html#what-auth-token-adds-to-the-request-for-use-by-the-openstack-service</a></div><div>[4] <a href="https://review.openstack.org/#/c/274186/">https://review.openstack.org/#/c/274186/</a></div><div><br></div><div><br></div><div><br></div><div class="gmail_extra"><div><div class="gmail_signature"><div dir="ltr"><div><div dir="ltr"><div><div dir="ltr"><div><div><div style="font-family:arial;font-size:small"><br></div></div></div></div></div></div></div></div></div></div>
<br><div class="gmail_quote">On Tue, Apr 5, 2016 at 2:31 PM, Sean Dague <span dir="ltr"><<a href="mailto:sean@dague.net" target="_blank">sean@dague.net</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left-width:1px;border-left-color:rgb(204,204,204);border-left-style:solid;padding-left:1ex">I was trying to clean up the divergent logging definitions in devstack<br>
as part of scrubbing out 'tenant' references -<br>
<a href="https://review.openstack.org/#/c/301801/" rel="noreferrer" target="_blank">https://review.openstack.org/#/c/301801/</a> and in doing so stumbled over<br>
the fact that the extremely useful project_name and user_name fields are<br>
not in base oslo.context.<br>
<br>
<a href="https://github.com/openstack/oslo.context/blob/c63a359094907bc50cc5e1be716508ddee825dfa/oslo_context/context.py#L148-L159" rel="noreferrer" target="_blank">https://github.com/openstack/oslo.context/blob/c63a359094907bc50cc5e1be716508ddee825dfa/oslo_context/context.py#L148-L159</a><br>
<br>
These are always available to be set -<br>
<a href="http://docs.openstack.org/developer/keystonemiddleware/api/keystonemiddleware.auth_token.html#what-auth-token-adds-to-the-request-for-use-by-the-openstack-service" rel="noreferrer" target="_blank">http://docs.openstack.org/developer/keystonemiddleware/api/keystonemiddleware.auth_token.html#what-auth-token-adds-to-the-request-for-use-by-the-openstack-service</a><br>
<br>
And they are extremely valuable when a human is looking at logs, as you<br>
actually can remember names when looking at various services to cross<br>
reference things. Nova has a custom context that sets these things -<br>
<a href="https://github.com/openstack/nova/blob/d57a4e8be9147bd79be12d3f5adccc9289a375b6/nova/api/auth.py#L114-L115" rel="noreferrer" target="_blank">https://github.com/openstack/nova/blob/d57a4e8be9147bd79be12d3f5adccc9289a375b6/nova/api/auth.py#L114-L115</a><br>
<br>
I would really like these to be available in all services using<br>
oslo.context.<br>
<br>
So the question is, were these not implemented on purpose? Is the<br>
opposition to putting them into oslo.context?<br>
<br>
Please let me know before I start going down this path.<br>
<span class=""><font color="#888888"><br>
-Sean<br>
<br>
--<br>
Sean Dague<br>
<a href="http://dague.net" rel="noreferrer" target="_blank">http://dague.net</a><br>
<br>
__________________________________________________________________________<br>
OpenStack Development Mailing List (not for usage questions)<br>
Unsubscribe: <a href="http://OpenStack-dev-request@lists.openstack.org?subject:unsubscribe" rel="noreferrer" target="_blank">OpenStack-dev-request@lists.openstack.org?subject:unsubscribe</a><br>
<a href="http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev" rel="noreferrer" target="_blank">http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev</a><br>
</font></span></blockquote></div><br></div></div>