<div dir="ltr">Hi Marcos,<div><br></div><div>Are you still working on your initial commit to puppet-ec2api [1] ?</div><div><br></div><div>[1] <a href="https://review.openstack.org/#/c/276103/">https://review.openstack.org/#/c/276103/</a><br></div></div><div class="gmail_extra"><br><div class="gmail_quote">2016-01-29 22:02 GMT+03:00 Emilien Macchi <span dir="ltr"><<a href="mailto:emilien@redhat.com" target="_blank">emilien@redhat.com</a>></span>:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><span class=""><br>
<br>
On 01/29/2016 10:35 AM, Marcos Fermin Lobo wrote:<br>
> Hi,<br>
><br>
> Since I finished to "apply" for puppet-ec2api module as official puppet<br>
> module in OpenStack (see <a href="https://review.openstack.org/#/c/252959/" rel="noreferrer" target="_blank">https://review.openstack.org/#/c/252959/</a> and<br>
> <a href="https://review.openstack.org/#/c/251857/" rel="noreferrer" target="_blank">https://review.openstack.org/#/c/251857/</a>), I saw that the puppet module<br>
> repository is created <a href="https://github.com/openstack/puppet-ec2api" rel="noreferrer" target="_blank">https://github.com/openstack/puppet-ec2api</a><br>
><br>
> But the repository is still empty.<br>
<br>
</span>Yeah, you have two options:<br>
<br>
#1 Import your code<br>
<br>
If you do that, please iterate your patches so you'll have reviews more<br>
quickly. You can look how puppet-mistral was created [1], I like the<br>
iterative approach (step by step).<br>
<br>
#2 Generate a new module with this procedure [2]<br>
<br>
Run the procedure, and follow-up with new patches to add the classes<br>
that you had in our module.<br>
<br>
[1] <a href="https://review.openstack.org/#/q/project:openstack/puppet-mistral" rel="noreferrer" target="_blank">https://review.openstack.org/#/q/project:openstack/puppet-mistral</a><br>
[2] <a href="https://wiki.openstack.org/wiki/Puppet/New_module#On_the_technical_side" rel="noreferrer" target="_blank">https://wiki.openstack.org/wiki/Puppet/New_module#On_the_technical_side</a><br>
<br>
> (...)<br>
<br>
Both approaches work for us, but please iterate with small chunks, which<br>
is easier to test and review.<br>
<br>
<br>
Thanks a lot for your efforts, very appreciated.<br>
<span class="HOEnZb"><font color="#888888">--<br>
Emilien Macchi<br>
<br>
</font></span><br>__________________________________________________________________________<br>
OpenStack Development Mailing List (not for usage questions)<br>
Unsubscribe: <a href="http://OpenStack-dev-request@lists.openstack.org?subject:unsubscribe" rel="noreferrer" target="_blank">OpenStack-dev-request@lists.openstack.org?subject:unsubscribe</a><br>
<a href="http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev" rel="noreferrer" target="_blank">http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev</a><br>
<br></blockquote></div><br><br clear="all"><div><br></div>-- <br><div class="gmail_signature"><div dir="ltr"><div><div dir="ltr"><div dir="ltr"><div style="color:rgb(136,136,136)"><span style="font-family:arial;font-size:small">Best Regards,</span><br></div><span style="color:rgb(136,136,136)">Egorenko Denis</span>,</div><div><font color="#888888">Senior</font><span style="color:rgb(136,136,136)"> Deployment Engineer</span><br style="color:rgb(136,136,136)"><span style="color:rgb(136,136,136)">Mirantis</span><br></div></div></div></div></div>
</div>