<div dir="ltr">Bug for this: <a href="https://bugs.launchpad.net/neutron/+bug/1558827">https://bugs.launchpad.net/neutron/+bug/1558827</a><div><br></div><div>This is something we need to get fixed for Mitaka.</div></div><div class="gmail_extra"><br><div class="gmail_quote">On Thu, Mar 17, 2016 at 2:17 PM, Kevin Benton <span dir="ltr"><<a href="mailto:kevin@benton.pub" target="_blank">kevin@benton.pub</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><p dir="ltr">Oh, I understand the issue now. I was thrown off because the quota engine doesn't log anything on that count path. </p>
<p dir="ltr">We do need to figure out why this interferes with the count query. </p><div class="HOEnZb"><div class="h5">
<div class="gmail_quote">On Mar 17, 2016 6:38 AM, "Salvatore Orlando" <<a href="mailto:salv.orlando@gmail.com" target="_blank">salv.orlando@gmail.com</a>> wrote:<br type="attribution"><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div dir="ltr">Indeed the VMware plugins were not using resource tracking (they know that my code should not be trusted!)<div><br></div><div>I think this bears however another question that we need to answer... it is likely that some change broke quota enforcement for plugins which do not use usage tracking.</div><div>When I developed reservations & usage tracking we made an assumption that plugins should not be forced to use usage tracking. If they did not, the code will fallback to the old logic which just executed a count query.</div><div><br></div><div>If we want to make usage tracking mandatory I'm fine with that, but we first need to make sure that every plugin enables it for every resource it handles.</div><div><br></div><div>Salvatore</div></div><div class="gmail_extra"><br><div class="gmail_quote">On 17 March 2016 at 12:41, Gary Kotton <span dir="ltr"><<a href="mailto:gkotton@vmware.com" target="_blank">gkotton@vmware.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
<div style="word-wrap:break-word;color:rgb(0,0,0);font-size:14px;font-family:Calibri,sans-serif">
<div>
<div>
<div>Thanks!</div>
<div><br>
</div>
<div>Much appreciated. Will check</div>
<div>
<div></div>
</div>
</div>
</div>
<div><br>
</div>
<span>
<div style="font-family:Calibri;font-size:12pt;text-align:left;color:black;BORDER-BOTTOM:medium none;BORDER-LEFT:medium none;PADDING-BOTTOM:0in;PADDING-LEFT:0in;PADDING-RIGHT:0in;BORDER-TOP:#b5c4df 1pt solid;BORDER-RIGHT:medium none;PADDING-TOP:3pt">
<span style="font-weight:bold">From: </span>Kevin Benton <<a href="mailto:kevin@benton.pub" target="_blank">kevin@benton.pub</a>><br>
<span style="font-weight:bold">Reply-To: </span>OpenStack List <<a href="mailto:openstack-dev@lists.openstack.org" target="_blank">openstack-dev@lists.openstack.org</a>><br>
<span style="font-weight:bold">Date: </span>Thursday, March 17, 2016 at 1:09 PM<br>
<span style="font-weight:bold">To: </span>OpenStack List <<a href="mailto:openstack-dev@lists.openstack.org" target="_blank">openstack-dev@lists.openstack.org</a>><br>
<span style="font-weight:bold">Subject: </span>Re: [openstack-dev] [Neutron] RBAC: Fix port query and deletion for network owner<br>
</div><div><div>
<div><br>
</div>
<div>
<div>
<div dir="ltr">After reviewing your logs[1], it seems that quotas are not working correctly in your plugin. There are no statements about tenants being marked dirty, etc.
<div><br>
</div>
<div>I think you are missing the quota registry setup code in your plugin init. Here is the ML2 example: <a href="https://urldefense.proofpoint.com/v2/url?u=https-3A__github.com_openstack_neutron_blob_44ef44c0ff97d5b166d48d2ef93feafa9a0f7ea6_neutron_plugins_ml2_plugin.py-23L167-2DL173&d=BQMFaQ&c=Sqcl0Ez6M0X8aeM67LKIiDJAXVeAw-YihVMNtXt-uEs&r=VlZxHpZBmzzkWT5jqz9JYBk8YTeq9N3-diTlNj4GyNc&m=0W0JwODAYJdy_tB4tQT0nd1zhv2OJ35zOHr5UM4KUSs&s=lXC43_6eXjZnhUzC2nnFkaD--k9FnCn8_IQK2_tFtcs&e=" target="_blank">https://github.com/openstack/neutron/blob/44ef44c0ff97d5b166d48d2ef93feafa9a0f7ea6/neutron/plugins/ml2/plugin.py#L167-L173</a></div>
<div><br>
</div>
<div><br>
</div>
<div><a href="https://urldefense.proofpoint.com/v2/url?u=http-3A__208.91.1.172_logs_neutron_293483_1_check-2Dtempest-2Dvmware-2Dnsx-2Dv3_q-2Dsvc.log.txt.gz&d=BQMFaQ&c=Sqcl0Ez6M0X8aeM67LKIiDJAXVeAw-YihVMNtXt-uEs&r=VlZxHpZBmzzkWT5jqz9JYBk8YTeq9N3-diTlNj4GyNc&m=0W0JwODAYJdy_tB4tQT0nd1zhv2OJ35zOHr5UM4KUSs&s=yxUgpc6J-xovf-ZwLu-wFeU6dGj4Ne6P-vTR32UCjrI&e=" target="_blank">http://208.91.1.172/logs/neutron/293483/1/check-tempest-vmware-nsx-v3/q-svc.log.txt.gz</a><br>
</div>
</div>
<div class="gmail_extra"><br>
<div class="gmail_quote">On Thu, Mar 17, 2016 at 1:30 AM, Gary Kotton <span dir="ltr">
<<a href="mailto:gkotton@vmware.com" target="_blank">gkotton@vmware.com</a>></span> wrote:<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
<div style="word-wrap:break-word;color:rgb(0,0,0);font-size:14px;font-family:Calibri,sans-serif">
<div>Hi,</div>
<div>The review <a href="https://review.openstack.org/#/c/255285" target="_blank">https://review.openstack.org/#/c/255285</a>/ breaks our CI. Since this has landed we are getting failed tests with the:</div>
<div>"Details: {u'message': u"Quota exceeded for resources: ['port'].", u'type': u'OverQuota', u'detail': u’’}"</div>
<div>When I revert the patch and run our CI without it the tests pass. Is anyone else hitting the same or a similar issue?</div>
<div>I think that for Mitaka we need to revert this patch</div>
<div>Thanks</div>
<span><font color="#888888">
<div>Gary</div>
<div>
<div></div>
</div>
</font></span></div>
<br>
__________________________________________________________________________<br>
OpenStack Development Mailing List (not for usage questions)<br>
Unsubscribe: <a href="http://OpenStack-dev-request@lists.openstack.org?subject:unsubscribe" rel="noreferrer" target="_blank">
OpenStack-dev-request@lists.openstack.org?subject:unsubscribe</a><br>
<a href="http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev" rel="noreferrer" target="_blank">http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev</a><br>
<br>
</blockquote>
</div>
<br>
</div>
</div>
</div>
</div></div></span>
</div>
<br>__________________________________________________________________________<br>
OpenStack Development Mailing List (not for usage questions)<br>
Unsubscribe: <a href="http://OpenStack-dev-request@lists.openstack.org?subject:unsubscribe" rel="noreferrer" target="_blank">OpenStack-dev-request@lists.openstack.org?subject:unsubscribe</a><br>
<a href="http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev" rel="noreferrer" target="_blank">http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev</a><br>
<br></blockquote></div><br></div>
<br>__________________________________________________________________________<br>
OpenStack Development Mailing List (not for usage questions)<br>
Unsubscribe: <a href="http://OpenStack-dev-request@lists.openstack.org?subject:unsubscribe" rel="noreferrer" target="_blank">OpenStack-dev-request@lists.openstack.org?subject:unsubscribe</a><br>
<a href="http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev" rel="noreferrer" target="_blank">http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev</a><br>
<br></blockquote></div>
</div></div></blockquote></div><br></div>