<html>
<head>
<meta http-equiv="Content-Type" content="text/html; charset=iso-8859-1">
</head>
<body style="word-wrap: break-word; -webkit-nbsp-mode: space; -webkit-line-break: after-white-space; color: rgb(0, 0, 0); font-size: 14px; font-family: Calibri, sans-serif;">
<div>I don't think we can really expect new contributors to understand all the magic flags. This isn't a typical problem – typically DocImpact is used correctly. But it is the responsibility of the core reviewers to make sure that new contributors aren’t
needlessly wasting time by triggering triages of incorrectly used flags.</div>
<div><br>
</div>
<div>Regards</div>
<div>-steve</div>
<div><br>
</div>
<span id="OLK_SRC_BODY_SECTION">
<div style="font-family:Calibri; font-size:11pt; text-align:left; color:black; BORDER-BOTTOM: medium none; BORDER-LEFT: medium none; PADDING-BOTTOM: 0in; PADDING-LEFT: 0in; PADDING-RIGHT: 0in; BORDER-TOP: #b5c4df 1pt solid; BORDER-RIGHT: medium none; PADDING-TOP: 3pt">
<span style="font-weight:bold">From: </span>"Vikram Hosakote (vhosakot)" <<a href="mailto:vhosakot@cisco.com">vhosakot@cisco.com</a>><br>
<span style="font-weight:bold">Reply-To: </span>"OpenStack Development Mailing List (not for usage questions)" <<a href="mailto:openstack-dev@lists.openstack.org">openstack-dev@lists.openstack.org</a>><br>
<span style="font-weight:bold">Date: </span>Monday, March 7, 2016 at 8:04 PM<br>
<span style="font-weight:bold">To: </span>"OpenStack Development Mailing List (not for usage questions)" <<a href="mailto:openstack-dev@lists.openstack.org">openstack-dev@lists.openstack.org</a>><br>
<span style="font-weight:bold">Subject: </span>Re: [openstack-dev] [Kolla] DocImpact in reviews<br>
</div>
<div><br>
</div>
<blockquote id="MAC_OUTLOOK_ATTRIBUTION_BLOCKQUOTE" style="BORDER-LEFT: #b5c4df 5 solid; PADDING:0 0 0 5; MARGIN:0 0 0 5;">
<div>
<div style="word-wrap: break-word; -webkit-nbsp-mode: space; -webkit-line-break: after-white-space; color: rgb(0, 0, 0); font-size: 15px; font-family: Calibri, sans-serif;">
<div>Good point. I think this should be caught during code review.</div>
<div><br>
</div>
<div>Regards,</div>
<div>Vikram Hosakote</div>
<div>IRC: vhosakot</div>
<div><br>
</div>
<span id="OLK_SRC_BODY_SECTION">
<div style="font-family:Calibri; font-size:11pt; text-align:left; color:black; BORDER-BOTTOM: medium none; BORDER-LEFT: medium none; PADDING-BOTTOM: 0in; PADDING-LEFT: 0in; PADDING-RIGHT: 0in; BORDER-TOP: #b5c4df 1pt solid; BORDER-RIGHT: medium none; PADDING-TOP: 3pt">
<span style="font-weight:bold">From: </span>Swapnil Kulkarni <<a href="mailto:me@coolsvap.net">me@coolsvap.net</a>><br>
<span style="font-weight:bold">Reply-To: </span>"OpenStack Development Mailing List (not for usage questions)" <<a href="mailto:openstack-dev@lists.openstack.org">openstack-dev@lists.openstack.org</a>><br>
<span style="font-weight:bold">Date: </span>Monday, March 7, 2016 at 1:40 AM<br>
<span style="font-weight:bold">To: </span>"OpenStack Development Mailing List (not for usage questions)" <<a href="mailto:openstack-dev@lists.openstack.org">openstack-dev@lists.openstack.org</a>><br>
<span style="font-weight:bold">Subject: </span>[openstack-dev] [Kolla] DocImpact in reviews<br>
</div>
<div><br>
</div>
<div>
<div>
<div>Hello,</div>
<div><br>
</div>
<div>I was triaging some of the bugs reported to Kolla and I found a couple</div>
<div>of bugs [1] [2] created due to incorrect usage of DocImpact[1] tag in</div>
<div>reviews. The DocImapct tag should only be used in case if you have</div>
<div>done some change which requires following two,</div>
<div><br>
</div>
<div>1) Update in some existing documentation</div>
<div>2) Add some new documentation</div>
<div><br>
</div>
<div>which are not addressed in the current changeset where you are adding</div>
<div>the DocImapct.</div>
<div><br>
</div>
<div><br>
</div>
<div>[1] <a href="https://wiki.openstack.org/wiki/Documentation/DocImpact">https://wiki.openstack.org/wiki/Documentation/DocImpact</a></div>
<div>[2] <a href="https://bugs.launchpad.net/kolla/+bug/1553291">https://bugs.launchpad.net/kolla/+bug/1553291</a></div>
<div>[3] <a href="https://bugs.launchpad.net/kolla/+bug/1553405">https://bugs.launchpad.net/kolla/+bug/1553405</a></div>
<div><br>
</div>
<div>Best Regards,</div>
<div>Swapnil Kulkarni</div>
<div>irc : coolsvap</div>
<div><br>
</div>
<div>__________________________________________________________________________</div>
<div>OpenStack Development Mailing List (not for usage questions)</div>
<div>Unsubscribe: <a href="mailto:OpenStack-dev-request@lists.openstack.org">OpenStack-dev-request@lists.openstack.org</a>?subject:unsubscribe</div>
<div><a href="http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev">http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev</a></div>
<div><br>
</div>
</div>
</div>
</span></div>
</div>
</blockquote>
</span>
</body>
</html>