<div dir="ltr">FFE granted. This feature seems to be low risk and part of already merged feature.<div><br></div><div>Thanks.</div></div><div class="gmail_extra"><br><div class="gmail_quote">On Mon, Mar 7, 2016 at 9:34 AM, Chad Roberts <span dir="ltr"><<a href="mailto:croberts@redhat.com" target="_blank">croberts@redhat.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div dir="ltr">+1 to Trevor's $0.02.  Seems like low risk to break any existing functionality and it's a good feature that really makes sense.<br></div><div class="HOEnZb"><div class="h5"><div class="gmail_extra"><br><div class="gmail_quote">On Mon, Mar 7, 2016 at 9:42 AM, Trevor McKay <span dir="ltr"><<a href="mailto:tmckay@redhat.com" target="_blank">tmckay@redhat.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">My 2 cents, I agree that it is low risk -- the impl for resume is<br>
analogous/parallel to the impl for suspend. And, it makes little<br>
sense to me to include suspend without resume.<br>
<br>
In my mind, these two operations are halves of the same feature,<br>
and since it is already partially implemented and approved, I the<br>
FFE should be granted.<br>
<br>
Best,<br>
<br>
Trev<br>
<div><div><br>
On Mon, 2016-03-07 at 09:07 -0500, Trevor McKay wrote:<br>
> For some reason the link below is wrong for me, it goes to a different<br>
> review. Here is a good one (I hope!):<br>
><br>
> <a href="https://review.openstack.org/#/c/285839/" rel="noreferrer" target="_blank">https://review.openstack.org/#/c/285839/</a><br>
><br>
> Trev<br>
><br>
> On Mon, 2016-03-07 at 14:28 +0800, lu jander wrote:<br>
> > Hi folks,<br>
> ><br>
> > I would like to request a FFE for the feature “Resume EDP job”:<br>
> ><br>
> ><br>
> ><br>
> > BP:<br>
> > <a href="https://blueprints.launchpad.net/sahara/+spec/add-suspend-resume-ability-for-edp-jobs" rel="noreferrer" target="_blank">https://blueprints.launchpad.net/sahara/+spec/add-suspend-resume-ability-for-edp-jobs</a><br>
> ><br>
> ><br>
> > Spec has been merged. <a href="https://review.openstack.org/#/c/198264/" rel="noreferrer" target="_blank">https://review.openstack.org/#/c/198264/</a><br>
> ><br>
> ><br>
> > Suspend EDP patch has been merged.<br>
> >  <a href="https://review.openstack.org/#/c/201448/" rel="noreferrer" target="_blank">https://review.openstack.org/#/c/201448/</a><br>
> ><br>
> ><br>
> > Code Review: <a href="https://review.openstack.org/#/c/285839/" rel="noreferrer" target="_blank">https://review.openstack.org/#/c/285839/</a><br>
> ><br>
> ><br>
> ><br>
> > code is ready for review.<br>
> ><br>
> ><br>
> ><br>
> > The Benefits for this change: after suspend job, we can resume this<br>
> > job.<br>
> ><br>
> ><br>
> ><br>
> > The Risk: The risk would be low for this patch, since the code of<br>
> > suspend patch has been long time reviewed.<br>
> ><br>
> ><br>
> ><br>
> > Thanks,<br>
> ><br>
> > luhuichun<br>
> ><br>
> ><br>
> ><br>
> > __________________________________________________________________________<br>
> > OpenStack Development Mailing List (not for usage questions)<br>
> > Unsubscribe: <a href="http://OpenStack-dev-request@lists.openstack.org?subject:unsubscribe" rel="noreferrer" target="_blank">OpenStack-dev-request@lists.openstack.org?subject:unsubscribe</a><br>
> > <a href="http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev" rel="noreferrer" target="_blank">http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev</a><br>
><br>
><br>
><br>
> __________________________________________________________________________<br>
> OpenStack Development Mailing List (not for usage questions)<br>
> Unsubscribe: <a href="http://OpenStack-dev-request@lists.openstack.org?subject:unsubscribe" rel="noreferrer" target="_blank">OpenStack-dev-request@lists.openstack.org?subject:unsubscribe</a><br>
> <a href="http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev" rel="noreferrer" target="_blank">http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev</a><br>
<br>
<br>
<br>
__________________________________________________________________________<br>
OpenStack Development Mailing List (not for usage questions)<br>
Unsubscribe: <a href="http://OpenStack-dev-request@lists.openstack.org?subject:unsubscribe" rel="noreferrer" target="_blank">OpenStack-dev-request@lists.openstack.org?subject:unsubscribe</a><br>
<a href="http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev" rel="noreferrer" target="_blank">http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev</a><br>
</div></div></blockquote></div><br></div>
</div></div><br>__________________________________________________________________________<br>
OpenStack Development Mailing List (not for usage questions)<br>
Unsubscribe: <a href="http://OpenStack-dev-request@lists.openstack.org?subject:unsubscribe" rel="noreferrer" target="_blank">OpenStack-dev-request@lists.openstack.org?subject:unsubscribe</a><br>
<a href="http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev" rel="noreferrer" target="_blank">http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev</a><br>
<br></blockquote></div><br><br clear="all"><div><br></div>-- <br><div class="gmail_signature"><div dir="ltr"><div>Sincerely yours,<br>Sergey Lukjanov<br>Principal Software Engineer<br>Mirantis Inc.</div></div></div>
</div>