<html>
<head>
<meta http-equiv="Content-Type" content="text/html; charset=utf-8">
</head>
<body style="word-wrap: break-word; -webkit-nbsp-mode: space; -webkit-line-break: after-white-space; color: rgb(0, 0, 0); font-size: 14px; font-family: Calibri, sans-serif;">
<div>
<div>
<div>Sure, I meant, we shouldn't leave this in the client going into Newton. </div>
<div><br>
</div>
<div>Thanks, </div>
<div>Goutham</div>
<div>
<div id="MAC_OUTLOOK_SIGNATURE"></div>
</div>
</div>
</div>
<div><br>
</div>
<span id="OLK_SRC_BODY_SECTION">
<div style="font-family:Calibri; font-size:12pt; text-align:left; color:black; BORDER-BOTTOM: medium none; BORDER-LEFT: medium none; PADDING-BOTTOM: 0in; PADDING-LEFT: 0in; PADDING-RIGHT: 0in; BORDER-TOP: #b5c4df 1pt solid; BORDER-RIGHT: medium none; PADDING-TOP: 3pt">
<span style="font-weight:bold">From: </span>Rodrigo Barbieri <<a href="mailto:rodrigo.barbieri2010@gmail.com">rodrigo.barbieri2010@gmail.com</a>><br>
<span style="font-weight:bold">Reply-To: </span>"OpenStack Development Mailing List (not for usage questions)" <<a href="mailto:openstack-dev@lists.openstack.org">openstack-dev@lists.openstack.org</a>><br>
<span style="font-weight:bold">Date: </span>Wednesday, March 2, 2016 at 11:32 AM<br>
<span style="font-weight:bold">To: </span>"OpenStack Development Mailing List (not for usage questions)" <<a href="mailto:openstack-dev@lists.openstack.org">openstack-dev@lists.openstack.org</a>><br>
<span style="font-weight:bold">Subject: </span>Re: [openstack-dev] [manila][python-manilaclient] Should we really be tagging "admin" CLIs?<br>
</div>
<div><br>
</div>
<div>
<div>
<div dir="ltr">+1.
<div><br>
</div>
<div>But I do not think we should necessarily do this before FF. </div>
</div>
<div class="gmail_extra"><br>
<div class="gmail_quote">On Wed, Mar 2, 2016 at 1:07 PM, Ravi, Goutham <span dir="ltr">
<<a href="mailto:Goutham.Ravi@netapp.com" target="_blank">Goutham.Ravi@netapp.com</a>></span> wrote:<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
<div style="word-wrap:break-word;color:rgb(0,0,0);font-size:14px;font-family:Calibri,sans-serif">
<div>Hi Manila community, </div>
<div><br>
</div>
<div>This is regarding the "bug": <a href="https://bugs.launchpad.net/python-manilaclient/+bug/1457155" target="_blank">https://bugs.launchpad.net/python-manilaclient/+bug/1457155</a> in the python-manilaclient. </div>
<div>A commit was made for this and it merged yesterday: <a href="https://github.com/openstack/python-manilaclient/commit/37f2e50bd433149b893d30a478947f3e17f928e9" target="_blank">https://github.com/openstack/python-manilaclient/commit/37f2e50bd433149b893d30a478947f3e17f928e9</a> (<a rel="nofollow" href="https://review.openstack.org/264110" style="color:rgb(0,51,170);text-decoration:none;font-family:monospace;font-size:12px" target="_blank"></a><a href="https://review.openstack.org/264110" target="_blank">https:/</a><a href="https://review.openstack.org/264110" target="_blank">/review.</a><a href="https://review.openstack.org/264110" target="_blank">openstack.</a><a href="https://review.openstack.org/264110" target="_blank">org/264110</a>)</div>
<div><br>
</div>
<div>I disagree with the approach in this patch. I feel this bug is invalid. Deployers have a way to modify policies in "policy.json" as with any other OpenStack project. It would be extremely confusing to see this "Admin Only" added to certain commands that
<b>we</b> think will be "admin only" (as defined in the "default" policy.json). Essentially, ANY API we build can be exposed to the user (or some users); or administrators; as determined by the deployer.</div>
<div><br>
</div>
<div>IMHO, assuming that policies can change, we shouldn't hard code "admin only" as help text. Allow the manila-api service to respond to a request with a 403 if it deems fit; it can see the policy file and works with it. That's correct behavior, as is.</div>
<div><br>
</div>
<div>I feel we should revert this change in Mitaka before the feature freeze. </div>
<div><br>
</div>
<div>Thoughts?</div>
<div><br>
</div>
<div>Thanks, </div>
<span class="HOEnZb"><font color="#888888">
<div>Goutham</div>
<div><br>
</div>
<div>
<div></div>
</div>
</font></span></div>
<br>
__________________________________________________________________________<br>
OpenStack Development Mailing List (not for usage questions)<br>
Unsubscribe: <a href="http://OpenStack-dev-request@lists.openstack.org?subject:unsubscribe" rel="noreferrer" target="_blank">
OpenStack-dev-request@lists.openstack.org?subject:unsubscribe</a><br>
<a href="http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev" rel="noreferrer" target="_blank">http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev</a><br>
<br>
</blockquote>
</div>
<br>
<br clear="all">
<div><br>
</div>
-- <br>
<div class="gmail_signature">
<div dir="ltr">
<div>Rodrigo Barbieri
<div>Computer Scientist</div>
<div>OpenStack Manila Contributor</div>
<div>Federal University of São Carlos</div>
<div><br>
</div>
</div>
</div>
</div>
</div>
</div>
</div>
</span>
</body>
</html>