<font face="Default Sans Serif,Verdana,Arial,Helvetica,sans-serif" size="2"> <span>ok, thanks, guess even if all virt layer support this 'rebuild' , we can still say it's supported by all <br>hypervisors so others can take it as a reference, will submit a new patch for it, thanks<br></span><br><br><font color="#990099">-----"Daniel P. Berrange" <<a target="_blank" href="mailto:berrange@redhat.com">berrange@redhat.com</a>> wrote: -----</font><div class="iNotesHistory" style="padding-left:5px;"><div style="padding-right:0px;padding-left:5px;border-left:solid black 2px;">To: "OpenStack Development Mailing List (not for usage questions)" <<a target="_blank" href="mailto:openstack-dev@lists.openstack.org">openstack-dev@lists.openstack.org</a>><br>From: "Daniel P. Berrange" <<a target="_blank" href="mailto:berrange@redhat.com">berrange@redhat.com</a>><br>Date: 02/02/2016 10:21AM<br>Subject: Re: [openstack-dev] [nova][virt] rebuild action not in support-matrix<br><br><div><font face="Courier New,Courier,monospace" size="2">On Mon, Feb 01, 2016 at 05:04:37PM -0700, Matt Riedemann wrote:<br>> <br>> <br>> On 2/1/2016 12:39 PM, Chen CH Ji wrote:<br>> >Hi<br>> > We have been trying to enablement of our CI work for our nova<br>> >virt layer code ,so we need to configure the tempest cases based on our<br>> >nova driver capability<br>> > I found that rebuild action is not listed in [1] (only talk<br>> >about rebuild in evacuate), but code [2] seems support virt layer<br>> >abstraction<br>> > can someone point the rebuild action in [1] or it's missing<br>> >on purpose ? Thanks<br>> ><br>> >[1]<a href="http://docs.openstack.org/developer/nova/support-matrix.html">http://docs.openstack.org/developer/nova/support-matrix.html</a><br>> >[2]<a href="https://github.com/openstack/nova/blob/master/nova/compute/manager.py#L2920">https://github.com/openstack/nova/blob/master/nova/compute/manager.py#L2920</a><br>> ><br>> ><br>> ><br>> >__________________________________________________________________________<br>> >OpenStack Development Mailing List (not for usage questions)<br>> >Unsubscribe: <a target="_blank" href="mailto:OpenStack-dev-request@lists.openstack.org?subject">OpenStack-dev-request@lists.openstack.org?subject</a>:unsubscribe<br>> ><a href="http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev">http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev</a><br>> ><br>> <br>> Only the Ironic driver overrides the rebuild method, otherwise the compute<br>> manager has a default impl, so it's technically implemented for all virt<br>> drivers. There is also confusion around rebuild vs evacuate since both<br>> operations go through the rebuild_instance method in the compute manager,<br>> they are just separated by the 'recreate' parameter.<br>> <br>> danpb might have reasons for not listing rebuild in the hypervisor support<br>> matrix - it might have just never been on the original wiki matrix. It'd be<br>> worth asking him.<br><br>The hypervisor matrix just copied the data from the original wiki. It is<br>certainly not a complete list of all features that are relevant. You could<br>make the matrix x10 bigger and it still wouldn't cover all interesting facts<br>across virt drivers. If anyone has things they want shown they should submit<br>patches....<br><br>> But at the same time, since there is a default implementation, I'm also not<br>> sure if it's worth listing separately in the support matrix (but is also<br>> confusing I suppose to not list it at all).<br><br>That there is a default impl is really just an impl detail - if it is an<br>interesting feature from the user POV it is worth listing IMHO<br><br>Regards,<br>Daniel<br>-- <br>|: <a href="http://berrange.com">http://berrange.com</a> -o- <a href="http://www.flickr.com/photos/dberrange/">http://www.flickr.com/photos/dberrange/</a> :|<br>|: <a href="http://libvirt.org">http://libvirt.org</a> -o- <a href="http://virt-manager.org">http://virt-manager.org</a> :|<br>|: <a href="http://autobuild.org">http://autobuild.org</a> -o- <a href="http://search.cpan.org/~danberr/">http://search.cpan.org/~danberr/</a> :|<br>|: <a href="http://entangle-photo.org">http://entangle-photo.org</a> -o- <a href="http://live.gnome.org/gtk-vnc">http://live.gnome.org/gtk-vnc</a> :|<br><br>__________________________________________________________________________<br>OpenStack Development Mailing List (not for usage questions)<br>Unsubscribe: <a target="_blank" href="mailto:OpenStack-dev-request@lists.openstack.org?subject">OpenStack-dev-request@lists.openstack.org?subject</a>:unsubscribe<br><a href="http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev">http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev</a><br><br></font></div></div></div></font><BR>