<html><body><div style="font-family: times new roman, new york, times, serif; font-size: 12pt; color: #000000"><div><br></div><hr id="zwchr"><blockquote style="border-left:2px solid #1010FF;margin-left:5px;padding-left:5px;color:#000;font-weight:normal;font-style:normal;text-decoration:none;font-family:Helvetica,Arial,sans-serif;font-size:12pt;" data-mce-style="border-left: 2px solid #1010FF; margin-left: 5px; padding-left: 5px; color: #000; font-weight: normal; font-style: normal; text-decoration: none; font-family: Helvetica,Arial,sans-serif; font-size: 12pt;"><b>Kimden: </b>"Markus Zoeller" <mzoeller@de.ibm.com><br><b>Kime: </b>"OpenStack Development Mailing List (not for usage questions)" <openstack-dev@lists.openstack.org><br><b>Gönderilenler: </b>13 Ocak Çarşamba 2016 17:38:21<br><b>Konu: </b>Re: [openstack-dev] [nova] config options: IRC meeting at Jan. 11th<br><div><br></div>Esra Celik <celik.esra@tubitak.gov.tr> wrote on 01/13/2016 01:29:12 PM:<br><div><br></div>> From: Esra Celik <celik.esra@tubitak.gov.tr><br>> To: "OpenStack Development Mailing List (not for usage questions)" <br>> <openstack-dev@lists.openstack.org><br>> Date: 01/13/2016 01:30 PM<br>> Subject: Re: [openstack-dev] [nova] config options: IRC meeting at Jan. <br>11th<br>> <br>> > > I do also realize now that I didn't make you aware of the <br>possibility<br>> > > to prevent a re-introduction of options in the modules you already<br>> > > cleaned [1]. I think that could be useful.<br>> > > References:<br>> > > [1] <br>> > > https://github.com/openstack/nova/blob/<br>> > > 928813ca2b23690b4468830dd70a6cc6048181fa/nova/hacking/checks.py#L567<br>> <br>> > I am not sure if I understood this correctly. Do you mean we should <br>> > check if any changes to the options occurred since we moved them to <br>> > nove/conf directory?<br>> <br>> No, that's not what I meant. You can enhance the hacking check in your<br>> "move-config-option" patch to keep that area clean for the future.<br>> Like I did with the database options in [1]. This gives a hint to other<br>> contributors, who want to introduce new config options, that they<br>> should be declared in "nova/conf/".<br>> <br>> [1] https://review.openstack.org/#/c/263804/2/nova/hacking/checks.py<br>> OK, got it. I modified nova/hacking/checks.py for my patches.<br>> <br>> Thanks a lot<br><div><br></div>I think I made a mistake to suggest to you to use the "checks.py" module. <br>Git will again have issues to merge this (e.g. [1]) when another change <br>also adds a line there. That's the same mistake I made with the <br>"__init__.py" module. I'm really sorry for that. I think it's best when<br>you remove it (if you introduced it in your patches) and I introduce <br>these lines when things get merged. It's not crucial to have it in your <br>patch, it was supposed to be a helper.<br><div><br></div>[1] https://review.openstack.org/#/c/254092/9/nova/hacking/checks.py<br><div><br></div>Slightly ashamed, Markus Zoeller (markus_z)<br></blockquote><div>Markus, you are extremely helpful at all stages. I should thank you for that.</div><div> I see how complicated it is to work concurrently on the same scope.</div><div>And this experience is a good lesson for me, thanks again.</div><div><br></div><div>I will remove checks.py changes tomorrow. </div><div><br></div><div>Best regards</div><div>esracelik</div><div><br></div></div></body></html>