<html><body><div style="font-family: times new roman, new york, times, serif; font-size: 12pt; color: #000000"><div><br></div><div><div style="font-family: Tahoma,Geneva,sans-serif; color: #cc0000; font-size: 9px;" data-mce-style="font-family: Tahoma,Geneva,sans-serif; color: #cc0000; font-size: 9px;"><strong></strong></div></div><hr id="zwchr"><blockquote style="border-left:2px solid #1010FF;margin-left:5px;padding-left:5px;color:#000;font-weight:normal;font-style:normal;text-decoration:none;font-family:Helvetica,Arial,sans-serif;font-size:12pt;" data-mce-style="border-left: 2px solid #1010FF; margin-left: 5px; padding-left: 5px; color: #000; font-weight: normal; font-style: normal; text-decoration: none; font-family: Helvetica,Arial,sans-serif; font-size: 12pt;"><b>Kimden: </b>"Markus Zoeller" <mzoeller@de.ibm.com><br><b>Kime: </b>"OpenStack Development Mailing List" <openstack-dev@lists.openstack.org><br><b>Gönderilenler: </b>13 Ocak Çarşamba 2016 10:36:56<br><b>Konu: </b>Re: [openstack-dev] [nova] config options: IRC meeting at Jan. 11th<br><div><br></div>Esra Celik <celik.esra@tubitak.gov.tr> wrote on 01/12/2016 12:55:25 PM:<br><div><br></div>> From: Esra Celik <celik.esra@tubitak.gov.tr><br>> To: "OpenStack Development Mailing List (not for usage questions)" <br>> <openstack-dev@lists.openstack.org>, Markus Zoeller/Germany/IBM@IBMDE<br>> Date: 01/12/2016 12:55 PM<br>> Subject: Re: [openstack-dev] [nova] config options: IRC meeting at Jan. <br>11th<br><div><br></div>> > I think we have the technical and organizational issues solved now<br>> > and we should focus on enhancing the help texts of the config options<br>> > you have moved in other patches to give the core reviewers a single<br>> > bucket of a finished piece of work to review.<br><div><br></div>> We will wait for the moved config options to be merged to prepare <br>> another patchset with improved help texts, right?<br>> I could actually commit a patch with improved help texts that depends <br>> on the first patch..<br><div><br></div>The latter approach is the one I mean. By this approach a reviewer<br>can check that the move is OK (which is simple to review) and then<br>review the enhanced help texts (a bit more complex to review) in<br>a row.</blockquote><div>OK, done for configdrive options [1] [2]. I am working on others now (hyperv and cells options)</div><div>[1] <a href="https://review.openstack.org/#/c/254092/">https://review.openstack.org/#/c/254092/</a> : moves configdrive options to nova/conf</div><div>[2] <a href="https://review.openstack.org/#/c/266875/">https://review.openstack.org/#/c/266875/</a> : improves the help text for configdrive options</div><blockquote style="border-left:2px solid #1010FF;margin-left:5px;padding-left:5px;color:#000;font-weight:normal;font-style:normal;text-decoration:none;font-family:Helvetica,Arial,sans-serif;font-size:12pt;" data-mce-style="border-left: 2px solid #1010FF; margin-left: 5px; padding-left: 5px; color: #000; font-weight: normal; font-style: normal; text-decoration: none; font-family: Helvetica,Arial,sans-serif; font-size: 12pt;"><br><div><br></div>> > I do also realize now that I didn't make you aware of the possibility<br>> > to prevent a re-introduction of options in the modules you already<br>> > cleaned [1]. I think that could be useful.<br>> > References:<br>> > [1] <br>> > https://github.com/openstack/nova/blob/<br>> > 928813ca2b23690b4468830dd70a6cc6048181fa/nova/hacking/checks.py#L567<br><div><br></div>> I am not sure if I understood this correctly. Do you mean we should <br>> check if any changes to the options occurred since we moved them to <br>> nove/conf directory?<br><div><br></div>No, that's not what I meant. You can enhance the hacking check in your<br>"move-config-option" patch to keep that area clean for the future.<br>Like I did with the database options in [1]. This gives a hint to other<br>contributors, who want to introduce new config options, that they<br>should be declared in "nova/conf/".<br><div><br></div>[1] https://review.openstack.org/#/c/263804/2/nova/hacking/checks.py<br></blockquote><div>OK, got it. I modified nova/hacking/checks.py for my patches.</div><div><br></div><div>Thanks a lot</div><div><br></div><div><br></div></div></body></html>