<div dir="ltr">I created a patch based off what Richard used as an example to highlight inconsistencies and made it consistent.<div><br></div><div><a href="https://review.openstack.org/#/c/264942/">https://review.openstack.org/#/c/264942/</a><br></div><div><br></div><div>Have a look and if it feels fine, we can start changing what else exists on similar lines.</div><div>Suggestions welcome.</div><div><br></div><div>-Rajat</div></div><br><div class="gmail_quote"><div dir="ltr">On Thu, Jan 7, 2016 at 10:14 AM Thai Q Tran <<a href="mailto:tqtran@us.ibm.com">tqtran@us.ibm.com</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div dir="ltr" style="font-family:Arial;font-size:10.5pt"><div dir="ltr">I 2nd that, should rename the file to delete.service.js to match service name.</div></div><div dir="ltr" style="font-family:Arial;font-size:10.5pt">
<div dir="ltr"> </div>
<blockquote dir="ltr" style="border-left:solid #aaaaaa 2px;margin-left:5px;padding-left:5px;direction:ltr;margin-right:0px">----- Original message -----<br>From: Rajat Vig <<a href="mailto:rajatv@thoughtworks.com" target="_blank">rajatv@thoughtworks.com</a>><br>To: "OpenStack Development Mailing List (not for usage questions)" <<a href="mailto:openstack-dev@lists.openstack.org" target="_blank">openstack-dev@lists.openstack.org</a>><br>Cc:<br>Subject: Re: [openstack-dev] [Horizon] naming of Javascript bits<br>Date: Thu, Jan 7, 2016 12:03 AM<br>
<div dir="ltr">Richard
<div> </div>
<div>My preference is the same as what you've got there.</div>
<div>Fully namespaced Services and Controller allow for better reusability and possibly maintainability.</div>
<div>If all "deleteService" were named just that, it'll be mighty confusing to use it in other places.</div>
<div> </div>
<div>With regards to tying the folder path and the Service/Controller I'd mostly go with that as that encourages simpler rules on how to namespace.</div>
<div> </div>
<div>For the particular patch you mentioned, the namespaces had a bit of churn which is sort of reflected in what exists in the patch now.</div>
<div> </div>
<div>If we decide a convention, then we can go and change the bits when the files change next.</div>
<div> </div>
<div>-Rajat</div>
<div> </div>
<div> </div></div>
<div><div dir="ltr">On Wed, Jan 6, 2016 at 10:30 PM Richard Jones <<a href="mailto:r1chardj0n3s@gmail.com" target="_blank">r1chardj0n3s@gmail.com</a>> wrote:</div>
<blockquote style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div dir="ltr">Hi Horizon folks,<br><br>We've been pretty good about namespacing the new angular code (to the extreme of having a bunch of very similar module files littered around, but that's angular/JS for you, so I'm not going to go on about it <wink>).<br><br>Anyhoo. One thing I've noticed is that the services, factories and controllers inside those modules aren't being consistently named. We have got a mix of:<br><br>Launch Instance:<br>
<div> .module('horizon.dashboard.project.workflow.launch-instance')<br> .factory('launchInstanceModel', launchInstanceModel);<br><br>The new Images panel:<br><br> .module('horizon.app.core.images')<br> .factory('horizon.app.core.images.row-actions.service', rowActions);<br><br>and in the same patch:<br><br> .module('horizon.app.core.images')<br> .factory('horizon.app.core.images.actions.deleteService', deleteService);<br><br>I actually prefer the second form because it matches the filename ("row-actions.service.js") even though the module namespace doesn't match the file path ("/static/app/core/images/table/").<br><br>Your thoughts?<br><br><br> Richard</div></div>__________________________________________________________________________<br>OpenStack Development Mailing List (not for usage questions)<br>Unsubscribe: <a href="http://OpenStack-dev-request@lists.openstack.org?subject:unsubscribe" rel="noreferrer" target="_blank">OpenStack-dev-request@lists.openstack.org?subject:unsubscribe</a><br><a href="http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev" rel="noreferrer" target="_blank">http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev</a></blockquote></div>
<div><font face="Default Monospace,Courier New,Courier,monospace" size="2">__________________________________________________________________________<br>OpenStack Development Mailing List (not for usage questions)<br>Unsubscribe: <a href="http://OpenStack-dev-request@lists.openstack.org?subject:unsubscribe" target="_blank">OpenStack-dev-request@lists.openstack.org?subject:unsubscribe</a><br><a href="http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev" target="_blank">http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev</a></font></div></blockquote>
<div dir="ltr"> </div></div><br>
__________________________________________________________________________<br>
OpenStack Development Mailing List (not for usage questions)<br>
Unsubscribe: <a href="http://OpenStack-dev-request@lists.openstack.org?subject:unsubscribe" rel="noreferrer" target="_blank">OpenStack-dev-request@lists.openstack.org?subject:unsubscribe</a><br>
<a href="http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev" rel="noreferrer" target="_blank">http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev</a><br>
</blockquote></div>