<html><head><meta http-equiv="Content-Type" content="text/html charset=utf-8"></head><body style="word-wrap: break-word; -webkit-nbsp-mode: space; -webkit-line-break: after-white-space;" class="">I’m late to this party because holidays (Thanks Anne for bringing it to my attention).<div class=""><br class=""></div><div class="">First of all, sorry this came as a surprise. I tried hard to make sure everyone who needed to know knew, but that’s naturally a difficult thing to do.</div><div class=""><br class=""></div><div class="">To the implementation details: I really am struggling to see how Reno could be used as a DocImpact replacement, unless you’re going to use it to somehow enforce that packages with DocImpact include some kind of text file in the commit. That would be complete overkill, and has the potential to really mess up the development repos (who needs random text files littered around?). Maybe I’m missing something here, though.</div><div class=""><br class=""></div><div class="">Really, the intent of the job is merely to check for a description after the DocImpact tag that gives the docs people a hint as to what you were thinking when you added the tag. It’s simply a time saving measure on our part, and sometimes a thing that saves a large amount of human time needs to take a small amount of compute time. I don’t think that’s a big ask, but again, please correct me if I’m wrong.</div><div class=""><br class=""></div><div class="">In short, I would rather remove the DocImpact facility entirely than try and turn a tool designed for a completely different task to this problem. However, as this is the first complaint I’ve seen about this solution since starting working on this thorny problem nearly a year ago, I can’t help but wonder if we’re overreacting? Do people genuinely hate this solution enough that we need to go back to the drawing board?</div><div class=""><br class=""></div><div class="">Lana </div><div class=""><br class=""><div><blockquote type="cite" class=""><div class="">On 22 Dec 2015, at 10:33 AM, Doug Hellmann <<a href="mailto:doug@doughellmann.com" class="">doug@doughellmann.com</a>> wrote:</div><br class="Apple-interchange-newline"><div class=""><span style="font-family: Helvetica; font-size: 12px; font-style: normal; font-variant: normal; font-weight: normal; letter-spacing: normal; orphans: auto; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; widows: auto; word-spacing: 0px; -webkit-text-stroke-width: 0px; float: none; display: inline !important;" class="">Excerpts from Andreas Jaeger's message of 2015-12-18 20:31:04 +0100:</span><br style="font-family: Helvetica; font-size: 12px; font-style: normal; font-variant: normal; font-weight: normal; letter-spacing: normal; orphans: auto; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; widows: auto; word-spacing: 0px; -webkit-text-stroke-width: 0px;" class=""><blockquote type="cite" style="font-family: Helvetica; font-size: 12px; font-style: normal; font-variant: normal; font-weight: normal; letter-spacing: normal; orphans: auto; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; widows: auto; word-spacing: 0px; -webkit-text-stroke-width: 0px;" class="">On 12/18/2015 07:45 PM, Sean Dague wrote:<br class=""><blockquote type="cite" class="">On 12/18/2015 01:34 PM, Andreas Jaeger wrote:<br class=""><blockquote type="cite" class="">On 12/18/2015 07:03 PM, Sean Dague wrote:<br class=""><blockquote type="cite" class="">Recently noticed that a new job ended up on all nova changes that was<br class="">theoertically processing commit messages for DocImpact. It appears to be<br class="">part of this spec -<br class=""><a href="http://specs.openstack.org/openstack/docs-specs/specs/mitaka/review-docimpact.html" class="">http://specs.openstack.org/openstack/docs-specs/specs/mitaka/review-docimpact.html</a><br class=""><br class=""></blockquote><br class="">Lana talked with John Garbutt about this and announced this also in<br class="">several 'What's up' newsletters like<br class=""><a href="http://lists.openstack.org/pipermail/openstack-dev/2015-December/081522.html" class="">http://lists.openstack.org/pipermail/openstack-dev/2015-December/081522.html</a><br class=""><br class=""><br class=""><blockquote type="cite" class="">First, a heads up would be good. Nova burns a lot of nodes (i.e. has a<br class="">lot of patch volume), so this just decreased everyone's CI capacity<br class="">noticably.<br class=""></blockquote><br class="">I understand this reasoning and Joshua worked on a superior solution,<br class="">see<br class="">https://review.openstack.org/#/q/status:open+project:openstack-infra/zuul+branch:master+topic:skip-commit,n,z<br class=""><br class=""><br class=""><blockquote type="cite" class=""><br class="">Secondly, this all seems like the wrong direction. We've got reno now,<br class="">which is extremely useful for documenting significant changes in the<br class="">code base that need to be reflected up. We've dropped UpgradeImpact for<br class="">an upgrade comment in reno, which is *so* much better.<br class=""><br class="">It seems like using reno instead of commit message tags would be much<br class="">better for everyone here.<br class=""></blockquote><br class="">The goal of DocImpact is to notify the Documentation team about changes<br class="">- currently done via bugs in launchpad so that manuals can be easily<br class="">updated. How would this tracking work with docimpact?<br class=""></blockquote><br class="">Because the current concern seems to be that naked DocImpact tag leaves<br class="">people guessing what is important. And I understand that. There is a<br class="">whole job now to just check that DocImpact containts a reason after it.<br class=""><br class="">We now have a very detailed system in reno to describe changes that will<br class="">impact people using the code. It lets you do that with the commit and<br class="">provide an arbitrarily large amount of content in it describing what and<br class="">why you think that's important to reflect up.<br class=""><br class="">I think it effectively deprecates all *Impact flags. Now we have a place<br class="">for that payload.<br class=""></blockquote><br class=""><br class="">We - Sean, Anne Gentle, and Jeremy Stanley - just discussed this on<span class="Apple-converted-space"> </span><br class="">#openstack-infra, let me summarize my understanding:<br class=""><br class="">Some flags are used for checking before a merge the changes, especially<span class="Apple-converted-space"> </span><br class="">SecurityImpact and APIImpact. These are used for reviewing the changes.<span class="Apple-converted-space"> </span><br class="">This would be nice for DocImpact as well. SecurityImpact creates emails<span class="Apple-converted-space"> </span><br class="">for merged changes, DocImpact creates bugs for merged changes.<br class=""><br class="">When the docimpact spec was written, reno was not in use - and later<span class="Apple-converted-space"> </span><br class="">nobody brought it up as alternative idea.<br class=""><br class="">The idea going forward is instead of checking the commit message, is to<span class="Apple-converted-space"> </span><br class="">add a special section using reno that explains the changes that are<span class="Apple-converted-space"> </span><br class="">needed. A post-job would run and create bugs or sends out emails like<span class="Apple-converted-space"> </span><br class="">today whenever a new entry gets added. But this would be triggered by<span class="Apple-converted-space"> </span><br class="">special sections in the release-notes and not in the commit message. We<span class="Apple-converted-space"> </span><br class="">also expect/hope that release notes get a good review and thus the<span class="Apple-converted-space"> </span><br class="">quality of these notifications would be improved.<br class=""></blockquote><br style="font-family: Helvetica; font-size: 12px; font-style: normal; font-variant: normal; font-weight: normal; letter-spacing: normal; orphans: auto; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; widows: auto; word-spacing: 0px; -webkit-text-stroke-width: 0px;" class=""><span style="font-family: Helvetica; font-size: 12px; font-style: normal; font-variant: normal; font-weight: normal; letter-spacing: normal; orphans: auto; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; widows: auto; word-spacing: 0px; -webkit-text-stroke-width: 0px; float: none; display: inline !important;" class="">So you want to add a special section to the reno note file, similar to</span><br style="font-family: Helvetica; font-size: 12px; font-style: normal; font-variant: normal; font-weight: normal; letter-spacing: normal; orphans: auto; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; widows: auto; word-spacing: 0px; -webkit-text-stroke-width: 0px;" class=""><span style="font-family: Helvetica; font-size: 12px; font-style: normal; font-variant: normal; font-weight: normal; letter-spacing: normal; orphans: auto; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; widows: auto; word-spacing: 0px; -webkit-text-stroke-width: 0px; float: none; display: inline !important;" class="">"upgrade" and "fixes" but to replace documentation impact notes? What</span><br style="font-family: Helvetica; font-size: 12px; font-style: normal; font-variant: normal; font-weight: normal; letter-spacing: normal; orphans: auto; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; widows: auto; word-spacing: 0px; -webkit-text-stroke-width: 0px;" class=""><span style="font-family: Helvetica; font-size: 12px; font-style: normal; font-variant: normal; font-weight: normal; letter-spacing: normal; orphans: auto; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; widows: auto; word-spacing: 0px; -webkit-text-stroke-width: 0px; float: none; display: inline !important;" class="">would use the contents?</span><br style="font-family: Helvetica; font-size: 12px; font-style: normal; font-variant: normal; font-weight: normal; letter-spacing: normal; orphans: auto; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; widows: auto; word-spacing: 0px; -webkit-text-stroke-width: 0px;" class=""><br style="font-family: Helvetica; font-size: 12px; font-style: normal; font-variant: normal; font-weight: normal; letter-spacing: normal; orphans: auto; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; widows: auto; word-spacing: 0px; -webkit-text-stroke-width: 0px;" class=""><span style="font-family: Helvetica; font-size: 12px; font-style: normal; font-variant: normal; font-weight: normal; letter-spacing: normal; orphans: auto; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; widows: auto; word-spacing: 0px; -webkit-text-stroke-width: 0px; float: none; display: inline !important;" class="">Doug</span><br style="font-family: Helvetica; font-size: 12px; font-style: normal; font-variant: normal; font-weight: normal; letter-spacing: normal; orphans: auto; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; widows: auto; word-spacing: 0px; -webkit-text-stroke-width: 0px;" class=""><br style="font-family: Helvetica; font-size: 12px; font-style: normal; font-variant: normal; font-weight: normal; letter-spacing: normal; orphans: auto; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; widows: auto; word-spacing: 0px; -webkit-text-stroke-width: 0px;" class=""><blockquote type="cite" style="font-family: Helvetica; font-size: 12px; font-style: normal; font-variant: normal; font-weight: normal; letter-spacing: normal; orphans: auto; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; widows: auto; word-spacing: 0px; -webkit-text-stroke-width: 0px;" class=""><br class="">Let's look on how exactly we can do this next year,<br class=""><br class="">Andreas<br class=""></blockquote><br style="font-family: Helvetica; font-size: 12px; font-style: normal; font-variant: normal; font-weight: normal; letter-spacing: normal; orphans: auto; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; widows: auto; word-spacing: 0px; -webkit-text-stroke-width: 0px;" class=""><span style="font-family: Helvetica; font-size: 12px; font-style: normal; font-variant: normal; font-weight: normal; letter-spacing: normal; orphans: auto; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; widows: auto; word-spacing: 0px; -webkit-text-stroke-width: 0px; float: none; display: inline !important;" class="">__________________________________________________________________________</span><br style="font-family: Helvetica; font-size: 12px; font-style: normal; font-variant: normal; font-weight: normal; letter-spacing: normal; orphans: auto; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; widows: auto; word-spacing: 0px; -webkit-text-stroke-width: 0px;" class=""><span style="font-family: Helvetica; font-size: 12px; font-style: normal; font-variant: normal; font-weight: normal; letter-spacing: normal; orphans: auto; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; widows: auto; word-spacing: 0px; -webkit-text-stroke-width: 0px; float: none; display: inline !important;" class="">OpenStack Development Mailing List (not for usage questions)</span><br style="font-family: Helvetica; font-size: 12px; font-style: normal; font-variant: normal; font-weight: normal; letter-spacing: normal; orphans: auto; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; widows: auto; word-spacing: 0px; -webkit-text-stroke-width: 0px;" class=""><span style="font-family: Helvetica; font-size: 12px; font-style: normal; font-variant: normal; font-weight: normal; letter-spacing: normal; orphans: auto; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; widows: auto; word-spacing: 0px; -webkit-text-stroke-width: 0px; float: none; display: inline !important;" class="">Unsubscribe:<span class="Apple-converted-space"> </span></span><a href="mailto:OpenStack-dev-request@lists.openstack.org" style="font-family: Helvetica; font-size: 12px; font-style: normal; font-variant: normal; font-weight: normal; letter-spacing: normal; orphans: auto; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; widows: auto; word-spacing: 0px; -webkit-text-stroke-width: 0px;" class="">OpenStack-dev-request@lists.openstack.org</a><span style="font-family: Helvetica; font-size: 12px; font-style: normal; font-variant: normal; font-weight: normal; letter-spacing: normal; orphans: auto; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; widows: auto; word-spacing: 0px; -webkit-text-stroke-width: 0px; float: none; display: inline !important;" class="">?subject:unsubscribe</span><br style="font-family: Helvetica; font-size: 12px; font-style: normal; font-variant: normal; font-weight: normal; letter-spacing: normal; orphans: auto; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; widows: auto; word-spacing: 0px; -webkit-text-stroke-width: 0px;" class=""><a href="http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev" style="font-family: Helvetica; font-size: 12px; font-style: normal; font-variant: normal; font-weight: normal; letter-spacing: normal; orphans: auto; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; widows: auto; word-spacing: 0px; -webkit-text-stroke-width: 0px;" class="">http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev</a></div></blockquote></div><br class=""><div apple-content-edited="true" class="">
<div class="">Lana Brindley<br class="">writer:speaker:blogger<br class=""><a href="http://lanabrindley.com" class="">http://lanabrindley.com</a></div><div class=""><br class=""></div><br class="Apple-interchange-newline">
</div>
<br class=""></div></body></html>