<html><head><meta http-equiv="Content-Type" content="text/html charset=utf-8"></head><body style="word-wrap: break-word; -webkit-nbsp-mode: space; -webkit-line-break: after-white-space;" class="">I’m the one who has been enforcing those style things from the beginning so let me take this and describe these rules in details.<div class=""><br class=""></div><div class="">Anastasia, have you already created a BP?</div><div class=""><br class=""><div class="">
<div class="">Renat Akhmerov</div><div class="">@ Mirantis Inc.</div><div class=""><br class=""></div><br class="Apple-interchange-newline">
</div>
<br class=""><div><blockquote type="cite" class=""><div class="">On 10 Dec 2015, at 20:05, Anastasia Kuznetsova <<a href="mailto:akuznetsova@mirantis.com" class="">akuznetsova@mirantis.com</a>> wrote:</div><br class="Apple-interchange-newline"><div class=""><div dir="ltr" class="">Moshe,<div class=""><br class=""></div><div class="">I will create blueprint for that and will attach link to etherpad, so we can form list of the rules all together. </div><div class="">After that it will be possible to publish all our 'rules' to docs and start their implementation.</div></div><div class="gmail_extra"><br class=""><div class="gmail_quote">On Thu, Dec 10, 2015 at 11:23 AM, ELISHA, Moshe (Moshe) <span dir="ltr" class=""><<a href="mailto:moshe.elisha@alcatel-lucent.com" target="_blank" class="">moshe.elisha@alcatel-lucent.com</a>></span> wrote:<br class=""><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
<div lang="EN-US" link="blue" vlink="purple" class="">
<div class=""><p class="MsoNormal"><span style="font-size:11.0pt;font-family:"Calibri","sans-serif";color:#1f497d" class="">Thanks, Anastasia!<u class=""></u><u class=""></u></span></p><p class="MsoNormal"><span style="font-size:11.0pt;font-family:"Calibri","sans-serif";color:#1f497d" class=""><u class=""></u> <u class=""></u></span></p><p class="MsoNormal"><span style="font-size:11.0pt;font-family:"Calibri","sans-serif";color:#1f497d" class="">Who can take start documenting the rules? I remember only a few rules and I don’t know all the nuances.<u class=""></u><u class=""></u></span></p><p class="MsoNormal"><span style="font-size:11.0pt;font-family:"Calibri","sans-serif";color:#1f497d" class="">For example, if the return statement is the only statement of a function – do you still need a blank line before it?<u class=""></u><u class=""></u></span></p><p class="MsoNormal"><span style="font-size:11.0pt;font-family:"Calibri","sans-serif";color:#1f497d" class=""><u class=""></u> <u class=""></u></span></p><p class="MsoNormal"><span style="font-size:11.0pt;font-family:"Calibri","sans-serif";color:#1f497d" class="">Once the rules doc will be available I can work on adding these rules to our pep8.<u class=""></u><u class=""></u></span></p><p class="MsoNormal"><span style="font-size:11.0pt;font-family:"Calibri","sans-serif";color:#1f497d" class=""><u class=""></u> <u class=""></u></span></p><p class="MsoNormal"><span style="font-size:11.0pt;font-family:"Calibri","sans-serif";color:#1f497d" class=""><u class=""></u> <u class=""></u></span></p><p class="MsoNormal"><b class=""><span style="font-size:10.0pt;font-family:"Tahoma","sans-serif"" class="">From:</span></b><span style="font-size:10.0pt;font-family:"Tahoma","sans-serif"" class=""> Anastasia Kuznetsova [mailto:<a href="mailto:akuznetsova@mirantis.com" target="_blank" class="">akuznetsova@mirantis.com</a>]
<br class="">
<b class="">Sent:</b> Wednesday, December 09, 2015 1:13 PM<br class="">
<b class="">To:</b> OpenStack Development Mailing List (not for usage questions)<br class="">
<b class="">Subject:</b> Re: [openstack-dev] [mistral] Improving Mistral pep8 rules files to match Mistral guidelines<u class=""></u><u class=""></u></span></p><div class=""><div class="h5"><p class="MsoNormal"><u class=""></u> <u class=""></u></p>
<div class=""><p class="MsoNormal">Hi Moshe,<u class=""></u><u class=""></u></p>
<div class=""><p class="MsoNormal"><u class=""></u> <u class=""></u></p>
</div>
<div class=""><p class="MsoNormal">Great idea! <u class=""></u><u class=""></u></p>
</div>
<div class=""><p class="MsoNormal"><u class=""></u> <u class=""></u></p>
</div>
<div class=""><p class="MsoNormal">It is possible to prepare some additional code checks, for example you can take a look how it was done in Rally project [1]. <br class="">
Before starting such work in Mistral, I guess that we can describe our addition code style rules in our official docs (somewhere in "Developer Guide" section [2]).<u class=""></u><u class=""></u></p>
</div>
<div class=""><p class="MsoNormal"><u class=""></u> <u class=""></u></p>
</div>
<div class=""><p class="MsoNormal">[1] <a href="https://github.com/openstack/rally/tree/master/tests/hacking" target="_blank" class="">https://github.com/openstack/rally/tree/master/tests/hacking</a><u class=""></u><u class=""></u></p>
</div>
<div class=""><p class="MsoNormal">[2] <a href="http://docs.openstack.org/developer/mistral/#developer-guide" target="_blank" class="">http://docs.openstack.org/developer/mistral/#developer-guide</a><u class=""></u><u class=""></u></p>
</div>
</div>
<div class=""><p class="MsoNormal"><u class=""></u> <u class=""></u></p>
<div class=""><p class="MsoNormal">On Wed, Dec 9, 2015 at 11:21 AM, ELISHA, Moshe (Moshe) <<a href="mailto:moshe.elisha@alcatel-lucent.com" target="_blank" class="">moshe.elisha@alcatel-lucent.com</a>> wrote:<u class=""></u><u class=""></u></p>
<div class="">
<div class=""><p class="MsoNormal">Hi all,<u class=""></u><u class=""></u></p><p class="MsoNormal"> <u class=""></u><u class=""></u></p><p class="MsoNormal">Is it possible to add all / some of the special guidelines of Mistral (like blank line before return, period at end of comment, …) to our pep8 rules file?<u class=""></u><u class=""></u></p><p class="MsoNormal"> <u class=""></u><u class=""></u></p><p class="MsoNormal">This can save a lot of time for both committers and reviewers.<u class=""></u><u class=""></u></p><p class="MsoNormal"> <u class=""></u><u class=""></u></p><p class="MsoNormal">Thanks!<u class=""></u><u class=""></u></p>
</div>
</div><p class="MsoNormal" style="margin-bottom:12.0pt"><br class="">
__________________________________________________________________________<br class="">
OpenStack Development Mailing List (not for usage questions)<br class="">
Unsubscribe: <a href="http://OpenStack-dev-request@lists.openstack.org/?subject:unsubscribe" target="_blank" class="">
OpenStack-dev-request@lists.openstack.org?subject:unsubscribe</a><br class="">
<a href="http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev" target="_blank" class="">http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev</a><u class=""></u><u class=""></u></p>
</div><p class="MsoNormal"><br class="">
<br clear="all" class="">
<u class=""></u><u class=""></u></p>
<div class=""><p class="MsoNormal"><u class=""></u> <u class=""></u></p>
</div><p class="MsoNormal">-- <u class=""></u><u class=""></u></p>
<div class="">
<div class=""><p class="MsoNormal">Best regards,<u class=""></u><u class=""></u></p>
<div class=""><p class="MsoNormal">Anastasia Kuznetsova<u class=""></u><u class=""></u></p>
</div>
</div>
</div>
</div>
</div></div></div>
</div>
<br class="">__________________________________________________________________________<br class="">
OpenStack Development Mailing List (not for usage questions)<br class="">
Unsubscribe: <a href="http://OpenStack-dev-request@lists.openstack.org/?subject:unsubscribe" rel="noreferrer" target="_blank" class="">OpenStack-dev-request@lists.openstack.org?subject:unsubscribe</a><br class="">
<a href="http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev" rel="noreferrer" target="_blank" class="">http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev</a><br class="">
<br class=""></blockquote></div><br class=""><br clear="all" class=""><div class=""><br class=""></div>-- <br class=""><div class="gmail_signature"><div dir="ltr" class="">Best regards,<div class="">Anastasia Kuznetsova</div></div></div>
</div>
__________________________________________________________________________<br class="">OpenStack Development Mailing List (not for usage questions)<br class="">Unsubscribe: <a href="mailto:OpenStack-dev-request@lists.openstack.org" class="">OpenStack-dev-request@lists.openstack.org</a>?subject:unsubscribe<br class=""><a href="http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev" class="">http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev</a><br class=""></div></blockquote></div><br class=""></div></body></html>