<div dir="ltr"><span style="font-size:12.8000001907349px">> Bootstrap building *is* a part of master node deployment.</span><div><span style="font-size:12.8000001907349px"><br></span><div><span style="font-size:12.8000001907349px">Not always, user can set flag `skip_default_img_build` then building bootstrap will not executed.</span></div></div><div><span style="font-size:12.8000001907349px"><br></span></div><div><span style="font-size:12.8000001907349px">> </span><span style="font-size:12.8000001907349px">If you guys </span><span style="font-size:12.8000001907349px">show "deployment is successful" before running building bootstrap,</span></div><span style="font-size:12.8000001907349px">> then it's something you have to fix.</span><div><span style="font-size:12.8000001907349px"><br></span></div><div><span style="font-size:12.8000001907349px">fuel-bootstrap-cli is only responsible for remove error and set it in case activation is failed.</span></div><div><span style="font-size:12.8000001907349px"><br></span></div><div><span style="font-size:12.8000001907349px">> </span><span style="font-size:12.8000001907349px">What if user choose CentOS bootstrap? We ship it on ISO, so why do</span></div><span style="font-size:12.8000001907349px">> we need to show error message?</span><div><span style="font-size:12.8000001907349px"><br></span></div><div><span style="font-size:12.8000001907349px">CentOS bootstrap still is not activated</span></div><div><span style="font-size:12.8000001907349px"><br></span></div><div><span style="font-size:12.8000001907349px">> </span><span style="font-size:12.8000001907349px">it's something unrelated to Nailgun itself</span></div><div><span style="font-size:12.8000001907349px"><br></span></div><div><span style="font-size:12.8000001907349px">I think that notifying user about errors or something else is related to Nailgun itself.</span></div><div><span style="font-size:12.8000001907349px"><br></span></div><div><span style="font-size:12.8000001907349px">Ok, </span><span style="font-size:12.8000001907349px">It's looks like workaround for me, but</span><span style="font-size:12.8000001907349px"> we can set error message in the beginning of deployment.</span></div><div><span style="font-size:12.8000001907349px">But it shouldn't be made by using fuel-bootstrap-cli. It can be curl or something else.</span></div><div><span style="font-size:12.8000001907349px"> </span><br><div><span style="font-size:12.8000001907349px"><br></span></div></div><div class="gmail_extra"><br clear="all"><div><div><div dir="ltr"><div><div dir="ltr"><div><div dir="ltr"><div><div dir="ltr"><div><div dir="ltr"><div><span style="color:rgb(0,0,0);font-family:Arial,sans-serif;line-height:21.503999710083px;white-space:pre-wrap;background-color:rgb(255,255,255)"><font size="2">Best regards,</font></span></div><div><span style="color:rgb(0,0,0);font-family:Arial,sans-serif;line-height:21.503999710083px;white-space:pre-wrap;background-color:rgb(255,255,255)"><font size="2">Svechnikov Artur</font></span></div></div></div></div></div></div></div></div></div></div></div></div>
<br><div class="gmail_quote">On Wed, Dec 16, 2015 at 4:48 PM, Igor Kalnitsky <span dir="ltr"><<a href="mailto:ikalnitsky@mirantis.com" target="_blank">ikalnitsky@mirantis.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><span>> As I already told deployment was finished, but bootstrap wasn't built.<br>
<br>
</span>Bootstrap building *is* a part of master node deployment. If you guys<br>
show "deployment is successful" before running building bootstrap,<br>
then it's something you have to fix.<br>
<span><br>
<br>
> Fuel deploying => WebUI blocked => deployment is failed due to some minor<br>
> thing => I fix it => Ooops how can I activate WebUI<br>
<br>
</span>I see no problem here. You fix the problem, run deployment script<br>
again and it unblocks everything for you. Usually it won't be enough<br>
to fix something without re-running deployment, simply because a lot<br>
of steps may be skipped due to the error.<br>
<span><br>
> I really can't understand why is it bad to set error message by default<br>
<br>
</span>So far I can provide two reasons:<br>
<br>
* What if user choose CentOS bootstrap? We ship it on ISO, so why do<br>
we need to show error message?<br>
* Nailgun should have good defaults, and showing error by default is<br>
bad practice (it's something unrelated to Nailgun itself). Moreover,<br>
it's a good practice to separate areas of responsibility, and it's<br>
building script who's responsible to show and hide error message if<br>
necessary.<br>
<span><font color="#888888"><br>
- Igor<br>
</font></span><div><div><br>
<br>
On Wed, Dec 16, 2015 at 3:31 PM, Artur Svechnikov<br>
<<a href="mailto:asvechnikov@mirantis.com" target="_blank">asvechnikov@mirantis.com</a>> wrote:<br>
>> We keep it As Is, and say "user should not use Fuel until Fuel<br>
>> Master deployment is finished".<br>
><br>
> Yep deployment can be finished, but was it successful? As I already told<br>
> deployment was finished, but bootstrap wasn't built. Command for building<br>
> bootstrap wasn't called because of some reason.<br>
><br>
>> We make API / Web UI unaccessible externally until Fuel Master is<br>
>> deployed (e.g. iptables rules or nginx ones).<br>
><br>
> This approach seems too suspicious for me, due to the same reason as above.<br>
> I can imagine some workflow: Fuel deploying => WebUI blocked => deployment<br>
> is failed due to some minor thing => I fix it => Ooops how can I activate<br>
> WebUI... But maybe I'm wrong, anyway this approach required serious change<br>
> of nailgun by handling deployment process.<br>
><br>
> I really can't understand why is it bad to set error message by default. By<br>
> default before all deployment is not finished master hasn't any valid<br>
> bootstrap image, hence this error message is not bad or weird, it's in right<br>
> place. Error message will be disabled by fuel-bootstrap-cli after building,<br>
> activation of bootstrap image.<br>
><br>
> Best regards,<br>
> Svechnikov Artur<br>
><br>
> On Wed, Dec 16, 2015 at 4:05 PM, Igor Kalnitsky <<a href="mailto:ikalnitsky@mirantis.com" target="_blank">ikalnitsky@mirantis.com</a>><br>
> wrote:<br>
>><br>
>> > I really don't like setting the error message as the default one in<br>
>> > the DB schema and consider it as a last resort solution. If<br>
>> > possible update the message to error one just before you start<br>
>> > to build the image.<br>
>><br>
>> +1.<br>
>><br>
>> > What about add some check or some message<br>
>> > "Fuel-master Deployment in progress, please wait %s" ?<br>
>><br>
>> I don't like this idea, since I believe it's something that user<br>
>> shouldn't care at all. I see two possible *right* appraoch to handle<br>
>> this:<br>
>><br>
>> 1. We keep it As Is, and say "user should not use Fuel until Fuel<br>
>> Master deployment is finished".<br>
>> 2. We make API / Web UI unaccessible externally until Fuel Master is<br>
>> deployed (e.g. iptables rules or nginx ones).<br>
>><br>
>> What do you say?<br>
>><br>
>> - Igor<br>
>><br>
>> On Wed, Dec 16, 2015 at 12:00 PM, Aleksey Zvyagintsev<br>
>> <<a href="mailto:azvyagintsev@mirantis.com" target="_blank">azvyagintsev@mirantis.com</a>> wrote:<br>
>> > Actually, its gloval problem :<br>
>> > UI accessible for user earlier then deployment has been done. I think we<br>
>> > should also handle this somehow - otherwise user can start doing "some<br>
>> > things" like spawning HW - and fail .<br>
>> > What about add some check or some message "Fuel-master Deployment in<br>
>> > progress, please wait %s" ?<br>
>> ><br>
>> ><br>
>> ><br>
>> ><br>
>> > On Tue, Dec 15, 2015 at 6:56 PM, Vitaly Kramskikh<br>
>> > <<a href="mailto:vkramskikh@mirantis.com" target="_blank">vkramskikh@mirantis.com</a>><br>
>> > wrote:<br>
>> >><br>
>> >> Hi,<br>
>> >><br>
>> >> I really don't like setting the error message as the default one in the<br>
>> >> DB<br>
>> >> schema and consider it as a last resort solution. If possible update<br>
>> >> the<br>
>> >> message to error one just before you start to build the image.<br>
>> >><br>
>> >> 2015-12-15 18:48 GMT+03:00 Artur Svechnikov <<a href="mailto:asvechnikov@mirantis.com" target="_blank">asvechnikov@mirantis.com</a>>:<br>
>> >>><br>
>> >>> Hi folks,<br>
>> >>> Recently was introduced special notification about absented bootstrap<br>
>> >>> image.<br>
>> >>><br>
>> >>> Currently this notification is sent from fuel-bootstrap-cli. It means<br>
>> >>> that error message will not be sent when failure occurs before first<br>
>> >>> building (like in [1]). I think it will be better to set error message<br>
>> >>> on<br>
>> >>> WebUI by default through fixtures and then remove it if first build is<br>
>> >>> successful.<br>
>> >>><br>
>> >>> Please share your opinions about this issue.<br>
>> >>><br>
>> >>> [1] <a href="https://bugs.launchpad.net/fuel/+bug/1526351" rel="noreferrer" target="_blank">https://bugs.launchpad.net/fuel/+bug/1526351</a><br>
>> >>><br>
>> >>> Best regards,<br>
>> >>> Svechnikov Artur<br>
>> >>><br>
>> >>><br>
>> >>><br>
>> >>> __________________________________________________________________________<br>
>> >>> OpenStack Development Mailing List (not for usage questions)<br>
>> >>> Unsubscribe:<br>
>> >>> <a href="http://OpenStack-dev-request@lists.openstack.org?subject:unsubscribe" rel="noreferrer" target="_blank">OpenStack-dev-request@lists.openstack.org?subject:unsubscribe</a><br>
>> >>> <a href="http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev" rel="noreferrer" target="_blank">http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev</a><br>
>> >>><br>
>> >><br>
>> >><br>
>> >><br>
>> >> --<br>
>> >> Vitaly Kramskikh,<br>
>> >> Fuel UI Tech Lead,<br>
>> >> Mirantis, Inc.<br>
>> >><br>
>> >><br>
>> >> __________________________________________________________________________<br>
>> >> OpenStack Development Mailing List (not for usage questions)<br>
>> >> Unsubscribe:<br>
>> >> <a href="http://OpenStack-dev-request@lists.openstack.org?subject:unsubscribe" rel="noreferrer" target="_blank">OpenStack-dev-request@lists.openstack.org?subject:unsubscribe</a><br>
>> >> <a href="http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev" rel="noreferrer" target="_blank">http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev</a><br>
>> >><br>
>> ><br>
>> ><br>
>> ><br>
>> > --<br>
>> > ---<br>
>> > Best regards,<br>
>> > Aleksey Zvyagintsev<br>
>> ><br>
>> ><br>
>> > __________________________________________________________________________<br>
>> > OpenStack Development Mailing List (not for usage questions)<br>
>> > Unsubscribe:<br>
>> > <a href="http://OpenStack-dev-request@lists.openstack.org?subject:unsubscribe" rel="noreferrer" target="_blank">OpenStack-dev-request@lists.openstack.org?subject:unsubscribe</a><br>
>> > <a href="http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev" rel="noreferrer" target="_blank">http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev</a><br>
>> ><br>
>><br>
>> __________________________________________________________________________<br>
>> OpenStack Development Mailing List (not for usage questions)<br>
>> Unsubscribe: <a href="http://OpenStack-dev-request@lists.openstack.org?subject:unsubscribe" rel="noreferrer" target="_blank">OpenStack-dev-request@lists.openstack.org?subject:unsubscribe</a><br>
>> <a href="http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev" rel="noreferrer" target="_blank">http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev</a><br>
><br>
><br>
><br>
> __________________________________________________________________________<br>
> OpenStack Development Mailing List (not for usage questions)<br>
> Unsubscribe: <a href="http://OpenStack-dev-request@lists.openstack.org?subject:unsubscribe" rel="noreferrer" target="_blank">OpenStack-dev-request@lists.openstack.org?subject:unsubscribe</a><br>
> <a href="http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev" rel="noreferrer" target="_blank">http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev</a><br>
><br>
<br>
__________________________________________________________________________<br>
OpenStack Development Mailing List (not for usage questions)<br>
Unsubscribe: <a href="http://OpenStack-dev-request@lists.openstack.org?subject:unsubscribe" rel="noreferrer" target="_blank">OpenStack-dev-request@lists.openstack.org?subject:unsubscribe</a><br>
<a href="http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev" rel="noreferrer" target="_blank">http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev</a><br>
</div></div></blockquote></div><br></div></div>