<html dir="ltr">
<head>
<meta http-equiv="Content-Type" content="text/html; charset=Windows-1252">
<style>
<!--
@font-face
{font-family:Calibri}
p.MsoNormal, li.MsoNormal, div.MsoNormal
{margin:0in;
margin-bottom:.0001pt;
font-size:11.0pt;
font-family:"Calibri","sans-serif"}
a:link, span.MsoHyperlink
{color:blue;
text-decoration:underline}
a:visited, span.MsoHyperlinkFollowed
{color:purple;
text-decoration:underline}
p.MsoListParagraph, li.MsoListParagraph, div.MsoListParagraph
{margin-top:0in;
margin-right:0in;
margin-bottom:0in;
margin-left:.5in;
margin-bottom:.0001pt;
font-size:11.0pt;
font-family:"Calibri","sans-serif"}
span.EmailStyle18
{font-family:"Calibri","sans-serif";
color:windowtext}
span.EmailStyle19
{font-family:"Calibri","sans-serif";
color:#1F497D}
.MsoChpDefault
{font-size:10.0pt}
@page WordSection1
{margin:1.0in 1.0in 1.0in 1.0in}
ol
{margin-bottom:0in}
ul
{margin-bottom:0in}
-->
</style><style id="owaParaStyle" type="text/css">P {margin-top:0;margin-bottom:0;}</style>
</head>
<body ocsi="0" fpstyle="1" lang="EN-US" link="blue" vlink="purple">
<div style="direction: ltr;font-family: Tahoma;color: #000000;font-size: 10pt;">Hi,
<br>
<br>
I have reproduced this issue multiple times before your fix was merged.<br>
<br>
In order to reproduce I used a workflow with multiple async actions, and resumed all of them at the same time.<br>
<br>
I just created a ticket in launchpad [1], with the workflow used and the mistral engine logs.<br>
<br>
[1] - <a href="https://bugs.launchpad.net/mistral/+bug/1524477" target="_blank">https://bugs.launchpad.net/mistral/+bug/1524477</a><br>
<br>
If anyone could take a look and confirm the bug it would be great.<br>
<br>
Thanks<br>
Noa Koffman<br>
<br>
<div style="font-family: Times New Roman; color: #000000; font-size: 16px">
<hr tabindex="-1">
<div style="direction: ltr;" id="divRpF465875"><font face="Tahoma" color="#000000" size="2"><b>From:</b> ELISHA, Moshe (Moshe) [moshe.elisha@alcatel-lucent.com]<br>
<b>Sent:</b> Monday, December 07, 2015 6:29 PM<br>
<b>To:</b> OpenStack Development Mailing List (not for usage questions)<br>
<b>Subject:</b> [openstack-dev] [mistral] bugfix for "Fix concurrency issues by using READ_COMMITTED" unveils / creates a different bug<br>
</font><br>
</div>
<div></div>
<div>
<div class="WordSection1">
<p class="MsoNormal">Hi all,</p>
<p class="MsoNormal"> </p>
<p class="MsoNormal">The current bugfix I am working on[1] have <span style="font-size:10.0pt; font-family:"Arial","sans-serif"; color:black; background:white">
unveiled / created a bug.</span></p>
<p class="MsoNormal">Test “WorkflowResumeTest.test_resume_different_task_states” sometimes fails because “task4” is executed twice instead of once (See unit test output and workflow below).</p>
<p class="MsoNormal"> </p>
<p class="MsoNormal">This happens because task2 on-complete is running task4 as expected but also task3 executes task4 by mistake.</p>
<p class="MsoNormal"> </p>
<p class="MsoNormal">It is not consistent but it happens quite often – This happens if the unit test resumes the WF and updates action execution of task2 and finishes task2 before task3 is finished.</p>
<p class="MsoNormal">Scenario:</p>
<p class="MsoNormal"> </p>
<p class="MsoListParagraph" style="text-indent:-.25in"><span style="">1.<span style="font:7.0pt "Times New Roman"">
</span></span><span dir="LTR"></span>Task2 in method on_action_complete – changes task2 state to RUNNING.</p>
<p class="MsoListParagraph" style="text-indent:-.25in"><span style="">2.<span style="font:7.0pt "Times New Roman"">
</span></span><span dir="LTR"></span>Task3 in method on_action_complete – changes task2 state to RUNNING (before task2 calls _on_task_state_change).</p>
<p class="MsoListParagraph" style="text-indent:-.25in"><span style="">3.<span style="font:7.0pt "Times New Roman"">
</span></span><span dir="LTR"></span>Task3 in “_on_task_state_change” > “continue_workflow” > “DirectWorkflowController ._find_next_commands” – it finds task2 because task2 is in SUCCESS and processed = False and “_find_next_commands_for_task(task2)” returns
task4.</p>
<p class="MsoListParagraph" style="text-indent:-.25in"><span style="">4.<span style="font:7.0pt "Times New Roman"">
</span></span><span dir="LTR"></span>Task3 executes command to RunTask task4.</p>
<p class="MsoListParagraph" style="text-indent:-.25in"><span style="">5.<span style="font:7.0pt "Times New Roman"">
</span></span><span dir="LTR"></span>Task2 in “_on_task_state_change” > “continue_workflow” > “DirectWorkflowController ._find_next_commands” – it finds task2 because task2 is in SUCCESS and processed = False and “_find_next_commands_for_task(task2)” returns
task4.</p>
<p class="MsoListParagraph" style="text-indent:-.25in"><span style="">6.<span style="font:7.0pt "Times New Roman"">
</span></span><span dir="LTR"></span>Task2 executes command to RunTask task4.</p>
<p class="MsoNormal"> </p>
<p class="MsoNormal"> </p>
<p class="MsoNormal">[1] - <a href="https://review.openstack.org/#/c/253819/" target="_blank">
https://review.openstack.org/#/c/253819/</a></p>
<p class="MsoNormal"> </p>
<p class="MsoNormal"><span style="font-family:"Courier New""> </span></p>
<p class="MsoNormal">If I am not mistaken – this issue also exists in the current code and my bugfix only made it much more often. Can you confirm?</p>
<p class="MsoNormal">I don’t have enough knowledge on how to fix this issue…</p>
<p class="MsoNormal">For now – I have modified the test_resume_different_task_states unit test to wait for task3 to be processed before updating the action execution of task2.</p>
<p class="MsoNormal">If you agree this bug exist today as well – we can proceed with my bugfix and open a different bug for that issue.</p>
<p class="MsoNormal"><span style="font-family:"Courier New""> </span></p>
<p class="MsoNormal">Thanks.</p>
<p class="MsoNormal"><span style="font-family:"Courier New""> </span></p>
<p class="MsoNormal"><span style="font-family:"Courier New""> </span></p>
<p class="MsoNormal"><span style="font-family:"Courier New""> </span></p>
<p class="MsoNormal"><span style="font-family:"Courier New"">[stack@melisha-devstack mistral(keystone_admin)]$ tox -e py27 -- WorkflowResumeTest.test_resume_different_task_states</span></p>
<p class="MsoNormal"><span style="font-family:"Courier New"">...</span></p>
<p class="MsoNormal"><span style="font-family:"Courier New"">======================================================================</span></p>
<p class="MsoNormal"><span style="font-family:"Courier New"">FAIL: mistral.tests.unit.engine.test_workflow_resume.WorkflowResumeTest.test_resume_different_task_states</span></p>
<p class="MsoNormal"><span style="font-family:"Courier New"">tags: worker-0</span></p>
<p class="MsoNormal"><span style="font-family:"Courier New"">----------------------------------------------------------------------</span></p>
<p class="MsoNormal"><span style="font-family:"Courier New"">pythonlogging:'': {{{WARNING [oslo_db.sqlalchemy.utils] Id not in sort_keys; is sort_keys unique?}}}</span></p>
<p class="MsoNormal"><span style="font-family:"Courier New"">stderr: {{{</span></p>
<p class="MsoNormal"><span style="font-family:"Courier New"">/opt/stack/mistral/.tox/py27/local/lib/python2.7/site-packages/novaclient/v2/client.py:109: UserWarning: 'novaclient.v2.client.Client' is not designed to be initialized directly. It is inner class
of novaclient. Please, use 'novaclient.client.Client' instead. Related lp bug-report: 1493576</span></p>
<p class="MsoNormal"><span style="font-family:"Courier New""> _LW("'novaclient.v2.client.Client' is not designed to be "</span></p>
<p class="MsoNormal"><span style="font-family:"Courier New"">}}}</span></p>
<p class="MsoNormal"><span style="font-family:"Courier New""> </span></p>
<p class="MsoNormal"><span style="font-family:"Courier New"">stdout: {{{</span></p>
<p class="MsoNormal"><span style="font-family:"Courier New"">Engine test case exception occurred: 4 != 5</span></p>
<p class="MsoNormal"><span style="font-family:"Courier New"">Exception type: <class 'testtools.matchers._impl.MismatchError'></span></p>
<p class="MsoNormal"><span style="font-family:"Courier New""> </span></p>
<p class="MsoNormal"><span style="font-family:"Courier New"">Printing workflow executions...</span></p>
<p class="MsoNormal"><span style="font-family:"Courier New""> </span></p>
<p class="MsoNormal"><span style="font-family:"Courier New"">wb.wf1 [state=SUCCESS, output={u'__execution': {u'params': {}, u'id': u'2807dd99-ca6f-49d7-886d-7d3b79e1c49e', u'spec': {u'type': u'direct', u'name': u'wf1', u'tasks': {u'task4': {u'type': u'direct',
u'name': u'task4', u'version': u'2.0', u'action': u'std.echo output="Task 4"'}, u'task2': {u'type': u'direct', u'name': u'task2', u'on-complete': [u'task4'], u'version': u'2.0', u'action': u'std.mistral_http url="<a href="http://google.com" target="_blank">http://google.com</a>"'},
u'task3': {u'type': u'direct', u'name': u'task3', u'version': u'2.0', u'action': u'std.echo output="Task 3"'}, u'task1': {u'type': u'direct', u'name': u'task1', u'on-complete': [u'task3', u'pause'], u'version': u'2.0', u'action': u'std.echo output="Hi!"'}},
u'version': u'2.0'}, u'input': {}}, u'task4': u'Task 4', u'task3': u'Task 3', u'__tasks': {u'848c6e92-b1b1-4d54-b11d-c93cfb4fc88f': u'task2', u'00a546e7-8da9-4603-b6be-54d58b14c625': u'task1'}}]</span></p>
<p class="MsoNormal"><span style="font-family:"Courier New""> task2 [id=848c6e92-b1b1-4d54-b11d-c93cfb4fc88f, state=SUCCESS, published={}]</span></p>
<p class="MsoNormal"><span style="font-family:"Courier New""> task1 [id=00a546e7-8da9-4603-b6be-54d58b14c625, state=SUCCESS, published={}]</span></p>
<p class="MsoNormal"><span style="font-family:"Courier New""> task3 [id=8ce20324-7fba-4424-bcd2-1e0c9b27fd4a, state=SUCCESS, published={}]</span></p>
<p class="MsoNormal"><span style="font-family:"Courier New""> <span style="background:yellow">
task4 [id=3758de43-9bc3-4ac9-b3f3-29eb543b16ef, state=SUCCESS, published={}]</span></span></p>
<p class="MsoNormal"><span style="font-family:"Courier New"; background:yellow"> task4 [id=f12ee464-0ba5-48c7-8423-9f425a00e675, state=SUCCESS, published={}]</span><span style="font-family:"Courier New""></span></p>
<p class="MsoNormal"><span style="font-family:"Courier New"">}}}</span></p>
<p class="MsoNormal"><span style="font-family:"Courier New""> </span></p>
<p class="MsoNormal"><span style="font-family:"Courier New"">Traceback (most recent call last):</span></p>
<p class="MsoNormal"><span style="font-family:"Courier New""> File "mistral/tests/unit/engine/test_workflow_resume.py", line 321, in test_resume_different_task_states</span></p>
<p class="MsoNormal"><span style="font-family:"Courier New""> self.assertEqual(4, len(wf_ex.task_executions))</span></p>
<p class="MsoNormal"><span style="font-family:"Courier New""> File "/opt/stack/mistral/.tox/py27/local/lib/python2.7/site-packages/testtools/testcase.py", line 350, in assertEqual</span></p>
<p class="MsoNormal"><span style="font-family:"Courier New""> self.assertThat(observed, matcher, message)</span></p>
<p class="MsoNormal"><span style="font-family:"Courier New""> File "/opt/stack/mistral/.tox/py27/local/lib/python2.7/site-packages/testtools/testcase.py", line 435, in assertThat</span></p>
<p class="MsoNormal"><span style="font-family:"Courier New""> raise mismatch_error</span></p>
<p class="MsoNormal"><span style="font-family:"Courier New"">testtools.matchers._impl.<span style="background:yellow">MismatchError: 4 != 5</span></span></p>
<p class="MsoNormal"><span style="font-family:"Courier New"">Ran 1 tests in 15.517s (+2.591s)</span></p>
<p class="MsoNormal"><span style="font-family:"Courier New"">FAILED (id=301, failures=1 (+1))</span></p>
<p class="MsoNormal"><span style="font-family:"Courier New"">error: testr failed (1)</span></p>
<p class="MsoNormal"><span style="font-family:"Courier New"">ERROR: InvocationError: '/opt/stack/mistral/.tox/py27/bin/python setup.py testr --slowest --testr-args=WorkflowResumeTest.test_resume_different_task_states'</span></p>
<p class="MsoNormal"><span style="font-family:"Courier New"">___________________________________________________________________________________________________________________________________ summary ___________________________________________________________________________________________________________________________________</span></p>
<p class="MsoNormal"><span style="font-family:"Courier New"">ERROR: py27: commands failed</span></p>
<p class="MsoNormal"><span style="font-family:"Courier New""> </span></p>
<p class="MsoNormal"><span style="font-family:"Courier New""> </span></p>
<p class="MsoNormal"><span style="font-family:"Courier New""> </span></p>
<div style="border:none; border-bottom:solid windowtext 1.0pt; padding:0in 0in 1.0pt 0in">
<p class="MsoNormal"><span style="font-family:"Courier New""> </span></p>
</div>
<p class="MsoNormal"><span style="font-family:"Courier New""> </span></p>
<p class="MsoNormal"><span style="font-family:"Courier New""> </span></p>
<p class="MsoNormal">Unit test workflow:</p>
<p class="MsoNormal"><span style="font-family:"Courier New""> </span></p>
<p class="MsoNormal"><span style="font-family:"Courier New""> </span></p>
<p class="MsoNormal"><span style="font-family:"Courier New"">---</span></p>
<p class="MsoNormal"><span style="font-family:"Courier New"">version: '2.0'</span></p>
<p class="MsoNormal"><span style="font-family:"Courier New""> </span></p>
<p class="MsoNormal"><span style="font-family:"Courier New"">name: wb</span></p>
<p class="MsoNormal"><span style="font-family:"Courier New""> </span></p>
<p class="MsoNormal"><span style="font-family:"Courier New"">workflows:</span></p>
<p class="MsoNormal"><span style="font-family:"Courier New""> wf1:</span></p>
<p class="MsoNormal"><span style="font-family:"Courier New""> type: direct</span></p>
<p class="MsoNormal"><span style="font-family:"Courier New""> </span></p>
<p class="MsoNormal"><span style="font-family:"Courier New""> tasks:</span></p>
<p class="MsoNormal"><span style="font-family:"Courier New""> task1:</span></p>
<p class="MsoNormal"><span style="font-family:"Courier New""> action: std.echo output="Hi!"</span></p>
<p class="MsoNormal"><span style="font-family:"Courier New""> on-complete:</span></p>
<p class="MsoNormal"><span style="font-family:"Courier New""> - task3</span></p>
<p class="MsoNormal"><span style="font-family:"Courier New""> - pause</span></p>
<p class="MsoNormal"><span style="font-family:"Courier New""> </span></p>
<p class="MsoNormal"><span style="font-family:"Courier New""> task2:</span></p>
<p class="MsoNormal"><span style="font-family:"Courier New""> action: std.mistral_http url="<a href="http://google.com" target="_blank">http://google.com</a>"</span></p>
<p class="MsoNormal"><span style="font-family:"Courier New""> # This one won't be finished when execution is already PAUSED.</span></p>
<p class="MsoNormal"><span style="font-family:"Courier New""> on-complete:</span></p>
<p class="MsoNormal"><span style="font-family:"Courier New""> - task4</span></p>
<p class="MsoNormal"><span style="font-family:"Courier New""> </span></p>
<p class="MsoNormal"><span style="font-family:"Courier New""> task3:</span></p>
<p class="MsoNormal"><span style="font-family:"Courier New""> action: std.echo output="Task 3"</span></p>
<p class="MsoNormal"><span style="font-family:"Courier New""> </span></p>
<p class="MsoNormal"><span style="font-family:"Courier New""> task4:</span></p>
<p class="MsoNormal"><span style="font-family:"Courier New""> action: std.echo output="Task 4"</span></p>
<p class="MsoNormal"><span style="font-family:"Courier New""> </span></p>
<p class="MsoNormal"><span style="font-family:"Courier New""> </span></p>
<p class="MsoNormal"><span style="font-family:"Courier New""> </span></p>
<p class="MsoNormal"><span style="font-family:"Courier New""> </span></p>
<p class="MsoNormal"><span style="font-family:"Courier New""> </span></p>
<p class="MsoNormal"><span style="font-family:"Courier New""> </span></p>
<p class="MsoNormal"><span style="font-family:"Courier New""> </span></p>
</div>
</div>
</div>
</div>
</body>
</html>