<div dir="ltr"><br><div class="gmail_extra"><br><div class="gmail_quote">On 7 December 2015 at 05:41, Ryan Moats <span dir="ltr"><<a href="mailto:rmoats@us.ibm.com" target="_blank">rmoats@us.ibm.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div><p><tt>"Armando M." <<a href="mailto:armamig@gmail.com" target="_blank">armamig@gmail.com</a>> wrote on 12/04/2015 03:43:29 PM:<br><br>> From: "Armando M." <<a href="mailto:armamig@gmail.com" target="_blank">armamig@gmail.com</a>></tt><span><br><tt>> To: "OpenStack Development Mailing List (not for usage questions)" <br>> <<a href="mailto:openstack-dev@lists.openstack.org" target="_blank">openstack-dev@lists.openstack.org</a>></tt><br></span><tt>> Date: 12/04/2015 03:44 PM</tt><span><br><tt>> Subject: Re: [openstack-dev] [Neutron][DVR]</tt><br></span><tt>> <br><span>> > On 4 December 2015 at 05:56, Ryan Moats <<a href="mailto:rmoats@us.ibm.com" target="_blank">rmoats@us.ibm.com</a>> wrote:</span></tt><span><br><tt>> > I pretty much agree with Oleg here - I'm not sure an additional tag <br>> > for defects is needed.<br>> > The idea of a DvrImpact in the commit message is interesting, but <br>> > I'm not entirely convinced - if we<br>> > do it for one sub-project, do we need to do it for all sub-projects <br>> > and then what does that turn into?</tt><br><tt>> What does this mean? No other project should care about this. DVR is<br>> a core feature. </tt><br><br></span><tt>I'm trying to understand if (at its logical conclusion) we end up with commit tags for all features (i.e. RbacImpact, BareMetalImpact, DbImpact, etc.) and what that would do to the commit message...</tt></p></div></blockquote><div><br></div><div>Oh, you mean feature!</div><div><br></div><div>Well, even if we did have one per feature, we wouldn't have a single patch impacting multiple features; patches are meant to be small and cohesive in nature, and if they impacted more than one area they should be broken down. </div><div> </div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div><p><br><br><tt>Ryan Moats (regXboi)</tt><br>
</p></div>
<br>__________________________________________________________________________<br>
OpenStack Development Mailing List (not for usage questions)<br>
Unsubscribe: <a href="http://OpenStack-dev-request@lists.openstack.org?subject:unsubscribe" rel="noreferrer" target="_blank">OpenStack-dev-request@lists.openstack.org?subject:unsubscribe</a><br>
<a href="http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev" rel="noreferrer" target="_blank">http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev</a><br>
<br></blockquote></div><br></div></div>