<html xmlns:v="urn:schemas-microsoft-com:vml" xmlns:o="urn:schemas-microsoft-com:office:office" xmlns:w="urn:schemas-microsoft-com:office:word" xmlns:m="http://schemas.microsoft.com/office/2004/12/omml" xmlns="http://www.w3.org/TR/REC-html40">
<head>
<meta http-equiv="Content-Type" content="text/html; charset=us-ascii">
<meta name="Generator" content="Microsoft Word 14 (filtered medium)">
<style><!--
/* Font Definitions */
@font-face
{font-family:Calibri;
panose-1:2 15 5 2 2 2 4 3 2 4;}
/* Style Definitions */
p.MsoNormal, li.MsoNormal, div.MsoNormal
{margin:0in;
margin-bottom:.0001pt;
font-size:11.0pt;
font-family:"Calibri","sans-serif";}
a:link, span.MsoHyperlink
{mso-style-priority:99;
color:blue;
text-decoration:underline;}
a:visited, span.MsoHyperlinkFollowed
{mso-style-priority:99;
color:purple;
text-decoration:underline;}
p.MsoListParagraph, li.MsoListParagraph, div.MsoListParagraph
{mso-style-priority:34;
margin-top:0in;
margin-right:0in;
margin-bottom:0in;
margin-left:.5in;
margin-bottom:.0001pt;
font-size:11.0pt;
font-family:"Calibri","sans-serif";}
span.EmailStyle18
{mso-style-type:personal;
font-family:"Calibri","sans-serif";
color:windowtext;}
span.EmailStyle19
{mso-style-type:personal-reply;
font-family:"Calibri","sans-serif";
color:#1F497D;}
.MsoChpDefault
{mso-style-type:export-only;
font-size:10.0pt;}
@page WordSection1
{size:8.5in 11.0in;
margin:1.0in 1.0in 1.0in 1.0in;}
div.WordSection1
{page:WordSection1;}
/* List Definitions */
@list l0
{mso-list-id:1408183546;
mso-list-type:hybrid;
mso-list-template-ids:-773147560 67698703 67698713 67698715 67698703 67698713 67698715 67698703 67698713 67698715;}
@list l0:level1
{mso-level-tab-stop:none;
mso-level-number-position:left;
text-indent:-.25in;}
@list l0:level2
{mso-level-number-format:alpha-lower;
mso-level-tab-stop:none;
mso-level-number-position:left;
text-indent:-.25in;}
@list l0:level3
{mso-level-number-format:roman-lower;
mso-level-tab-stop:none;
mso-level-number-position:right;
text-indent:-9.0pt;}
@list l0:level4
{mso-level-tab-stop:none;
mso-level-number-position:left;
text-indent:-.25in;}
@list l0:level5
{mso-level-number-format:alpha-lower;
mso-level-tab-stop:none;
mso-level-number-position:left;
text-indent:-.25in;}
@list l0:level6
{mso-level-number-format:roman-lower;
mso-level-tab-stop:none;
mso-level-number-position:right;
text-indent:-9.0pt;}
@list l0:level7
{mso-level-tab-stop:none;
mso-level-number-position:left;
text-indent:-.25in;}
@list l0:level8
{mso-level-number-format:alpha-lower;
mso-level-tab-stop:none;
mso-level-number-position:left;
text-indent:-.25in;}
@list l0:level9
{mso-level-number-format:roman-lower;
mso-level-tab-stop:none;
mso-level-number-position:right;
text-indent:-9.0pt;}
ol
{margin-bottom:0in;}
ul
{margin-bottom:0in;}
--></style><!--[if gte mso 9]><xml>
<o:shapedefaults v:ext="edit" spidmax="1026" />
</xml><![endif]--><!--[if gte mso 9]><xml>
<o:shapelayout v:ext="edit">
<o:idmap v:ext="edit" data="1" />
</o:shapelayout></xml><![endif]-->
</head>
<body lang="EN-US" link="blue" vlink="purple">
<div class="WordSection1">
<p class="MsoNormal">Hi all,<o:p></o:p></p>
<p class="MsoNormal"><o:p> </o:p></p>
<p class="MsoNormal">The current bugfix I am working on[1] have <span style="font-size:10.0pt;font-family:"Arial","sans-serif";color:black;background:white">
unveiled / created a bug.<o:p></o:p></span></p>
<p class="MsoNormal">Test “WorkflowResumeTest.test_resume_different_task_states” sometimes fails because “task4” is executed twice instead of once (See unit test output and workflow below).<o:p></o:p></p>
<p class="MsoNormal"><o:p> </o:p></p>
<p class="MsoNormal">This happens because task2 on-complete is running task4 as expected but also task3 executes task4 by mistake.<o:p></o:p></p>
<p class="MsoNormal"><o:p> </o:p></p>
<p class="MsoNormal">It is not consistent but it happens quite often – This happens if the unit test resumes the WF and updates action execution of task2 and finishes task2 before task3 is finished.<o:p></o:p></p>
<p class="MsoNormal">Scenario:<o:p></o:p></p>
<p class="MsoNormal"><o:p> </o:p></p>
<p class="MsoListParagraph" style="text-indent:-.25in;mso-list:l0 level1 lfo2"><![if !supportLists]><span style="mso-list:Ignore">1.<span style="font:7.0pt "Times New Roman"">
</span></span><![endif]><span dir="LTR"></span>Task2 in method on_action_complete – changes task2 state to RUNNING.<o:p></o:p></p>
<p class="MsoListParagraph" style="text-indent:-.25in;mso-list:l0 level1 lfo2"><![if !supportLists]><span style="mso-list:Ignore">2.<span style="font:7.0pt "Times New Roman"">
</span></span><![endif]><span dir="LTR"></span>Task3 in method on_action_complete – changes task2 state to RUNNING (before task2 calls _on_task_state_change).<o:p></o:p></p>
<p class="MsoListParagraph" style="text-indent:-.25in;mso-list:l0 level1 lfo2"><![if !supportLists]><span style="mso-list:Ignore">3.<span style="font:7.0pt "Times New Roman"">
</span></span><![endif]><span dir="LTR"></span>Task3 in “_on_task_state_change” > “continue_workflow” > “DirectWorkflowController ._find_next_commands” – it finds task2 because task2 is in SUCCESS and processed = False and “_find_next_commands_for_task(task2)”
returns task4.<o:p></o:p></p>
<p class="MsoListParagraph" style="text-indent:-.25in;mso-list:l0 level1 lfo2"><![if !supportLists]><span style="mso-list:Ignore">4.<span style="font:7.0pt "Times New Roman"">
</span></span><![endif]><span dir="LTR"></span>Task3 executes command to RunTask task4.<o:p></o:p></p>
<p class="MsoListParagraph" style="text-indent:-.25in;mso-list:l0 level1 lfo2"><![if !supportLists]><span style="mso-list:Ignore">5.<span style="font:7.0pt "Times New Roman"">
</span></span><![endif]><span dir="LTR"></span>Task2 in “_on_task_state_change” > “continue_workflow” > “DirectWorkflowController ._find_next_commands” – it finds task2 because task2 is in SUCCESS and processed = False and “_find_next_commands_for_task(task2)”
returns task4.<o:p></o:p></p>
<p class="MsoListParagraph" style="text-indent:-.25in;mso-list:l0 level1 lfo2"><![if !supportLists]><span style="mso-list:Ignore">6.<span style="font:7.0pt "Times New Roman"">
</span></span><![endif]><span dir="LTR"></span>Task2 executes command to RunTask task4.<o:p></o:p></p>
<p class="MsoNormal"><o:p> </o:p></p>
<p class="MsoNormal"><o:p> </o:p></p>
<p class="MsoNormal">[1] - <a href="https://review.openstack.org/#/c/253819/">https://review.openstack.org/#/c/253819/</a><o:p></o:p></p>
<p class="MsoNormal"><o:p> </o:p></p>
<p class="MsoNormal"><span style="font-family:"Courier New""><o:p> </o:p></span></p>
<p class="MsoNormal">If I am not mistaken – this issue also exists in the current code and my bugfix only made it much more often. Can you confirm?<o:p></o:p></p>
<p class="MsoNormal">I don’t have enough knowledge on how to fix this issue…<o:p></o:p></p>
<p class="MsoNormal">For now – I have modified the test_resume_different_task_states unit test to wait for task3 to be processed before updating the action execution of task2.<o:p></o:p></p>
<p class="MsoNormal">If you agree this bug exist today as well – we can proceed with my bugfix and open a different bug for that issue.<o:p></o:p></p>
<p class="MsoNormal"><span style="font-family:"Courier New""><o:p> </o:p></span></p>
<p class="MsoNormal">Thanks.<o:p></o:p></p>
<p class="MsoNormal"><span style="font-family:"Courier New""><o:p> </o:p></span></p>
<p class="MsoNormal"><span style="font-family:"Courier New""><o:p> </o:p></span></p>
<p class="MsoNormal"><span style="font-family:"Courier New""><o:p> </o:p></span></p>
<p class="MsoNormal"><span style="font-family:"Courier New"">[stack@melisha-devstack mistral(keystone_admin)]$ tox -e py27 -- WorkflowResumeTest.test_resume_different_task_states<o:p></o:p></span></p>
<p class="MsoNormal"><span style="font-family:"Courier New"">...<o:p></o:p></span></p>
<p class="MsoNormal"><span style="font-family:"Courier New"">======================================================================<o:p></o:p></span></p>
<p class="MsoNormal"><span style="font-family:"Courier New"">FAIL: mistral.tests.unit.engine.test_workflow_resume.WorkflowResumeTest.test_resume_different_task_states<o:p></o:p></span></p>
<p class="MsoNormal"><span style="font-family:"Courier New"">tags: worker-0<o:p></o:p></span></p>
<p class="MsoNormal"><span style="font-family:"Courier New"">----------------------------------------------------------------------<o:p></o:p></span></p>
<p class="MsoNormal"><span style="font-family:"Courier New"">pythonlogging:'': {{{WARNING [oslo_db.sqlalchemy.utils] Id not in sort_keys; is sort_keys unique?}}}<o:p></o:p></span></p>
<p class="MsoNormal"><span style="font-family:"Courier New"">stderr: {{{<o:p></o:p></span></p>
<p class="MsoNormal"><span style="font-family:"Courier New"">/opt/stack/mistral/.tox/py27/local/lib/python2.7/site-packages/novaclient/v2/client.py:109: UserWarning: 'novaclient.v2.client.Client' is not designed to be initialized directly. It is inner class
of novaclient. Please, use 'novaclient.client.Client' instead. Related lp bug-report: 1493576<o:p></o:p></span></p>
<p class="MsoNormal"><span style="font-family:"Courier New""> _LW("'novaclient.v2.client.Client' is not designed to be "<o:p></o:p></span></p>
<p class="MsoNormal"><span style="font-family:"Courier New"">}}}<o:p></o:p></span></p>
<p class="MsoNormal"><span style="font-family:"Courier New""><o:p> </o:p></span></p>
<p class="MsoNormal"><span style="font-family:"Courier New"">stdout: {{{<o:p></o:p></span></p>
<p class="MsoNormal"><span style="font-family:"Courier New"">Engine test case exception occurred: 4 != 5<o:p></o:p></span></p>
<p class="MsoNormal"><span style="font-family:"Courier New"">Exception type: <class 'testtools.matchers._impl.MismatchError'><o:p></o:p></span></p>
<p class="MsoNormal"><span style="font-family:"Courier New""><o:p> </o:p></span></p>
<p class="MsoNormal"><span style="font-family:"Courier New"">Printing workflow executions...<o:p></o:p></span></p>
<p class="MsoNormal"><span style="font-family:"Courier New""><o:p> </o:p></span></p>
<p class="MsoNormal"><span style="font-family:"Courier New"">wb.wf1 [state=SUCCESS, output={u'__execution': {u'params': {}, u'id': u'2807dd99-ca6f-49d7-886d-7d3b79e1c49e', u'spec': {u'type': u'direct', u'name': u'wf1', u'tasks': {u'task4': {u'type': u'direct',
u'name': u'task4', u'version': u'2.0', u'action': u'std.echo output="Task 4"'}, u'task2': {u'type': u'direct', u'name': u'task2', u'on-complete': [u'task4'], u'version': u'2.0', u'action': u'std.mistral_http url="<a href="http://google.com">http://google.com</a>"'},
u'task3': {u'type': u'direct', u'name': u'task3', u'version': u'2.0', u'action': u'std.echo output="Task 3"'}, u'task1': {u'type': u'direct', u'name': u'task1', u'on-complete': [u'task3', u'pause'], u'version': u'2.0', u'action': u'std.echo output="Hi!"'}},
u'version': u'2.0'}, u'input': {}}, u'task4': u'Task 4', u'task3': u'Task 3', u'__tasks': {u'848c6e92-b1b1-4d54-b11d-c93cfb4fc88f': u'task2', u'00a546e7-8da9-4603-b6be-54d58b14c625': u'task1'}}]<o:p></o:p></span></p>
<p class="MsoNormal"><span style="font-family:"Courier New""> task2 [id=848c6e92-b1b1-4d54-b11d-c93cfb4fc88f, state=SUCCESS, published={}]<o:p></o:p></span></p>
<p class="MsoNormal"><span style="font-family:"Courier New""> task1 [id=00a546e7-8da9-4603-b6be-54d58b14c625, state=SUCCESS, published={}]<o:p></o:p></span></p>
<p class="MsoNormal"><span style="font-family:"Courier New""> task3 [id=8ce20324-7fba-4424-bcd2-1e0c9b27fd4a, state=SUCCESS, published={}]<o:p></o:p></span></p>
<p class="MsoNormal"><span style="font-family:"Courier New""> <span style="background:yellow;mso-highlight:yellow">
task4 [id=3758de43-9bc3-4ac9-b3f3-29eb543b16ef, state=SUCCESS, published={}]<o:p></o:p></span></span></p>
<p class="MsoNormal"><span style="font-family:"Courier New";background:yellow;mso-highlight:yellow"> task4 [id=f12ee464-0ba5-48c7-8423-9f425a00e675, state=SUCCESS, published={}]</span><span style="font-family:"Courier New""><o:p></o:p></span></p>
<p class="MsoNormal"><span style="font-family:"Courier New"">}}}<o:p></o:p></span></p>
<p class="MsoNormal"><span style="font-family:"Courier New""><o:p> </o:p></span></p>
<p class="MsoNormal"><span style="font-family:"Courier New"">Traceback (most recent call last):<o:p></o:p></span></p>
<p class="MsoNormal"><span style="font-family:"Courier New""> File "mistral/tests/unit/engine/test_workflow_resume.py", line 321, in test_resume_different_task_states<o:p></o:p></span></p>
<p class="MsoNormal"><span style="font-family:"Courier New""> self.assertEqual(4, len(wf_ex.task_executions))<o:p></o:p></span></p>
<p class="MsoNormal"><span style="font-family:"Courier New""> File "/opt/stack/mistral/.tox/py27/local/lib/python2.7/site-packages/testtools/testcase.py", line 350, in assertEqual<o:p></o:p></span></p>
<p class="MsoNormal"><span style="font-family:"Courier New""> self.assertThat(observed, matcher, message)<o:p></o:p></span></p>
<p class="MsoNormal"><span style="font-family:"Courier New""> File "/opt/stack/mistral/.tox/py27/local/lib/python2.7/site-packages/testtools/testcase.py", line 435, in assertThat<o:p></o:p></span></p>
<p class="MsoNormal"><span style="font-family:"Courier New""> raise mismatch_error<o:p></o:p></span></p>
<p class="MsoNormal"><span style="font-family:"Courier New"">testtools.matchers._impl.<span style="background:yellow;mso-highlight:yellow">MismatchError: 4 != 5</span><o:p></o:p></span></p>
<p class="MsoNormal"><span style="font-family:"Courier New"">Ran 1 tests in 15.517s (+2.591s)<o:p></o:p></span></p>
<p class="MsoNormal"><span style="font-family:"Courier New"">FAILED (id=301, failures=1 (+1))<o:p></o:p></span></p>
<p class="MsoNormal"><span style="font-family:"Courier New"">error: testr failed (1)<o:p></o:p></span></p>
<p class="MsoNormal"><span style="font-family:"Courier New"">ERROR: InvocationError: '/opt/stack/mistral/.tox/py27/bin/python setup.py testr --slowest --testr-args=WorkflowResumeTest.test_resume_different_task_states'<o:p></o:p></span></p>
<p class="MsoNormal"><span style="font-family:"Courier New"">___________________________________________________________________________________________________________________________________ summary ___________________________________________________________________________________________________________________________________<o:p></o:p></span></p>
<p class="MsoNormal"><span style="font-family:"Courier New"">ERROR: py27: commands failed<o:p></o:p></span></p>
<p class="MsoNormal"><span style="font-family:"Courier New""><o:p> </o:p></span></p>
<p class="MsoNormal"><span style="font-family:"Courier New""><o:p> </o:p></span></p>
<p class="MsoNormal"><span style="font-family:"Courier New""><o:p> </o:p></span></p>
<div style="border:none;border-bottom:solid windowtext 1.0pt;padding:0in 0in 1.0pt 0in">
<p class="MsoNormal"><span style="font-family:"Courier New""><o:p> </o:p></span></p>
</div>
<p class="MsoNormal"><span style="font-family:"Courier New""><o:p> </o:p></span></p>
<p class="MsoNormal"><span style="font-family:"Courier New""><o:p> </o:p></span></p>
<p class="MsoNormal">Unit test workflow:<o:p></o:p></p>
<p class="MsoNormal"><span style="font-family:"Courier New""><o:p> </o:p></span></p>
<p class="MsoNormal"><span style="font-family:"Courier New""><o:p> </o:p></span></p>
<p class="MsoNormal"><span style="font-family:"Courier New"">---<o:p></o:p></span></p>
<p class="MsoNormal"><span style="font-family:"Courier New"">version: '2.0'<o:p></o:p></span></p>
<p class="MsoNormal"><span style="font-family:"Courier New""><o:p> </o:p></span></p>
<p class="MsoNormal"><span style="font-family:"Courier New"">name: wb<o:p></o:p></span></p>
<p class="MsoNormal"><span style="font-family:"Courier New""><o:p> </o:p></span></p>
<p class="MsoNormal"><span style="font-family:"Courier New"">workflows:<o:p></o:p></span></p>
<p class="MsoNormal"><span style="font-family:"Courier New""> wf1:<o:p></o:p></span></p>
<p class="MsoNormal"><span style="font-family:"Courier New""> type: direct<o:p></o:p></span></p>
<p class="MsoNormal"><span style="font-family:"Courier New""><o:p> </o:p></span></p>
<p class="MsoNormal"><span style="font-family:"Courier New""> tasks:<o:p></o:p></span></p>
<p class="MsoNormal"><span style="font-family:"Courier New""> task1:<o:p></o:p></span></p>
<p class="MsoNormal"><span style="font-family:"Courier New""> action: std.echo output="Hi!"<o:p></o:p></span></p>
<p class="MsoNormal"><span style="font-family:"Courier New""> on-complete:<o:p></o:p></span></p>
<p class="MsoNormal"><span style="font-family:"Courier New""> - task3<o:p></o:p></span></p>
<p class="MsoNormal"><span style="font-family:"Courier New""> - pause<o:p></o:p></span></p>
<p class="MsoNormal"><span style="font-family:"Courier New""><o:p> </o:p></span></p>
<p class="MsoNormal"><span style="font-family:"Courier New""> task2:<o:p></o:p></span></p>
<p class="MsoNormal"><span style="font-family:"Courier New""> action: std.mistral_http url="<a href="http://google.com">http://google.com</a>"<o:p></o:p></span></p>
<p class="MsoNormal"><span style="font-family:"Courier New""> # This one won't be finished when execution is already PAUSED.<o:p></o:p></span></p>
<p class="MsoNormal"><span style="font-family:"Courier New""> on-complete:<o:p></o:p></span></p>
<p class="MsoNormal"><span style="font-family:"Courier New""> - task4<o:p></o:p></span></p>
<p class="MsoNormal"><span style="font-family:"Courier New""><o:p> </o:p></span></p>
<p class="MsoNormal"><span style="font-family:"Courier New""> task3:<o:p></o:p></span></p>
<p class="MsoNormal"><span style="font-family:"Courier New""> action: std.echo output="Task 3"<o:p></o:p></span></p>
<p class="MsoNormal"><span style="font-family:"Courier New""><o:p> </o:p></span></p>
<p class="MsoNormal"><span style="font-family:"Courier New""> task4:<o:p></o:p></span></p>
<p class="MsoNormal"><span style="font-family:"Courier New""> action: std.echo output="Task 4"<o:p></o:p></span></p>
<p class="MsoNormal"><span style="font-family:"Courier New""><o:p> </o:p></span></p>
<p class="MsoNormal"><span style="font-family:"Courier New""><o:p> </o:p></span></p>
<p class="MsoNormal"><span style="font-family:"Courier New""><o:p> </o:p></span></p>
<p class="MsoNormal"><span style="font-family:"Courier New""><o:p> </o:p></span></p>
<p class="MsoNormal"><span style="font-family:"Courier New""><o:p> </o:p></span></p>
<p class="MsoNormal"><span style="font-family:"Courier New""><o:p> </o:p></span></p>
<p class="MsoNormal"><span style="font-family:"Courier New""><o:p> </o:p></span></p>
</div>
</body>
</html>