<div dir="ltr"><div><div><div><div><div>Thanks for putting up that fix Matt.<br></div><br>The dependency on trunk python-troveclient (for stable/kilo) definitely seems <br>screwy-- but I'm wondering if this was done for backwards compatibility reasons?<br></div>(i.e. to ensure the latest version of python-troveclient should be able to work <br>correctly against all previous releases of trove.) <br></div></div><br></div><div>Either way, I think we should be honoring the requirements specified for the respective<br></div><div>releases in g-r, so I think that this is the right fix.<br></div><div><br></div><div>Cheers,<br></div><div>Nikhil<br></div><div><div><div><div><div><div><br><br></div></div></div></div></div></div></div><div class="gmail_extra"><br><div class="gmail_quote">On Tue, Nov 17, 2015 at 7:42 PM, Matt Riedemann <span dir="ltr"><<a href="mailto:mriedem@linux.vnet.ibm.com" target="_blank">mriedem@linux.vnet.ibm.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><span class=""><br>
<br>
On 11/17/2015 9:27 PM, Matt Riedemann wrote:<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
<br>
<br>
On 11/17/2015 9:22 PM, Matt Riedemann wrote:<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
I noticed this failing today:<br>
<br>
<a href="http://logs.openstack.org/81/206681/3/check/gate-trove-python27/45d645d/console.html#_2015-11-17_17_07_28_061" rel="noreferrer" target="_blank">http://logs.openstack.org/81/206681/3/check/gate-trove-python27/45d645d/console.html#_2015-11-17_17_07_28_061</a><br>
<br>
<br>
<br>
Looks like <a href="https://review.openstack.org/#/c/218701/" rel="noreferrer" target="_blank">https://review.openstack.org/#/c/218701/</a> and maybe the<br>
dependent python-troveclient change would need to be backported to<br>
stable/kilo (neither are clean backports), or we can just skip the test<br>
on stable/kilo if there is a good reason why it won't work.<br>
<br>
</blockquote>
<br>
I also see that the unit test job on stable/kilo is pulling in trunk<br>
python-troveclient:<br>
<br>
<a href="http://logs.openstack.org/81/206681/3/check/gate-trove-python27/45d645d/console.html#_2015-11-17_17_07_28_393" rel="noreferrer" target="_blank">http://logs.openstack.org/81/206681/3/check/gate-trove-python27/45d645d/console.html#_2015-11-17_17_07_28_393</a><br>
<br>
<br>
Even though we have troveclient capped at 1.1.0 in kilo g-r:<br>
<br>
<a href="https://github.com/openstack/requirements/blob/stable/kilo/global-requirements.txt#L136" rel="noreferrer" target="_blank">https://github.com/openstack/requirements/blob/stable/kilo/global-requirements.txt#L136</a><br>
<br>
<br>
So how is that happening?<br>
<br>
Oh, because of this:<br>
<br>
<a href="https://github.com/openstack/trove/blob/stable/kilo/test-requirements.txt#L17" rel="noreferrer" target="_blank">https://github.com/openstack/trove/blob/stable/kilo/test-requirements.txt#L17</a><br>
<br>
<br>
And that's terrible....why are we doing that?<br>
<br>
</blockquote>
<br></span>
Attempting to fix here: <a href="https://review.openstack.org/#/c/246735/" rel="noreferrer" target="_blank">https://review.openstack.org/#/c/246735/</a><div class="HOEnZb"><div class="h5"><br>
<br>
-- <br>
<br>
Thanks,<br>
<br>
Matt Riedemann<br>
<br>
<br>
__________________________________________________________________________<br>
OpenStack Development Mailing List (not for usage questions)<br>
Unsubscribe: <a href="http://OpenStack-dev-request@lists.openstack.org?subject:unsubscribe" rel="noreferrer" target="_blank">OpenStack-dev-request@lists.openstack.org?subject:unsubscribe</a><br>
<a href="http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev" rel="noreferrer" target="_blank">http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev</a><br>
</div></div></blockquote></div><br></div>