<div dir="ltr"><div class="gmail_extra"><div class="gmail_quote">On 9 November 2015 at 12:44, Dmitry Tantsur <span dir="ltr"><<a href="mailto:dtantsur@redhat.com" target="_blank">dtantsur@redhat.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">Hi OOO'ers, hopefully the subject caught your attentions :)<br>
<br>
Currently, tripleoclient exposes several commands in "openstack baremetal" and "openstack baremetal introspection" namespaces belonging to ironic and ironic-inspector accordingly. TL;DR of this email is to deprecate them and move to TripleO-specific namespaces. Read on to know why.<br>
<br>
Problem<br>
=======<br>
<br>
I realized that we're doing a wrong thing when people started asking me why "baremetal introspection start" and "baremetal introspection bulk start" behave so differently (the former is from ironic-inspector, the latter is from tripleoclient). The problem with TripleO commands is that they're highly opinionated workflows commands, but there's no way a user can distinguish them from general-purpose ironic/ironic-inspector commands. The way some of them work is not generic enough ("baremetal import"), or uses different defaults from an upstream project ("configure boot"), or does something completely unacceptable upstream (e.g. the way "introspection bulk start" deals with node states).<br></blockquote><div><br></div><div>A big +1 to the idea.<br><br>We originally done this because we wanted to make it feel more "integrated", but it never quite worked. I completely agree with all the justifications below.<br></div><div><br><br></div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
So, here are commands that tripleoclient exposes with my comments:<br>
<br>
1. baremetal instackenv validate<br>
<br>
This command assumes there's an "baremetal instackenv" object, while instackenv is a tripleo-specific file format.<br>
<br>
2. baremetal import<br>
<br>
This command supports a limited subset of ironic drivers and driver properties, only those known to os-cloud-config.<br>
<br>
3. baremetal introspection bulk start<br>
<br>
This command does several bad (IMO) things:<br>
a. Messes with ironic node states<br>
b. Operates implicitly on all nodes (in a wrong state)<br>
c. Defaults to polling<br>
<br>
4. baremetal show capabilities<br>
<br>
This is the only commands that is generic enough and could actually make it to ironicclient itself.<br>
<br>
5. baremetal introspection bulk status<br>
<br>
See "bulk start" above.<br>
<br>
6. baremetal configure ready state<br>
<br>
First of all, this and the next command use "baremetal configure" prefix. I would not promise we'll never start using it in ironic, breaking the whole TripleO.<br>
<br>
Seconds, it's actually DELL-specific.<br></blockquote><div><br></div><div>heh, that I didn't know!<br></div><div> </div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
<br>
7. baremetal configure boot<br>
<br>
This one is nearly ok, but it defaults to local boot, which is not an upstream default. Default values for images may not work outside of TripleO as well.<br>
<br>
Proposal<br>
========<br>
<br>
As we already have "openstack undercloud" and "openstack overcloud" prefixes for TripleO, I suggest we move these commands under "openstack overcloud nodes" namespace. So we end up with:<br>
<br>
overcloud nodes import<br>
overcloud nodes configure ready state --drac<br>
overcloud nodes configure boot<br></blockquote><div><br></div><div>I think this is probably okay, but I wonder if "nodes" is a bit generic? Why not "overcloud baremetal" for consistency?<br><br></div><div> <br></div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
As you see, I require an explicit --drac argument for "ready state" command. As to the remaining commands:<br>
<br>
1. baremetal introspection status --all<br>
<br>
This is fine to move to inspector-client, as inspector knows which nodes are/were on introspection. We'll need a new API though.<br></blockquote><div><br></div><div>A new API endpoint in Ironic Inspector?<br><br><br></div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
2. baremetal show capabilities<br>
<br>
We'll have this or similar command in ironic, hopefully this cycle.<br>
<br>
3. overcloud nodes introspect --poll --allow-available<br>
<br>
I believe that we need to make 2 things explicit in this replacement for "introspection bulk status": polling and operating on "available" nodes.<br>
<br>
4. overcloud nodes import --dry-run<br>
<br>
could be a replacement for "baremetal instackenv validate".<br>
<br>
<br>
Please let me know what you think.<br></blockquote><div><br></div><div>Thanks for bringing this up, it should make everything much clearer for everyone.<br><br></div><div> </div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
<br>
Cheers,<br>
Dmitry.<br>
<br>
<br>
__________________________________________________________________________<br>
OpenStack Development Mailing List (not for usage questions)<br>
Unsubscribe: <a href="http://OpenStack-dev-request@lists.openstack.org?subject:unsubscribe" rel="noreferrer" target="_blank">OpenStack-dev-request@lists.openstack.org?subject:unsubscribe</a><br>
<a href="http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev" rel="noreferrer" target="_blank">http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev</a><br>
</blockquote></div><br></div></div>