<div dir="ltr"><div><div>>But it was released with 2961e82 which was the backward incompatible
requests exception change, which we now have a fix for that we want to
release, but would include 0cd5812.<br></div><br></div>I suppose we need to revert 0cd5812 change too, cut new release and then revert revert of 0cd5812 :)</div><div class="gmail_extra"><br><div class="gmail_quote">On Wed, Oct 28, 2015 at 8:44 PM, Matt Riedemann <span dir="ltr"><<a href="mailto:mriedem@linux.vnet.ibm.com" target="_blank">mriedem@linux.vnet.ibm.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div class="HOEnZb"><div class="h5"><br>
<br>
On 10/28/2015 12:28 PM, Matt Riedemann wrote:<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
<br>
<br>
On 10/28/2015 10:41 AM, Ivan Kolodyazhny wrote:<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
Matt,<br>
<br>
Thank you for bring this topic to the ML.<br>
<br>
In cinder, we've merged [1] patch to unblock gates. I've proposed other<br>
patch [2] to fix global-requirements for the stable/liberty branch.<br>
<br>
<br>
[1] <a href="https://review.openstack.org/#/c/239837/" rel="noreferrer" target="_blank">https://review.openstack.org/#/c/239837/</a><br>
[2] <a href="https://review.openstack.org/#/c/239799/" rel="noreferrer" target="_blank">https://review.openstack.org/#/c/239799/</a><br>
<br>
Regards,<br>
Ivan Kolodyazhny,<br>
<a href="http://blog.e0ne.info/" rel="noreferrer" target="_blank">http://blog.e0ne.info/</a><br>
<br>
On Thu, Oct 29, 2015 at 12:13 AM, Matt Riedemann<br>
<<a href="mailto:mriedem@linux.vnet.ibm.com" target="_blank">mriedem@linux.vnet.ibm.com</a> <mailto:<a href="mailto:mriedem@linux.vnet.ibm.com" target="_blank">mriedem@linux.vnet.ibm.com</a>>> wrote:<br>
<br>
<br>
<br>
On 10/28/2015 9:22 AM, Matt Riedemann wrote:<br>
<br>
<br>
<br>
On 10/28/2015 9:06 AM, Yuriy Nesenenko wrote:<br>
<br>
Hi. Look at <a href="https://review.openstack.org/#/c/239837/" rel="noreferrer" target="_blank">https://review.openstack.org/#/c/239837/</a><br>
<br>
On Wed, Oct 28, 2015 at 3:52 PM, Matt Riedemann<br>
<<a href="mailto:mriedem@linux.vnet.ibm.com" target="_blank">mriedem@linux.vnet.ibm.com</a><br>
<mailto:<a href="mailto:mriedem@linux.vnet.ibm.com" target="_blank">mriedem@linux.vnet.ibm.com</a>><br>
<mailto:<a href="mailto:mriedem@linux.vnet.ibm.com" target="_blank">mriedem@linux.vnet.ibm.com</a><br>
<mailto:<a href="mailto:mriedem@linux.vnet.ibm.com" target="_blank">mriedem@linux.vnet.ibm.com</a>>>> wrote:<br>
<br>
That job is failing at a decent rate, tracking with bug:<br>
<br>
<a href="https://bugs.launchpad.net/cinder/+bug/1510656" rel="noreferrer" target="_blank">https://bugs.launchpad.net/cinder/+bug/1510656</a><br>
<br>
It lines up with the novaclient 2.33 release on 10/27,<br>
I'm checking<br>
out what the change was that caused the regression.<br>
<br>
This is a heads up that rechecks on this failure<br>
probably won't help.<br>
<br>
So far I haven't seen any related patches up to fix it<br>
although<br>
there were already 2 bugs reported when I got in this<br>
morning.<br>
<br>
--<br>
<br>
Thanks,<br>
<br>
Matt Riedemann<br>
<br>
<br>
<br>
<br>
__________________________________________________________________________<br>
<br>
<br>
OpenStack Development Mailing List (not for usage<br>
questions)<br>
Unsubscribe:<br>
<br>
<a href="http://OpenStack-dev-request@lists.openstack.org?subject:unsubscribe" rel="noreferrer" target="_blank">OpenStack-dev-request@lists.openstack.org?subject:unsubscribe</a><br>
<<a href="http://OpenStack-dev-request@lists.openstack.org?subject:unsubscribe" rel="noreferrer" target="_blank">http://OpenStack-dev-request@lists.openstack.org?subject:unsubscribe</a>><br>
<br>
<br>
<<a href="http://OpenStack-dev-request@lists.openstack.org?subject:unsubscribe" rel="noreferrer" target="_blank">http://OpenStack-dev-request@lists.openstack.org?subject:unsubscribe</a>><br>
<br>
<a href="http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev" rel="noreferrer" target="_blank">http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev</a><br>
<br>
<br>
<br>
<br>
<br>
__________________________________________________________________________<br>
<br>
<br>
OpenStack Development Mailing List (not for usage questions)<br>
Unsubscribe:<br>
<br>
<a href="http://OpenStack-dev-request@lists.openstack.org?subject:unsubscribe" rel="noreferrer" target="_blank">OpenStack-dev-request@lists.openstack.org?subject:unsubscribe</a><br>
<<a href="http://OpenStack-dev-request@lists.openstack.org?subject:unsubscribe" rel="noreferrer" target="_blank">http://OpenStack-dev-request@lists.openstack.org?subject:unsubscribe</a>><br>
<br>
<a href="http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev" rel="noreferrer" target="_blank">http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev</a><br>
<br>
<br>
Heh, well that's 3 bugs then, I didn't see that one. jgriffith<br>
and I<br>
were talking in IRC about just handling both exceptions in<br>
cinder to fix<br>
this but we also agreed that this is a backward incompatible<br>
change on<br>
the novaclient side, which was also discussed in the original<br>
novaclient<br>
wishlist bug that prompted the breaking change.<br>
<br>
Given the backward compat issues, we might not just be breaking<br>
cinder<br>
here, so I've proposed a revert of the novaclient change with<br>
justification in the commit message:<br>
<br>
<a href="https://review.openstack.org/#/c/239941/" rel="noreferrer" target="_blank">https://review.openstack.org/#/c/239941/</a><br>
<br>
At least with the cinder change above we're OK for mitaka, and<br>
logstash<br>
isn't yet showing failures for cinder in stable/liberty, but<br>
given the<br>
requirements there it will be a failure in cinder python34<br>
tests in<br>
stalbe/liberty also - so we can backport the cinder fix or<br>
block the<br>
2.33 novaclient version on stable/liberty global-requirements<br>
depending<br>
on what we do with the proposed novaclient revert.<br>
<br>
<br>
I have an alternative to the revert here:<br>
<br>
<a href="https://review.openstack.org/#/c/239963/" rel="noreferrer" target="_blank">https://review.openstack.org/#/c/239963/</a><br>
<br>
That makes novaclient.exceptions.RequestTimeout extend<br>
requests.Timeout so that older cinder continues to work.<br>
<br>
I also have changes to block novaclient 2.33.0 in g-r on master and<br>
stable/liberty:<br>
<br>
<br>
<a href="https://review.openstack.org/#/q/I6e7657b60308b30eed89b269810c1f37cce43063,n,z" rel="noreferrer" target="_blank">https://review.openstack.org/#/q/I6e7657b60308b30eed89b269810c1f37cce43063,n,z</a><br>
<br>
<br>
I personally think we need to block 2.33.0 since it breaks cinder,<br>
then release a new version of novaclient with either the revert or<br>
the alternative change to extend requests.Timeout.<br>
<br>
If we block novaclient 2.33.0 then we can also revert the workaround<br>
in cinder (which would start breaking if we reverted the new<br>
exception type out of novaclient w/o blacklisting 2.33 first).<br>
<br>
<br>
--<br>
<br>
Thanks,<br>
<br>
Matt Riedemann<br>
<br>
<br>
<br>
__________________________________________________________________________<br>
<br>
OpenStack Development Mailing List (not for usage questions)<br>
Unsubscribe:<br>
<a href="http://OpenStack-dev-request@lists.openstack.org?subject:unsubscribe" rel="noreferrer" target="_blank">OpenStack-dev-request@lists.openstack.org?subject:unsubscribe</a><br>
<br>
<<a href="http://OpenStack-dev-request@lists.openstack.org?subject:unsubscribe" rel="noreferrer" target="_blank">http://OpenStack-dev-request@lists.openstack.org?subject:unsubscribe</a>><br>
<a href="http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev" rel="noreferrer" target="_blank">http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev</a><br>
<br>
<br>
<br>
<br>
__________________________________________________________________________<br>
<br>
OpenStack Development Mailing List (not for usage questions)<br>
Unsubscribe:<br>
<a href="http://OpenStack-dev-request@lists.openstack.org?subject:unsubscribe" rel="noreferrer" target="_blank">OpenStack-dev-request@lists.openstack.org?subject:unsubscribe</a><br>
<a href="http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev" rel="noreferrer" target="_blank">http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev</a><br>
<br>
</blockquote>
<br>
The novaclient revert patch is approved:<br>
<br>
<a href="https://review.openstack.org/#/c/239941/" rel="noreferrer" target="_blank">https://review.openstack.org/#/c/239941/</a><br>
<br>
Once that is merged I'll propose a release request for novaclient.<br>
<br>
I've got g-r patches for master and stable/liberty to block 2.33:<br>
<br>
<a href="https://review.openstack.org/#/q/I6e7657b60308b30eed89b269810c1f37cce43063,n,z" rel="noreferrer" target="_blank">https://review.openstack.org/#/q/I6e7657b60308b30eed89b269810c1f37cce43063,n,z</a><br>
<br>
<br>
Once those land and we've synced the change to cinder, we can revert the<br>
cinder workaround.<br>
<br>
</blockquote>
<br></div></div>
So the revert is merged [1] but now I'm stuck as to the version and/or git commit to use for the next release.<br>
<br>
The changes since 2.33.0 are:<br>
<br>
mriedem@ubuntu:~/git/python-novaclient$ git log --oneline --no-merges 2.33.0..<br>
63c7a57 Revert "Do not expose exceptions from requests library"<br>
217e7c1 Updated from global requirements<br>
0cd5812 Remove novaclient.v1_1 module<br>
<br>
And when I requested the 2.33.0 release [2], it was on 217e7c1 but they changed it to be w/o 0cd5812 because that is considered a backward incompatible change. But it was released with 2961e82 which was the backward incompatible requests exception change, which we now have a fix for that we want to release, but would include 0cd5812.<br>
<br>
So do we just release novaclient trunk as 3.0? We still have the g-r blacklist changes for 2.33.0 in mitaka and liberty so we wouldn't be using that version in tests (assuming that's merged in g-r). So then people have to move up to 3.0 if they want the latest novaclient changes.<br>
<br>
This is a bit gross.<br>
<br>
[1] <a href="https://review.openstack.org/#/c/239941/" rel="noreferrer" target="_blank">https://review.openstack.org/#/c/239941/</a><br>
[2] <a href="https://review.openstack.org/#/c/239450/" rel="noreferrer" target="_blank">https://review.openstack.org/#/c/239450/</a><div class="HOEnZb"><div class="h5"><br>
<br>
-- <br>
<br>
Thanks,<br>
<br>
Matt Riedemann<br>
<br>
<br>
__________________________________________________________________________<br>
OpenStack Development Mailing List (not for usage questions)<br>
Unsubscribe: <a href="http://OpenStack-dev-request@lists.openstack.org?subject:unsubscribe" rel="noreferrer" target="_blank">OpenStack-dev-request@lists.openstack.org?subject:unsubscribe</a><br>
<a href="http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev" rel="noreferrer" target="_blank">http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev</a><br>
</div></div></blockquote></div><br><br clear="all"><br>-- <br><div class="gmail_signature"><div dir="ltr">Best regards,<br>Andrey Kurilin.<br></div></div>
</div>